From: Florian Westphal <fw@strlen.de>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netfilter-devel@vger.kernel.org, bridge@lists.linux.dev,
netdev@vger.kernel.org
Subject: Re: [PATCH v14 nf-next 2/3] netfilter: bridge: Add conntrack double vlan and pppoe
Date: Sat, 6 Sep 2025 23:11:30 +0200 [thread overview]
Message-ID: <aLyjgj5CP5KIvUdl@strlen.de> (raw)
In-Reply-To: <20250708151209.2006140-3-ericwouds@gmail.com>
Eric Woudstra <ericwouds@gmail.com> wrote:
> enum ip_conntrack_info ctinfo;
> + u32 len, data_len = U32_MAX;
> + int ret, offset = 0;
> struct nf_conn *ct;
> - u32 len;
> - int ret;
> + __be16 outer_proto;
>
> ct = nf_ct_get(skb, &ctinfo);
> if ((ct && !nf_ct_is_template(ct)) ||
> ctinfo == IP_CT_UNTRACKED)
> return NF_ACCEPT;
>
> + if (ct && nf_ct_zone_id(nf_ct_zone(ct), CTINFO2DIR(ctinfo)) !=
> + NF_CT_DEFAULT_ZONE_ID) {
> + switch (skb->protocol) {
> + case htons(ETH_P_PPP_SES): {
> + struct ppp_hdr {
> + struct pppoe_hdr hdr;
> + __be16 proto;
> + } *ph;
> +
This function is getting too long, please move this to a helper
function.
next prev parent reply other threads:[~2025-09-06 21:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 15:12 [PATCH v14 nf-next 0/3] conntrack: bridge: add double vlan, pppoe and pppoe-in-q Eric Woudstra
2025-07-08 15:12 ` [PATCH v14 nf-next 1/3] netfilter: utils: nf_checksum(_partial) correct data!=networkheader Eric Woudstra
2025-09-06 21:09 ` Florian Westphal
2025-07-08 15:12 ` [PATCH v14 nf-next 2/3] netfilter: bridge: Add conntrack double vlan and pppoe Eric Woudstra
2025-07-08 22:00 ` Florian Westphal
2025-09-06 21:11 ` Florian Westphal [this message]
2025-09-09 9:17 ` Eric Woudstra
2025-07-08 15:12 ` [PATCH v14 nf-next 3/3] netfilter: nft_chain_filter: Add bridge " Eric Woudstra
2025-07-08 22:02 ` Florian Westphal
2025-07-11 12:55 ` Eric Woudstra
2025-07-11 14:14 ` Florian Westphal
2025-07-12 10:08 ` Eric Woudstra
2025-07-12 10:50 ` Florian Westphal
2025-09-02 8:48 ` Eric Woudstra
2025-09-02 13:18 ` Florian Westphal
2025-09-06 12:26 ` Eric Woudstra
2025-09-06 21:14 ` Florian Westphal
2025-09-09 9:21 ` Eric Woudstra
2025-09-09 14:26 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLyjgj5CP5KIvUdl@strlen.de \
--to=fw@strlen.de \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.