From: Florian Westphal <fw@strlen.de>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netfilter-devel@vger.kernel.org, bridge@lists.linux.dev,
netdev@vger.kernel.org
Subject: Re: [PATCH v14 nf-next 3/3] netfilter: nft_chain_filter: Add bridge double vlan and pppoe
Date: Tue, 9 Sep 2025 16:26:07 +0200 [thread overview]
Message-ID: <aMA4_2-dhnXzUt_j@strlen.de> (raw)
In-Reply-To: <5334812c-37cb-42fa-9d53-402cf3d63786@gmail.com>
Eric Woudstra <ericwouds@gmail.com> wrote:
> Ok. At the end of nft_do_chain_bridge() I've added (after removing
> skb->protocol munging):
>
> if (offset && ret == NF_ACCEPT)
> skb_reset_network_header(skb);
>
> To reset the network header, only when it had been changed.
>
> Do you want this helper to return the offset, so it can be used here?
Makes sense, yes.
> >> + skb_set_network_header(skb, offset);
> >
> > I assume thats because the network header still points to
> > the ethernet header at this stage?
>
> That is correct.
Can you add a comment to that effect? (I assume it points not
to ethernet header but to the header that follows, e.g. pppoe).
prev parent reply other threads:[~2025-09-09 14:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 15:12 [PATCH v14 nf-next 0/3] conntrack: bridge: add double vlan, pppoe and pppoe-in-q Eric Woudstra
2025-07-08 15:12 ` [PATCH v14 nf-next 1/3] netfilter: utils: nf_checksum(_partial) correct data!=networkheader Eric Woudstra
2025-09-06 21:09 ` Florian Westphal
2025-07-08 15:12 ` [PATCH v14 nf-next 2/3] netfilter: bridge: Add conntrack double vlan and pppoe Eric Woudstra
2025-07-08 22:00 ` Florian Westphal
2025-09-06 21:11 ` Florian Westphal
2025-09-09 9:17 ` Eric Woudstra
2025-07-08 15:12 ` [PATCH v14 nf-next 3/3] netfilter: nft_chain_filter: Add bridge " Eric Woudstra
2025-07-08 22:02 ` Florian Westphal
2025-07-11 12:55 ` Eric Woudstra
2025-07-11 14:14 ` Florian Westphal
2025-07-12 10:08 ` Eric Woudstra
2025-07-12 10:50 ` Florian Westphal
2025-09-02 8:48 ` Eric Woudstra
2025-09-02 13:18 ` Florian Westphal
2025-09-06 12:26 ` Eric Woudstra
2025-09-06 21:14 ` Florian Westphal
2025-09-09 9:21 ` Eric Woudstra
2025-09-09 14:26 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMA4_2-dhnXzUt_j@strlen.de \
--to=fw@strlen.de \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.