From: Petr Mladek <pmladek@suse.com>
To: Jinchao Wang <wangjinchao600@gmail.com>
Cc: "Sravan Kumar Gundu" <sravankumarlpu@gmail.com>,
linux-fbdev@vger.kernel.org, "Kees Cook" <kees@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
"Yunhui Cui" <cuiyunhui@bytedance.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
"Zsolt Kajtar" <soci@c64.rulez.org>,
linux-hardening@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Max Kellermann" <max.kellermann@ionos.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Baoquan He" <bhe@redhat.com>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Helge Deller" <deller@gmx.de>,
"Joel Granados" <joel.granados@kernel.org>,
"Thorsten Blum" <thorsten.blum@linux.dev>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Dave Young" <dyoung@redhat.com>,
"Vivek Goyal" <vgoyal@redhat.com>,
"Nam Cao" <namcao@linutronix.de>,
"Qianqiang Liu" <qianqiang.liu@163.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
dri-devel@lists.freedesktop.org,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Sohil Mehta" <sohil.mehta@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Luo Gengkun" <luogengkun@huaweicloud.com>,
"Feng Tang" <feng.tang@linux.alibaba.com>,
"Shixiong Ou" <oushixiong@kylinos.cn>,
"Anna Schumaker" <anna.schumaker@oracle.com>,
"Tony Luck" <tony.luck@intel.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
kexec@lists.infradead.org,
"Douglas Anderson" <dianders@chromium.org>,
"Li Huafei" <lihuafei1@huawei.com>,
linux-kernel@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Tejun Heo" <tj@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 6/9] printk/nbcon: use panic_on_this_cpu() helper
Date: Tue, 16 Sep 2025 13:21:30 +0200 [thread overview]
Message-ID: <aMlIOt52xnLIvOpK@pathway.suse.cz> (raw)
In-Reply-To: <20250825022947.1596226-7-wangjinchao600@gmail.com>
On Mon 2025-08-25 10:29:34, Jinchao Wang wrote:
> nbcon_context_try_acquire() compared panic_cpu directly with
> smp_processor_id(). This open-coded check is now provided by
> panic_on_this_cpu().
>
> Switch to panic_on_this_cpu() to simplify the code and improve readability.
>
> Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
It looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: Jinchao Wang <wangjinchao600@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Baoquan He" <bhe@redhat.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Qianqiang Liu" <qianqiang.liu@163.com>,
"Simona Vetter" <simona@ffwll.ch>, "Helge Deller" <deller@gmx.de>,
"Steven Rostedt" <rostedt@goodmis.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Vivek Goyal" <vgoyal@redhat.com>,
"Dave Young" <dyoung@redhat.com>, "Kees Cook" <kees@kernel.org>,
"Tony Luck" <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Shixiong Ou" <oushixiong@kylinos.cn>,
"Zsolt Kajtar" <soci@c64.rulez.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Nam Cao" <namcao@linutronix.de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Joel Granados" <joel.granados@kernel.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Sohil Mehta" <sohil.mehta@intel.com>,
"Feng Tang" <feng.tang@linux.alibaba.com>,
"Sravan Kumar Gundu" <sravankumarlpu@gmail.com>,
"Douglas Anderson" <dianders@chromium.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Anna Schumaker" <anna.schumaker@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
"Max Kellermann" <max.kellermann@ionos.com>,
"Yunhui Cui" <cuiyunhui@bytedance.com>,
"Tejun Heo" <tj@kernel.org>,
"Luo Gengkun" <luogengkun@huaweicloud.com>,
"Li Huafei" <lihuafei1@huawei.com>,
"Thorsten Blum" <thorsten.blum@linux.dev>,
"Yicong Yang" <yangyicong@hisilicon.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
kexec@lists.infradead.org, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/9] printk/nbcon: use panic_on_this_cpu() helper
Date: Tue, 16 Sep 2025 13:21:30 +0200 [thread overview]
Message-ID: <aMlIOt52xnLIvOpK@pathway.suse.cz> (raw)
In-Reply-To: <20250825022947.1596226-7-wangjinchao600@gmail.com>
On Mon 2025-08-25 10:29:34, Jinchao Wang wrote:
> nbcon_context_try_acquire() compared panic_cpu directly with
> smp_processor_id(). This open-coded check is now provided by
> panic_on_this_cpu().
>
> Switch to panic_on_this_cpu() to simplify the code and improve readability.
>
> Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
It looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2025-09-16 20:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 2:29 [PATCH v2 0/9] panic: introduce panic status function family Jinchao Wang
2025-08-25 2:29 ` [PATCH v2 1/9] panic: Introduce helper functions for panic state Jinchao Wang
2025-09-16 9:57 ` Petr Mladek
2025-09-16 9:57 ` Petr Mladek
2025-09-17 2:09 ` Jinchao Wang
2025-09-17 2:09 ` Jinchao Wang
2025-08-25 2:29 ` [PATCH v2 2/9] fbdev: Use panic_in_progress() helper Jinchao Wang
2025-08-25 2:29 ` [PATCH v2 3/9] crash_core: use panic_try_start() in crash_kexec() Jinchao Wang
2025-08-29 2:30 ` Qianqiang Liu
2025-08-29 2:30 ` Qianqiang Liu
2025-08-29 4:39 ` Jinchao Wang
2025-08-29 4:39 ` Jinchao Wang
2025-08-25 2:29 ` [PATCH v2 4/9] panic: use panic_try_start() in nmi_panic() Jinchao Wang
2025-08-25 2:29 ` [PATCH v2 5/9] panic: use panic_try_start() in vpanic() Jinchao Wang
2025-09-16 11:20 ` Petr Mladek
2025-09-16 11:20 ` Petr Mladek
2025-08-25 2:29 ` [PATCH v2 6/9] printk/nbcon: use panic_on_this_cpu() helper Jinchao Wang
2025-09-16 11:21 ` Petr Mladek [this message]
2025-09-16 11:21 ` Petr Mladek
2025-08-25 2:29 ` [PATCH v2 7/9] panic/printk: replace this_cpu_in_panic() with panic_on_this_cpu() Jinchao Wang
2025-09-16 11:22 ` Petr Mladek
2025-09-16 11:22 ` Petr Mladek
2025-08-25 2:29 ` [PATCH v2 8/9] panic/printk: replace other_cpu_in_panic() with panic_on_other_cpu() Jinchao Wang
2025-09-16 11:23 ` Petr Mladek
2025-09-16 11:23 ` Petr Mladek
2025-08-25 2:29 ` [PATCH v2 9/9] watchdog: skip checks when panic is in progress Jinchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMlIOt52xnLIvOpK@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@oracle.com \
--cc=bhe@redhat.com \
--cc=cuiyunhui@bytedance.com \
--cc=deller@gmx.de \
--cc=dianders@chromium.org \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dyoung@redhat.com \
--cc=feng.tang@linux.alibaba.com \
--cc=jgg@ziepe.ca \
--cc=joel.granados@kernel.org \
--cc=joelagnelf@nvidia.com \
--cc=john.ogness@linutronix.de \
--cc=kees@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=lihuafei1@huawei.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luogengkun@huaweicloud.com \
--cc=max.kellermann@ionos.com \
--cc=mingo@kernel.org \
--cc=namcao@linutronix.de \
--cc=oushixiong@kylinos.cn \
--cc=qianqiang.liu@163.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=simona@ffwll.ch \
--cc=soci@c64.rulez.org \
--cc=sohil.mehta@intel.com \
--cc=sravankumarlpu@gmail.com \
--cc=tglx@linutronix.de \
--cc=thorsten.blum@linux.dev \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=tzimmermann@suse.de \
--cc=vgoyal@redhat.com \
--cc=ville.syrjala@linux.intel.com \
--cc=wangjinchao600@gmail.com \
--cc=yangyicong@hisilicon.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.