From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, oe-lkp@lists.linux.dev,
oliver.sang@intel.com, linux-fsdevel@vger.kernel.org,
josef@toxicpanda.com, ltp@lists.linux.it
Subject: Re: [f2fs-dev] [PATCH] f2fs: don't call iput() from f2fs_drop_inode()
Date: Wed, 1 Oct 2025 15:39:31 +0000 [thread overview]
Message-ID: <aN1LM3C3Dc1TrQTq@google.com> (raw)
In-Reply-To: <20250930232957.14361-1-mjguzik@gmail.com>
On 10/01, Mateusz Guzik wrote:
> iput() calls the problematic routine, which does a ->i_count inc/dec
> cycle. Undoing it with iput() recurses into the problem.
>
> Note f2fs should not be playing games with the refcount to begin with,
> but that will be handled later. Right now solve the immediate
> regression.
>
> Fixes: bc986b1d756482a ("fs: stop accessing ->i_count directly in f2fs and gfs2")
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202509301450.138b448f-lkp@intel.com
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
> ---
> fs/f2fs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2619cbbd7d2d..26ec31eb8c80 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1769,7 +1769,7 @@ static int f2fs_drop_inode(struct inode *inode)
> sb_end_intwrite(inode->i_sb);
>
> spin_lock(&inode->i_lock);
> - iput(inode);
> + atomic_dec(&inode->i_count);
It seems this was applied by Josef [1], added in 6.18-rc1. Let me apply this fix
after my f2fs pull request, since I don't have this issue in my -next tree yet.
[1] https://lore.kernel.org/all/b8e6eb8a3e690ce082828d3580415bf70dfa93aa.1755806649.git.josef@toxicpanda.com/
> }
> trace_f2fs_drop_inode(inode, 0);
> return 0;
> --
> 2.43.0
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim via ltp <ltp@lists.linux.it>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, oe-lkp@lists.linux.dev,
oliver.sang@intel.com, linux-fsdevel@vger.kernel.org,
josef@toxicpanda.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] f2fs: don't call iput() from f2fs_drop_inode()
Date: Wed, 1 Oct 2025 15:39:31 +0000 [thread overview]
Message-ID: <aN1LM3C3Dc1TrQTq@google.com> (raw)
In-Reply-To: <20250930232957.14361-1-mjguzik@gmail.com>
On 10/01, Mateusz Guzik wrote:
> iput() calls the problematic routine, which does a ->i_count inc/dec
> cycle. Undoing it with iput() recurses into the problem.
>
> Note f2fs should not be playing games with the refcount to begin with,
> but that will be handled later. Right now solve the immediate
> regression.
>
> Fixes: bc986b1d756482a ("fs: stop accessing ->i_count directly in f2fs and gfs2")
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202509301450.138b448f-lkp@intel.com
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
> ---
> fs/f2fs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2619cbbd7d2d..26ec31eb8c80 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1769,7 +1769,7 @@ static int f2fs_drop_inode(struct inode *inode)
> sb_end_intwrite(inode->i_sb);
>
> spin_lock(&inode->i_lock);
> - iput(inode);
> + atomic_dec(&inode->i_count);
It seems this was applied by Josef [1], added in 6.18-rc1. Let me apply this fix
after my f2fs pull request, since I don't have this issue in my -next tree yet.
[1] https://lore.kernel.org/all/b8e6eb8a3e690ce082828d3580415bf70dfa93aa.1755806649.git.josef@toxicpanda.com/
> }
> trace_f2fs_drop_inode(inode, 0);
> return 0;
> --
> 2.43.0
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, josef@toxicpanda.com,
oe-lkp@lists.linux.dev, linux-f2fs-devel@lists.sourceforge.net,
ltp@lists.linux.it, oliver.sang@intel.com
Subject: Re: [PATCH] f2fs: don't call iput() from f2fs_drop_inode()
Date: Wed, 1 Oct 2025 15:39:31 +0000 [thread overview]
Message-ID: <aN1LM3C3Dc1TrQTq@google.com> (raw)
In-Reply-To: <20250930232957.14361-1-mjguzik@gmail.com>
On 10/01, Mateusz Guzik wrote:
> iput() calls the problematic routine, which does a ->i_count inc/dec
> cycle. Undoing it with iput() recurses into the problem.
>
> Note f2fs should not be playing games with the refcount to begin with,
> but that will be handled later. Right now solve the immediate
> regression.
>
> Fixes: bc986b1d756482a ("fs: stop accessing ->i_count directly in f2fs and gfs2")
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202509301450.138b448f-lkp@intel.com
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
> ---
> fs/f2fs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2619cbbd7d2d..26ec31eb8c80 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1769,7 +1769,7 @@ static int f2fs_drop_inode(struct inode *inode)
> sb_end_intwrite(inode->i_sb);
>
> spin_lock(&inode->i_lock);
> - iput(inode);
> + atomic_dec(&inode->i_count);
It seems this was applied by Josef [1], added in 6.18-rc1. Let me apply this fix
after my f2fs pull request, since I don't have this issue in my -next tree yet.
[1] https://lore.kernel.org/all/b8e6eb8a3e690ce082828d3580415bf70dfa93aa.1755806649.git.josef@toxicpanda.com/
> }
> trace_f2fs_drop_inode(inode, 0);
> return 0;
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-10-01 15:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 6:41 [linus:master] [fs] bc986b1d75: Kernel_panic-not_syncing:softlockup:hung_tasks kernel test robot
2025-09-30 6:41 ` [LTP] " kernel test robot
2025-09-30 6:41 ` [f2fs-dev] " kernel test robot
2025-09-30 23:29 ` [f2fs-dev] [PATCH] f2fs: don't call iput() from f2fs_drop_inode() Mateusz Guzik
2025-09-30 23:29 ` Mateusz Guzik
2025-09-30 23:29 ` [LTP] " Mateusz Guzik
2025-10-01 15:39 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-10-01 15:39 ` Jaegeuk Kim
2025-10-01 15:39 ` [LTP] " Jaegeuk Kim via ltp
2025-10-06 18:00 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-10-06 18:00 ` patchwork-bot+f2fs
2025-10-06 18:00 ` [LTP] " patchwork-bot+f2fs--- via ltp
2025-10-09 3:34 ` Chao Yu via Linux-f2fs-devel
2025-10-09 3:34 ` Chao Yu
2025-10-09 3:34 ` [LTP] " Chao Yu via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN1LM3C3Dc1TrQTq@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=brauner@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=mjguzik@gmail.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.