From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: andrew+netdev@lunn.ch, przemyslaw.kitszel@intel.com,
aleksander.lobakin@intel.com, edumazet@google.com,
anthony.l.nguyen@intel.com, alan.brady@intel.com,
netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net] idpf: fix mismatched free function for dma_alloc_coherent
Date: Fri, 26 Sep 2025 15:03:03 +0100 [thread overview]
Message-ID: <aNadF8lvpXa5beZJ@horms.kernel.org> (raw)
In-Reply-To: <20250925180212.415093-1-alok.a.tiwari@oracle.com>
On Thu, Sep 25, 2025 at 11:02:10AM -0700, Alok Tiwari wrote:
> The mailbox receive path allocates coherent DMA memory with
> dma_alloc_coherent(), but frees it with dmam_free_coherent().
> This is incorrect since dmam_free_coherent() is only valid for
> buffers allocated with dmam_alloc_coherent().
>
> Fix the mismatch by using dma_free_coherent() instead of
> dmam_free_coherent
>
> Fixes: e54232da1238 ("idpf: refactor idpf_recv_mb_msg")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: krishneil.k.singh@intel.com, alan.brady@intel.com,
aleksander.lobakin@intel.com, andrew+netdev@lunn.ch,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net] idpf: fix mismatched free function for dma_alloc_coherent
Date: Fri, 26 Sep 2025 15:03:03 +0100 [thread overview]
Message-ID: <aNadF8lvpXa5beZJ@horms.kernel.org> (raw)
In-Reply-To: <20250925180212.415093-1-alok.a.tiwari@oracle.com>
On Thu, Sep 25, 2025 at 11:02:10AM -0700, Alok Tiwari wrote:
> The mailbox receive path allocates coherent DMA memory with
> dma_alloc_coherent(), but frees it with dmam_free_coherent().
> This is incorrect since dmam_free_coherent() is only valid for
> buffers allocated with dmam_alloc_coherent().
>
> Fix the mismatch by using dma_free_coherent() instead of
> dmam_free_coherent
>
> Fixes: e54232da1238 ("idpf: refactor idpf_recv_mb_msg")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-26 14:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 18:02 [Intel-wired-lan] [PATCH net] idpf: fix mismatched free function for dma_alloc_coherent Alok Tiwari
2025-09-25 18:02 ` Alok Tiwari
2025-09-26 14:03 ` Simon Horman [this message]
2025-09-26 14:03 ` Simon Horman
2025-09-29 6:28 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-29 6:28 ` Loktionov, Aleksandr
2025-09-29 22:53 ` Jacob Keller
2025-09-29 23:07 ` Chittim, Madhu
2025-09-30 1:20 ` patchwork-bot+netdevbpf
2025-09-30 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNadF8lvpXa5beZJ@horms.kernel.org \
--to=horms@kernel.org \
--cc=alan.brady@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.