* [f2fs-dev] [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa
@ 2025-09-24 18:54 ` Daeho Jeong
0 siblings, 0 replies; 6+ messages in thread
From: Daeho Jeong @ 2025-09-24 18:54 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong
From: Daeho Jeong <daehojeong@google.com>
total_valid_blks_available is already a multiple of c.blks_per_seg.
So, we don't need an additional alignment adjustment.
Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
mkfs/f2fs_format.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index b98976c..55a7505 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs/f2fs_format.c
@@ -500,8 +500,7 @@ static int f2fs_prepare_super_block(void)
if (c.feature & F2FS_FEATURE_RO)
blocks_for_ssa = 0;
else
- blocks_for_ssa = total_valid_blks_available /
- c.blks_per_seg + 1;
+ blocks_for_ssa = total_valid_blks_available / c.blks_per_seg;
set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa));
--
2.51.0.536.g15c5d4f767-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa
@ 2025-09-24 18:54 ` Daeho Jeong
0 siblings, 0 replies; 6+ messages in thread
From: Daeho Jeong @ 2025-09-24 18:54 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong
From: Daeho Jeong <daehojeong@google.com>
total_valid_blks_available is already a multiple of c.blks_per_seg.
So, we don't need an additional alignment adjustment.
Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
mkfs/f2fs_format.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index b98976c..55a7505 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs/f2fs_format.c
@@ -500,8 +500,7 @@ static int f2fs_prepare_super_block(void)
if (c.feature & F2FS_FEATURE_RO)
blocks_for_ssa = 0;
else
- blocks_for_ssa = total_valid_blks_available /
- c.blks_per_seg + 1;
+ blocks_for_ssa = total_valid_blks_available / c.blks_per_seg;
set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa));
--
2.51.0.536.g15c5d4f767-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa
2025-09-24 18:54 ` Daeho Jeong
@ 2025-09-25 9:24 ` Chao Yu
-1 siblings, 0 replies; 6+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2025-09-25 9:24 UTC (permalink / raw)
To: Daeho Jeong, linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong
On 9/25/2025 2:54 AM, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> total_valid_blks_available is already a multiple of c.blks_per_seg.
> So, we don't need an additional alignment adjustment.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa
2025-09-24 18:54 ` Daeho Jeong
@ 2025-09-28 19:58 ` Jaegeuk Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Jaegeuk Kim via Linux-f2fs-devel @ 2025-09-28 19:58 UTC (permalink / raw)
To: Daeho Jeong; +Cc: Daeho Jeong, kernel-team, linux-kernel, linux-f2fs-devel
On 09/24, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> total_valid_blks_available is already a multiple of c.blks_per_seg.
> So, we don't need an additional alignment adjustment.
Can we add ASSERT?
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> mkfs/f2fs_format.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> index b98976c..55a7505 100644
> --- a/mkfs/f2fs_format.c
> +++ b/mkfs/f2fs_format.c
> @@ -500,8 +500,7 @@ static int f2fs_prepare_super_block(void)
> if (c.feature & F2FS_FEATURE_RO)
> blocks_for_ssa = 0;
> else
> - blocks_for_ssa = total_valid_blks_available /
> - c.blks_per_seg + 1;
> + blocks_for_ssa = total_valid_blks_available / c.blks_per_seg;
>
> set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa));
>
> --
> 2.51.0.536.g15c5d4f767-goog
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa
@ 2025-09-28 19:58 ` Jaegeuk Kim
0 siblings, 0 replies; 6+ messages in thread
From: Jaegeuk Kim @ 2025-09-28 19:58 UTC (permalink / raw)
To: Daeho Jeong; +Cc: linux-kernel, linux-f2fs-devel, kernel-team, Daeho Jeong
On 09/24, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> total_valid_blks_available is already a multiple of c.blks_per_seg.
> So, we don't need an additional alignment adjustment.
Can we add ASSERT?
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> mkfs/f2fs_format.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> index b98976c..55a7505 100644
> --- a/mkfs/f2fs_format.c
> +++ b/mkfs/f2fs_format.c
> @@ -500,8 +500,7 @@ static int f2fs_prepare_super_block(void)
> if (c.feature & F2FS_FEATURE_RO)
> blocks_for_ssa = 0;
> else
> - blocks_for_ssa = total_valid_blks_available /
> - c.blks_per_seg + 1;
> + blocks_for_ssa = total_valid_blks_available / c.blks_per_seg;
>
> set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa));
>
> --
> 2.51.0.536.g15c5d4f767-goog
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-28 19:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-24 18:54 [f2fs-dev] [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa Daeho Jeong
2025-09-24 18:54 ` Daeho Jeong
2025-09-25 9:24 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-09-25 9:24 ` Chao Yu
2025-09-28 19:58 ` Jaegeuk Kim via Linux-f2fs-devel
2025-09-28 19:58 ` Jaegeuk Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.