* [Intel-wired-lan] [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open()
@ 2025-12-02 23:12 ` Sreedevi Joshi
0 siblings, 0 replies; 6+ messages in thread
From: Sreedevi Joshi @ 2025-12-02 23:12 UTC (permalink / raw)
To: intel-wired-lan
Cc: netdev, Sreedevi Joshi, Madhu Chittim, Aleksandr Loktionov
Fix error handling to properly cleanup interrupts when
idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to
'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned up
before releasing other resources.
Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
drivers/net/ethernet/intel/idpf/idpf_lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c
index 89f3b46378c4..a5051a96f2ad 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_lib.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c
@@ -1516,14 +1516,14 @@ static int idpf_vport_open(struct idpf_vport *vport, bool rtnl)
if (err) {
dev_err(&adapter->pdev->dev, "Failed to initialize queue registers for vport %u: %d\n",
vport->vport_id, err);
- goto queues_rel;
+ goto intr_deinit;
}
err = idpf_rx_bufs_init_all(vport);
if (err) {
dev_err(&adapter->pdev->dev, "Failed to initialize RX buffers for vport %u: %d\n",
vport->vport_id, err);
- goto queues_rel;
+ goto intr_deinit;
}
idpf_rx_init_buf_tail(vport);
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open()
@ 2025-12-02 23:12 ` Sreedevi Joshi
0 siblings, 0 replies; 6+ messages in thread
From: Sreedevi Joshi @ 2025-12-02 23:12 UTC (permalink / raw)
To: intel-wired-lan
Cc: netdev, Sreedevi Joshi, Madhu Chittim, Aleksandr Loktionov
Fix error handling to properly cleanup interrupts when
idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to
'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned up
before releasing other resources.
Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
drivers/net/ethernet/intel/idpf/idpf_lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c
index 89f3b46378c4..a5051a96f2ad 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_lib.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c
@@ -1516,14 +1516,14 @@ static int idpf_vport_open(struct idpf_vport *vport, bool rtnl)
if (err) {
dev_err(&adapter->pdev->dev, "Failed to initialize queue registers for vport %u: %d\n",
vport->vport_id, err);
- goto queues_rel;
+ goto intr_deinit;
}
err = idpf_rx_bufs_init_all(vport);
if (err) {
dev_err(&adapter->pdev->dev, "Failed to initialize RX buffers for vport %u: %d\n",
vport->vport_id, err);
- goto queues_rel;
+ goto intr_deinit;
}
idpf_rx_init_buf_tail(vport);
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open()
2025-12-02 23:12 ` Sreedevi Joshi
@ 2025-12-03 19:20 ` Simon Horman
-1 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2025-12-03 19:20 UTC (permalink / raw)
To: Sreedevi Joshi
Cc: intel-wired-lan, netdev, Madhu Chittim, Aleksandr Loktionov
On Tue, Dec 02, 2025 at 05:12:46PM -0600, Sreedevi Joshi wrote:
> Fix error handling to properly cleanup interrupts when
> idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to
> 'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned up
> before releasing other resources.
>
> Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
> Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open()
@ 2025-12-03 19:20 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2025-12-03 19:20 UTC (permalink / raw)
To: Sreedevi Joshi
Cc: intel-wired-lan, netdev, Madhu Chittim, Aleksandr Loktionov
On Tue, Dec 02, 2025 at 05:12:46PM -0600, Sreedevi Joshi wrote:
> Fix error handling to properly cleanup interrupts when
> idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to
> 'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned up
> before releasing other resources.
>
> Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
> Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open()
2025-12-03 19:20 ` Simon Horman
@ 2025-12-12 22:37 ` Salin, Samuel
-1 siblings, 0 replies; 6+ messages in thread
From: Salin, Samuel @ 2025-12-12 22:37 UTC (permalink / raw)
To: Simon Horman, Joshi, Sreedevi
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Chittim, Madhu, Loktionov, Aleksandr
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Simon Horman
> Sent: Wednesday, December 3, 2025 11:21 AM
> To: Joshi, Sreedevi <sreedevi.joshi@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Chittim, Madhu
> <madhu.chittim@intel.com>; Loktionov, Aleksandr
> <aleksandr.loktionov@intel.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix error handling in
> idpf_vport_open()
>
> On Tue, Dec 02, 2025 at 05:12:46PM -0600, Sreedevi Joshi wrote:
> > Fix error handling to properly cleanup interrupts when
> > idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to
> > 'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned
> > up before releasing other resources.
> >
> > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
> > Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
> > Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Samuel Salin <Samuel.salin@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open()
@ 2025-12-12 22:37 ` Salin, Samuel
0 siblings, 0 replies; 6+ messages in thread
From: Salin, Samuel @ 2025-12-12 22:37 UTC (permalink / raw)
To: Simon Horman, Joshi, Sreedevi
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Chittim, Madhu, Loktionov, Aleksandr
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Simon Horman
> Sent: Wednesday, December 3, 2025 11:21 AM
> To: Joshi, Sreedevi <sreedevi.joshi@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Chittim, Madhu
> <madhu.chittim@intel.com>; Loktionov, Aleksandr
> <aleksandr.loktionov@intel.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix error handling in
> idpf_vport_open()
>
> On Tue, Dec 02, 2025 at 05:12:46PM -0600, Sreedevi Joshi wrote:
> > Fix error handling to properly cleanup interrupts when
> > idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to
> > 'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned
> > up before releasing other resources.
> >
> > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
> > Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
> > Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Samuel Salin <Samuel.salin@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-12-12 22:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-02 23:12 [Intel-wired-lan] [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open() Sreedevi Joshi
2025-12-02 23:12 ` Sreedevi Joshi
2025-12-03 19:20 ` [Intel-wired-lan] " Simon Horman
2025-12-03 19:20 ` Simon Horman
2025-12-12 22:37 ` [Intel-wired-lan] " Salin, Samuel
2025-12-12 22:37 ` Salin, Samuel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.