All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Michael Walle <mwalle@kernel.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Steam Lin <STLin2@winbond.com>, Santhosh Kumar K <s-k6@ti.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH RFC 5/8] spi: spi-mem: Create a secondary read operation
Date: Thu, 11 Dec 2025 11:06:11 +0900	[thread overview]
Message-ID: <aTonE4REBDfaWBQo@sirena.co.uk> (raw)
In-Reply-To: <20251205-winbond-v6-18-rc1-cont-read-v1-5-01bc48631c73@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 558 bytes --]

On Fri, Dec 05, 2025 at 08:38:56PM +0100, Miquel Raynal wrote:

> The choice of defining two variables named primary and secondary instead
> of using an array of templates is on purpose, to simplify the reading. I
> find less obvious the use of an array here but this is personal taste.

This makes sense to me:

Acked-by: Mark Brown <broonie@kernel.org>

Feel free to carry both these patches along with the rest of the
series, if/when you do end up applying it a signed tag would probably be
a good idea in case there's some collision with other SPI work.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Michael Walle <mwalle@kernel.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Steam Lin <STLin2@winbond.com>, Santhosh Kumar K <s-k6@ti.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH RFC 5/8] spi: spi-mem: Create a secondary read operation
Date: Thu, 11 Dec 2025 11:06:11 +0900	[thread overview]
Message-ID: <aTonE4REBDfaWBQo@sirena.co.uk> (raw)
In-Reply-To: <20251205-winbond-v6-18-rc1-cont-read-v1-5-01bc48631c73@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Fri, Dec 05, 2025 at 08:38:56PM +0100, Miquel Raynal wrote:

> The choice of defining two variables named primary and secondary instead
> of using an array of templates is on purpose, to simplify the reading. I
> find less obvious the use of an array here but this is personal taste.

This makes sense to me:

Acked-by: Mark Brown <broonie@kernel.org>

Feel free to carry both these patches along with the rest of the
series, if/when you do end up applying it a signed tag would probably be
a good idea in case there's some collision with other SPI work.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-12-11  2:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 19:38 [PATCH RFC 0/8] mtd: spinand: Winbond continuous read support Miquel Raynal
2025-12-05 19:38 ` Miquel Raynal
2025-12-05 19:38 ` [PATCH RFC 1/8] mtd: spinand: Drop a too strong limitation Miquel Raynal
2025-12-05 19:38   ` Miquel Raynal
2025-12-05 19:38 ` [PATCH RFC 2/8] mtd: spinand: Expose spinand_op_is_odtr() Miquel Raynal
2025-12-05 19:38   ` Miquel Raynal
2025-12-05 19:38 ` [PATCH RFC 3/8] mtd: spinand: Drop ECC dirmaps Miquel Raynal
2025-12-05 19:38   ` Miquel Raynal
2025-12-05 19:38 ` [PATCH RFC 4/8] spi: spi-mem: Transform the read operation template Miquel Raynal
2025-12-05 19:38   ` Miquel Raynal
2025-12-11  2:03   ` Mark Brown
2025-12-11  2:03     ` Mark Brown
2025-12-05 19:38 ` [PATCH RFC 5/8] spi: spi-mem: Create a secondary read operation Miquel Raynal
2025-12-05 19:38   ` Miquel Raynal
2025-12-11  2:06   ` Mark Brown [this message]
2025-12-11  2:06     ` Mark Brown
2025-12-11 14:19     ` Miquel Raynal
2025-12-11 14:19       ` Miquel Raynal
2025-12-05 19:38 ` [PATCH RFC 6/8] mtd: spinand: Use secondary ops for continuous reads Miquel Raynal
2025-12-05 19:38   ` Miquel Raynal
2025-12-05 19:38 ` [PATCH RFC 7/8] mtd: spinand: winbond: Add support for continuous reads on W35NxxJW Miquel Raynal
2025-12-05 19:38   ` Miquel Raynal
2025-12-05 19:38 ` [PATCH RFC 8/8] mtd: spinand: winbond: Add support for continuous reads on W25NxxJW Miquel Raynal
2025-12-05 19:38   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTonE4REBDfaWBQo@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=STLin2@winbond.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=s-k6@ti.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.