Re: [PATCH 2/2] riscv: dts: spacemit: Add MMC support on BPI-F3 and OrangePi RV2

From: Yao Zi <me@ziyao.cc>
To: Michael Opdenacker <michael.opdenacker@rootcommit.com>,
	Yixun Lan <dlan@gentoo.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	Binbin Zhou <zhoubinbin@loongson.cn>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 2/2] riscv: dts: spacemit: Add MMC support on BPI-F3 and OrangePi RV2
Date: Mon, 15 Dec 2025 12:46:19 +0000	[thread overview]
Message-ID: <aUADG5c8r0GEN6iP@pie> (raw)
In-Reply-To: <20251215-k1-boards-add-mmc-v1-2-d68dc87d4aab@rootcommit.com>

On Mon, Dec 15, 2025 at 10:10:14AM +0000, Michael Opdenacker wrote:
> This introduces a new sdhci0 node and enables it
> for the BananaPI F3 and OrangePi RV2 boards.
> 
> Note that card detect is marked as broken in the driver
> (SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk), therefore removing the card
> while the system is running won't have any effect.

This description looks suspicious: SDHCI_QUIRK_BROKEN_CARD_DETECTION
doesn't break hotplug. It only informs sdhci core to actively poll for
card status, instead of relying on interrupts for status change.

...

> diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
> index 7818ca4979b6..a5b7d7c8c066 100644
> --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
> @@ -987,6 +987,16 @@ emmc: mmc@d4281000 {
>  				interrupts = <101>;
>  				status = "disabled";
>  			};
> +
> +			sdhci0: mmc@d4280000 {
> +				compatible = "spacemit,k1-sdhci";
> +				reg = <0x0 0xd4280000 0x0 0x200>;
> +				clocks = <&syscon_apmu CLK_SDH_AXI>,
> +					 <&syscon_apmu CLK_SDH0>;
> +				clock-names = "core", "io";
> +				interrupts = <99>;
> +				status = "disabled";
> +			};

This node should be probably put before the emmc node, since it comes
with lower address.

Regards,
Yao Zi

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv