Re: [PATCH 1/2] riscv: dts: spacemit: Add i2c buses on OrangePi RV2

From: Yao Zi <me@ziyao.cc>
To: Michael Opdenacker <michael.opdenacker@rootcommit.com>,
	Yixun Lan <dlan@gentoo.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	Binbin Zhou <zhoubinbin@loongson.cn>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 1/2] riscv: dts: spacemit: Add i2c buses on OrangePi RV2
Date: Mon, 15 Dec 2025 12:58:10 +0000	[thread overview]
Message-ID: <aUAF4iNjuP5AWJaf@pie> (raw)
In-Reply-To: <20251215-k1-boards-add-mmc-v1-1-d68dc87d4aab@rootcommit.com>

On Mon, Dec 15, 2025 at 10:10:14AM +0000, Michael Opdenacker wrote:
> The OrangePi RV2 board exposes i2c2 and i2c8 buses
> from the Spacemit K1 SoC.
> 
> This declares devices present on such buses, in particular
> the at24 eeprom to store MAC addresses and the regulators
> attached to the PMIC on i2c8.

This series is named as "Attempt to enable MMC on SpacemiT K1 boards",
what's the relationship between MMC and PMIC/I2C bus? You didn't make
use of any regulators in the second patch, either (which seems wrong to
me).

vmmc-supply specifies the card's power supply. And if you want to enable
SDR modes which mandate 1.8v IO level, vqmmc-supply is also necessary
for switching between 1.8v and 3.3v.

Regards,
Yao Zi

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv