From: Christoph Hellwig <hch@infradead.org>
To: Joanne Chang <joannechien@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net, Chao Yu <chao@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v1] generic/735: disable for f2fs
Date: Thu, 18 Dec 2025 21:30:12 -0800 [thread overview]
Message-ID: <aUTi5KPgn1fqezel@infradead.org> (raw)
In-Reply-To: <CACQK4XDtWzoco7WgmF81dEYpF1rP3s+3AjemPL40ysojMztOtQ@mail.gmail.com>
On Thu, Dec 18, 2025 at 08:02:48PM +0800, Joanne Chang wrote:
> Thank you for the feedback. I will implement a
> _require_blocks_in_file helper in the next version. As far as I
> know, there isn't a generic way to query the block number limit
> across filesystems, so I plan to hardcode the known limit for
> F2FS within the helper for now.
Oh, the limits is not the file size per se, so the number of blocks?
I.e. you can have a 64-bit i_size, but if the file isn't spare it
eventually can't fill holes? That really does seem like behavior
applications would not not expect, aka a bug.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Joanne Chang <joannechien@google.com>
Cc: Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [f2fs-dev] [PATCH v1] generic/735: disable for f2fs
Date: Thu, 18 Dec 2025 21:30:12 -0800 [thread overview]
Message-ID: <aUTi5KPgn1fqezel@infradead.org> (raw)
In-Reply-To: <CACQK4XDtWzoco7WgmF81dEYpF1rP3s+3AjemPL40ysojMztOtQ@mail.gmail.com>
On Thu, Dec 18, 2025 at 08:02:48PM +0800, Joanne Chang wrote:
> Thank you for the feedback. I will implement a
> _require_blocks_in_file helper in the next version. As far as I
> know, there isn't a generic way to query the block number limit
> across filesystems, so I plan to hardcode the known limit for
> F2FS within the helper for now.
Oh, the limits is not the file size per se, so the number of blocks?
I.e. you can have a 64-bit i_size, but if the file isn't spare it
eventually can't fill holes? That really does seem like behavior
applications would not not expect, aka a bug.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-12-19 5:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 7:17 [PATCH v1] generic/735: disable for f2fs Joanne Chang
2025-12-18 7:17 ` [f2fs-dev] " Joanne Chang via Linux-f2fs-devel
2025-12-18 7:33 ` Christoph Hellwig
2025-12-18 7:33 ` [f2fs-dev] " Christoph Hellwig
2025-12-18 12:02 ` Joanne Chang
2025-12-18 12:02 ` [f2fs-dev] " Joanne Chang via Linux-f2fs-devel
2025-12-19 5:30 ` Christoph Hellwig [this message]
2025-12-19 5:30 ` Christoph Hellwig
2025-12-19 8:53 ` Joanne Chang
2025-12-19 8:53 ` [f2fs-dev] " Joanne Chang via Linux-f2fs-devel
2025-12-19 11:10 ` Christoph Hellwig
2025-12-19 11:10 ` [f2fs-dev] " Christoph Hellwig
2025-12-22 2:48 ` Joanne Chang
2025-12-22 2:48 ` [f2fs-dev] " Joanne Chang via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUTi5KPgn1fqezel@infradead.org \
--to=hch@infradead.org \
--cc=chao@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=joannechien@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.