checkpatch.pl warning on "added, moved or deleted" messed up

checkpatch.pl warning on "added, moved or deleted" messed up

[Markus Armbruster]

I ran checkpatch on my

    [PATCH 0/2] migration: Drop deprecated QMP stuff
    Message-ID: <20260108125512.2234147-1-armbru@redhat.com>

and got

    $ scripts/checkpatch.pl --terse *patch
    0001-migration-Drop-deprecated-QMP-command-query-migratio.patch:290: WARNING: added, moved or deleted file(s):
    total: 0 errors, 1 warnings, 129 lines checked

The culprit seems to be commit 1d745e6d963 (scripts/checkpatch: use new
hook for MAINTAINERS update check).  If I use the version immediately
preceding it, I get:

    0001-migration-Drop-deprecated-QMP-command-query-migratio.patch:105: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
    total: 0 errors, 1 warnings, 129 lines checked

Re: checkpatch.pl warning on "added, moved or deleted" messed up

[Daniel P. Berrangé]

On Thu, Jan 08, 2026 at 01:57:56PM +0100, Markus Armbruster wrote:
> I ran checkpatch on my
> 
>     [PATCH 0/2] migration: Drop deprecated QMP stuff
>     Message-ID: <20260108125512.2234147-1-armbru@redhat.com>
> 
> and got
> 
>     $ scripts/checkpatch.pl --terse *patch
>     0001-migration-Drop-deprecated-QMP-command-query-migratio.patch:290: WARNING: added, moved or deleted file(s):
>     total: 0 errors, 1 warnings, 129 lines checked
> 
> The culprit seems to be commit 1d745e6d963 (scripts/checkpatch: use new
> hook for MAINTAINERS update check).  If I use the version immediately
> preceding it, I get:
> 
>     0001-migration-Drop-deprecated-QMP-command-query-migratio.patch:105: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>     total: 0 errors, 1 warnings, 129 lines checked

Hmm, the problem is the --terse command is rather crude and simply
throws away everything except the first line of text. My commit made
the verbose output multi-line to improve readability

$ ./scripts/checkpatch.pl  ~/dep
WARNING: added, moved or deleted file(s):

  migration/threadinfo.h
  migration/threadinfo.c

Does MAINTAINERS need updating?

total: 0 errors, 1 warnings, 193 lines checked

/var/home/berrange/dep has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.


but this inadvertantly made terse output worse :-(

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: checkpatch.pl warning on "added, moved or deleted" messed up

[Markus Armbruster]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Thu, Jan 08, 2026 at 01:57:56PM +0100, Markus Armbruster wrote:
>> I ran checkpatch on my
>> 
>>     [PATCH 0/2] migration: Drop deprecated QMP stuff
>>     Message-ID: <20260108125512.2234147-1-armbru@redhat.com>
>> 
>> and got
>> 
>>     $ scripts/checkpatch.pl --terse *patch
>>     0001-migration-Drop-deprecated-QMP-command-query-migratio.patch:290: WARNING: added, moved or deleted file(s):
>>     total: 0 errors, 1 warnings, 129 lines checked
>> 
>> The culprit seems to be commit 1d745e6d963 (scripts/checkpatch: use new
>> hook for MAINTAINERS update check).  If I use the version immediately
>> preceding it, I get:
>> 
>>     0001-migration-Drop-deprecated-QMP-command-query-migratio.patch:105: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>>     total: 0 errors, 1 warnings, 129 lines checked
>
> Hmm, the problem is the --terse command is rather crude and simply
> throws away everything except the first line of text. My commit made
> the verbose output multi-line to improve readability
>
> $ ./scripts/checkpatch.pl  ~/dep
> WARNING: added, moved or deleted file(s):
>
>   migration/threadinfo.h
>   migration/threadinfo.c
>
> Does MAINTAINERS need updating?
>
> total: 0 errors, 1 warnings, 193 lines checked
>
> /var/home/berrange/dep has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
>
> but this inadvertantly made terse output worse :-(

Aha!

I posted a patch, Message-ID: <20260109071217.2326194-1-armbru@redhat.com>

Thanks!