[PATCH] docs/devel: fix bash-ism warning for configure

[PATCH] docs/devel: fix bash-ism warning for configure

[Alex Bennée]

Hopefully this makes the meaning clearer.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 docs/devel/build-system.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
index b9797a374c7..35c77343914 100644
--- a/docs/devel/build-system.rst
+++ b/docs/devel/build-system.rst
@@ -66,7 +66,7 @@ Modifying ``configure``
 ``configure`` is a shell script; it uses ``#!/bin/sh`` and therefore
 should be compatible with any POSIX shell. It is important to avoid
 using bash-isms to avoid breaking development platforms where bash is
-the primary host.
+not the default shell implementation.
 
 The configure script provides a variety of functions to help writing
 portable shell code and providing consistent behavior across architectures
-- 
2.47.3

Re: [PATCH] docs/devel: fix bash-ism warning for configure

[Daniel P. Berrangé]

On Wed, Jan 14, 2026 at 10:15:25AM +0000, Alex Bennée wrote:
> Hopefully this makes the meaning clearer.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  docs/devel/build-system.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] docs/devel: fix bash-ism warning for configure

[Thomas Huth]

On 14/01/2026 11.15, Alex Bennée wrote:
> Hopefully this makes the meaning clearer.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   docs/devel/build-system.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
> index b9797a374c7..35c77343914 100644
> --- a/docs/devel/build-system.rst
> +++ b/docs/devel/build-system.rst
> @@ -66,7 +66,7 @@ Modifying ``configure``
>   ``configure`` is a shell script; it uses ``#!/bin/sh`` and therefore
>   should be compatible with any POSIX shell. It is important to avoid
>   using bash-isms to avoid breaking development platforms where bash is
> -the primary host.
> +not the default shell implementation.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] docs/devel: fix bash-ism warning for configure

[Alex Bennée]

Alex Bennée <alex.bennee@linaro.org> writes:

> Hopefully this makes the meaning clearer.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  docs/devel/build-system.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
> index b9797a374c7..35c77343914 100644
> --- a/docs/devel/build-system.rst
> +++ b/docs/devel/build-system.rst
> @@ -66,7 +66,7 @@ Modifying ``configure``
>  ``configure`` is a shell script; it uses ``#!/bin/sh`` and therefore
>  should be compatible with any POSIX shell. It is important to avoid
>  using bash-isms to avoid breaking development platforms where bash is
> -the primary host.
> +not the default shell implementation.
>  
>  The configure script provides a variety of functions to help writing
>  portable shell code and providing consistent behavior across architectures

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH] docs/devel: fix bash-ism warning for configure

[Pierrick Bouvier]

On 1/14/26 2:15 AM, Alex Bennée wrote:
> Hopefully this makes the meaning clearer.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   docs/devel/build-system.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

This was merged into master (216264cb519a6b8d8dc6962110c0035192e90d3e).
Thank you for your contribution!

Regards,
Pierrick