* [PATCH] docs/devel: fix bash-ism warning for configure
@ 2026-01-14 10:15 Alex Bennée
2026-01-14 10:21 ` Daniel P. Berrangé
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Alex Bennée @ 2026-01-14 10:15 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Daniel P. Berrangé
Hopefully this makes the meaning clearer.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
docs/devel/build-system.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
index b9797a374c7..35c77343914 100644
--- a/docs/devel/build-system.rst
+++ b/docs/devel/build-system.rst
@@ -66,7 +66,7 @@ Modifying ``configure``
``configure`` is a shell script; it uses ``#!/bin/sh`` and therefore
should be compatible with any POSIX shell. It is important to avoid
using bash-isms to avoid breaking development platforms where bash is
-the primary host.
+not the default shell implementation.
The configure script provides a variety of functions to help writing
portable shell code and providing consistent behavior across architectures
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] docs/devel: fix bash-ism warning for configure
2026-01-14 10:15 [PATCH] docs/devel: fix bash-ism warning for configure Alex Bennée
@ 2026-01-14 10:21 ` Daniel P. Berrangé
2026-02-06 11:33 ` Thomas Huth
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2026-01-14 10:21 UTC (permalink / raw)
To: Alex Bennée; +Cc: qemu-devel
On Wed, Jan 14, 2026 at 10:15:25AM +0000, Alex Bennée wrote:
> Hopefully this makes the meaning clearer.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> docs/devel/build-system.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] docs/devel: fix bash-ism warning for configure
2026-01-14 10:15 [PATCH] docs/devel: fix bash-ism warning for configure Alex Bennée
2026-01-14 10:21 ` Daniel P. Berrangé
@ 2026-02-06 11:33 ` Thomas Huth
2026-02-11 16:25 ` Alex Bennée
2026-02-12 16:27 ` Pierrick Bouvier
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2026-02-06 11:33 UTC (permalink / raw)
To: Alex Bennée, qemu-devel, Pierrick Bouvier; +Cc: Daniel P. Berrangé
On 14/01/2026 11.15, Alex Bennée wrote:
> Hopefully this makes the meaning clearer.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> docs/devel/build-system.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
> index b9797a374c7..35c77343914 100644
> --- a/docs/devel/build-system.rst
> +++ b/docs/devel/build-system.rst
> @@ -66,7 +66,7 @@ Modifying ``configure``
> ``configure`` is a shell script; it uses ``#!/bin/sh`` and therefore
> should be compatible with any POSIX shell. It is important to avoid
> using bash-isms to avoid breaking development platforms where bash is
> -the primary host.
> +not the default shell implementation.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] docs/devel: fix bash-ism warning for configure
2026-01-14 10:15 [PATCH] docs/devel: fix bash-ism warning for configure Alex Bennée
2026-01-14 10:21 ` Daniel P. Berrangé
2026-02-06 11:33 ` Thomas Huth
@ 2026-02-11 16:25 ` Alex Bennée
2026-02-12 16:27 ` Pierrick Bouvier
3 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2026-02-11 16:25 UTC (permalink / raw)
To: qemu-devel; +Cc: Daniel P. Berrangé, Pierrick Bouvier
Alex Bennée <alex.bennee@linaro.org> writes:
> Hopefully this makes the meaning clearer.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> docs/devel/build-system.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
> index b9797a374c7..35c77343914 100644
> --- a/docs/devel/build-system.rst
> +++ b/docs/devel/build-system.rst
> @@ -66,7 +66,7 @@ Modifying ``configure``
> ``configure`` is a shell script; it uses ``#!/bin/sh`` and therefore
> should be compatible with any POSIX shell. It is important to avoid
> using bash-isms to avoid breaking development platforms where bash is
> -the primary host.
> +not the default shell implementation.
>
> The configure script provides a variety of functions to help writing
> portable shell code and providing consistent behavior across architectures
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] docs/devel: fix bash-ism warning for configure
2026-01-14 10:15 [PATCH] docs/devel: fix bash-ism warning for configure Alex Bennée
` (2 preceding siblings ...)
2026-02-11 16:25 ` Alex Bennée
@ 2026-02-12 16:27 ` Pierrick Bouvier
3 siblings, 0 replies; 5+ messages in thread
From: Pierrick Bouvier @ 2026-02-12 16:27 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Daniel P. Berrangé
On 1/14/26 2:15 AM, Alex Bennée wrote:
> Hopefully this makes the meaning clearer.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> docs/devel/build-system.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
This was merged into master (216264cb519a6b8d8dc6962110c0035192e90d3e).
Thank you for your contribution!
Regards,
Pierrick
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-12 16:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-14 10:15 [PATCH] docs/devel: fix bash-ism warning for configure Alex Bennée
2026-01-14 10:21 ` Daniel P. Berrangé
2026-02-06 11:33 ` Thomas Huth
2026-02-11 16:25 ` Alex Bennée
2026-02-12 16:27 ` Pierrick Bouvier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.