* [PULL v2 00/41] QOM, target/i386 patches for 2026-02-12
@ 2026-02-13 10:21 Paolo Bonzini
2026-02-13 10:21 ` [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition Paolo Bonzini
2026-02-13 14:12 ` [PULL v2 00/41] QOM, target/i386 patches for 2026-02-12 Peter Maydell
0 siblings, 2 replies; 7+ messages in thread
From: Paolo Bonzini @ 2026-02-13 10:21 UTC (permalink / raw)
To: qemu-devel
The following changes since commit cd5a79dc98e3087e7658e643bdbbb0baec77ac8a:
Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2026-02-05 13:54:50 +0000)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to 7db36b822316a830ae803e903a12e920e3273b85:
target/i386/mshv: remove unused optimization of gva=>gpa translation (2026-02-13 11:16:52 +0100)
----------------------------------------------------------------
* hw/i386: Remove deprecated PC 2.6 and 2.7 machines
* i386/cpu: Fix incorrect initializer in Diamond Rapids definition
* qom: Clean up property release
* target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
* target/i386/kvm: reset AMD and perfmon-v2 PMU registers during VM reset
* mshv: Cleanup
* target/i386: convert SEV-ES termination requests to guest panic events
----------------------------------------------------------------
v1->v2: remove incorrect roms/seabios-hppa update
Aidan Khoury (1):
i386/cpu: Fix incorrect initializer in Diamond Rapids definition
Chandan Somani (1):
qdev: Free property array on release
Dongli Zhang (5):
target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
target/i386/kvm: extract unrelated code out of kvm_x86_build_cpuid()
target/i386/kvm: rename architectural PMU variables
target/i386/kvm: reset AMD PMU registers during VM reset
target/i386/kvm: support perfmon-v2 for reset
Igor Mammedov (1):
tests/acpi: Allow DSDT table change for x86 machines
Magnus Kulke (2):
accel/mshv: Remove remap overlapping mappings code
target/i386/mshv: remove unused optimization of gva=>gpa translation
Marc-André Lureau (4):
qdev: make release_string() idempotent
qdev: make release_drive() idempotent
qdev: make release_tpm() idempotent
tests: add /qdev/free-properties test
Paolo Bonzini (1):
target/i386: convert SEV-ES termination requests to guest panic events
Philippe Mathieu-Daudé (22):
hw/i386/pc: Remove deprecated pc-q35-2.6 and pc-i440fx-2.6 machines
hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field
hw/nvram/fw_cfg: Rename fw_cfg_init_mem() with '_nodma' suffix
hw/mips/loongson3_virt: Prefer using fw_cfg_init_mem_nodma()
hw/nvram/fw_cfg: Factor fw_cfg_init_mem_internal() out
hw/nvram/fw_cfg: Rename fw_cfg_init_mem_wide() -> fw_cfg_init_mem_dma()
hw/i386/x86: Remove X86MachineClass::fwcfg_dma_enabled field
hw/i386/pc: Remove multiboot.bin
hw/i386: Assume fw_cfg DMA is always enabled
hw/i386: Remove linuxboot.bin
hw/i386/pc: Remove pc_compat_2_6[] array
hw/intc/apic: Remove APICCommonState::legacy_instance_id field
hw/core/machine: Remove hw_compat_2_6[] array
hw/virtio/virtio-mmio: Remove VirtIOMMIOProxy::format_transport_address field
hw/i386/pc: Remove deprecated pc-q35-2.7 and pc-i440fx-2.7 machines
hw/i386/pc: Remove pc_compat_2_7[] array
target/i386/cpu: Remove CPUX86State::full_cpuid_auto_level field
hw/audio/pcspk: Remove PCSpkState::migrate field
hw/core/machine: Remove hw_compat_2_7[] array
hw/i386/intel_iommu: Remove IntelIOMMUState::buggy_eim field
hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features field
hw/char/virtio-serial: Do not expose the 'emergency-write' property
Zhao Liu (4):
pc: Start with modern CPU hotplug interface by default
acpi: Remove legacy cpu hotplug utilities
docs/specs/acpi_cpu_hotplug: Remove legacy cpu hotplug descriptions
tests/acpi: Update DSDT tables for pc & q35 machines
docs/specs/acpi_cpu_hotplug.rst | 28 +-
qapi/run-state.json | 23 +-
include/hw/acpi/cpu.h | 1 -
include/hw/acpi/ich9.h | 4 +-
include/hw/acpi/piix4.h | 4 +-
include/hw/core/boards.h | 6 -
include/hw/i386/apic_internal.h | 1 -
include/hw/i386/intel_iommu.h | 1 -
include/hw/i386/pc.h | 9 -
include/hw/i386/x86.h | 2 -
include/hw/nvram/fw_cfg.h | 9 +-
include/hw/virtio/virtio-mmio.h | 1 -
include/hw/virtio/virtio-pci.h | 1 -
include/hw/virtio/virtio-serial.h | 2 -
include/system/mshv_int.h | 22 +-
pc-bios/optionrom/optionrom.h | 4 -
target/i386/cpu.h | 19 +-
accel/kvm/kvm-all.c | 1 +
accel/mshv/mem.c | 406 ++--------------------
accel/mshv/mshv-all.c | 2 -
backends/tpm/tpm_util.c | 1 +
block/accounting.c | 1 -
hw/acpi/acpi-cpu-hotplug-stub.c | 19 +-
hw/acpi/cpu.c | 10 -
hw/acpi/cpu_hotplug.c | 348 -------------------
hw/acpi/generic_event_device.c | 1 +
hw/acpi/ich9.c | 61 +---
hw/acpi/piix4.c | 61 +---
hw/arm/virt.c | 2 +-
hw/audio/pcspk.c | 10 -
hw/char/virtio-serial-bus.c | 9 +-
hw/core/machine.c | 17 -
hw/core/qdev-properties-system.c | 1 +
hw/core/qdev-properties.c | 24 +-
hw/hppa/machine.c | 2 +-
hw/i386/acpi-build.c | 7 +-
hw/i386/fw_cfg.c | 16 +-
hw/i386/intel_iommu.c | 5 +-
hw/i386/microvm.c | 3 -
hw/i386/multiboot.c | 7 +-
hw/i386/pc.c | 25 +-
hw/i386/pc_piix.c | 23 --
hw/i386/pc_q35.c | 24 --
hw/i386/x86-common.c | 8 +-
hw/i386/x86.c | 2 -
hw/input/stellaris_gamepad.c | 8 -
hw/intc/apic_common.c | 5 -
hw/intc/arm_gicv3_common.c | 8 -
hw/intc/rx_icu.c | 8 -
hw/loongarch/fw_cfg.c | 4 +-
hw/loongarch/virt-acpi-build.c | 1 -
hw/mips/loongson3_virt.c | 2 +-
hw/misc/arm_sysctl.c | 2 -
hw/misc/mps2-scc.c | 8 -
hw/net/rocker/rocker.c | 1 -
hw/nvram/fw_cfg.c | 22 +-
hw/nvram/xlnx-efuse.c | 8 -
hw/nvram/xlnx-versal-efuse-ctrl.c | 8 -
hw/riscv/virt.c | 4 +-
hw/virtio/virtio-iommu-pci.c | 8 -
hw/virtio/virtio-mmio.c | 15 -
hw/virtio/virtio-pci.c | 5 +-
system/runstate.c | 4 +
target/i386/cpu-system.c | 22 ++
target/i386/cpu.c | 119 ++++---
target/i386/kvm/kvm.c | 314 ++++++++++++++---
target/i386/mshv/mshv-cpu.c | 63 +---
tests/qtest/test-x86-cpuid-compat.c | 11 -
tests/unit/test-qdev.c | 96 +++++
accel/mshv/trace-events | 5 -
hw/acpi/meson.build | 2 +-
pc-bios/meson.build | 2 -
pc-bios/multiboot.bin | Bin 1024 -> 0 bytes
pc-bios/optionrom/Makefile | 2 +-
pc-bios/optionrom/linuxboot.S | 195 -----------
pc-bios/optionrom/multiboot.S | 232 -------------
pc-bios/optionrom/multiboot_dma.S | 234 ++++++++++++-
tests/data/acpi/x86/pc/DSDT | Bin 8611 -> 8598 bytes
tests/data/acpi/x86/pc/DSDT.acpierst | Bin 8522 -> 8509 bytes
tests/data/acpi/x86/pc/DSDT.acpihmat | Bin 9936 -> 9923 bytes
tests/data/acpi/x86/pc/DSDT.bridge | Bin 15482 -> 15469 bytes
tests/data/acpi/x86/pc/DSDT.cphp | Bin 9075 -> 9062 bytes
tests/data/acpi/x86/pc/DSDT.dimmpxm | Bin 10265 -> 10252 bytes
tests/data/acpi/x86/pc/DSDT.hpbridge | Bin 8562 -> 8549 bytes
tests/data/acpi/x86/pc/DSDT.hpbrroot | Bin 5100 -> 5087 bytes
tests/data/acpi/x86/pc/DSDT.ipmikcs | Bin 8683 -> 8670 bytes
tests/data/acpi/x86/pc/DSDT.memhp | Bin 9970 -> 9957 bytes
tests/data/acpi/x86/pc/DSDT.nohpet | Bin 8469 -> 8456 bytes
tests/data/acpi/x86/pc/DSDT.numamem | Bin 8617 -> 8604 bytes
tests/data/acpi/x86/pc/DSDT.roothp | Bin 12404 -> 12391 bytes
tests/data/acpi/x86/q35/DSDT | Bin 8440 -> 8427 bytes
tests/data/acpi/x86/q35/DSDT.acpierst | Bin 8457 -> 8444 bytes
tests/data/acpi/x86/q35/DSDT.acpihmat | Bin 9765 -> 9752 bytes
tests/data/acpi/x86/q35/DSDT.acpihmat-generic-x | Bin 12650 -> 12637 bytes
tests/data/acpi/x86/q35/DSDT.acpihmat-noinitiator | Bin 8719 -> 8706 bytes
tests/data/acpi/x86/q35/DSDT.applesmc | Bin 8486 -> 8473 bytes
tests/data/acpi/x86/q35/DSDT.bridge | Bin 12053 -> 12040 bytes
tests/data/acpi/x86/q35/DSDT.core-count | Bin 12998 -> 12985 bytes
tests/data/acpi/x86/q35/DSDT.core-count2 | Bin 33855 -> 33842 bytes
tests/data/acpi/x86/q35/DSDT.cphp | Bin 8904 -> 8891 bytes
tests/data/acpi/x86/q35/DSDT.cxl | Bin 13231 -> 13218 bytes
tests/data/acpi/x86/q35/DSDT.dimmpxm | Bin 10094 -> 10081 bytes
tests/data/acpi/x86/q35/DSDT.ipmibt | Bin 8515 -> 8502 bytes
tests/data/acpi/x86/q35/DSDT.ipmismbus | Bin 8528 -> 8515 bytes
tests/data/acpi/x86/q35/DSDT.ivrs | Bin 8457 -> 8444 bytes
tests/data/acpi/x86/q35/DSDT.memhp | Bin 9799 -> 9786 bytes
tests/data/acpi/x86/q35/DSDT.mmio64 | Bin 9570 -> 9557 bytes
tests/data/acpi/x86/q35/DSDT.multi-bridge | Bin 13293 -> 13280 bytes
tests/data/acpi/x86/q35/DSDT.noacpihp | Bin 8302 -> 8289 bytes
tests/data/acpi/x86/q35/DSDT.nohpet | Bin 8298 -> 8285 bytes
tests/data/acpi/x86/q35/DSDT.numamem | Bin 8446 -> 8433 bytes
tests/data/acpi/x86/q35/DSDT.pvpanic-isa | Bin 8541 -> 8528 bytes
tests/data/acpi/x86/q35/DSDT.thread-count | Bin 12998 -> 12985 bytes
tests/data/acpi/x86/q35/DSDT.thread-count2 | Bin 33855 -> 33842 bytes
tests/data/acpi/x86/q35/DSDT.tis.tpm12 | Bin 9046 -> 9033 bytes
tests/data/acpi/x86/q35/DSDT.tis.tpm2 | Bin 9072 -> 9059 bytes
tests/data/acpi/x86/q35/DSDT.type4-count | Bin 18674 -> 18661 bytes
tests/data/acpi/x86/q35/DSDT.viot | Bin 14697 -> 14684 bytes
tests/data/acpi/x86/q35/DSDT.xapic | Bin 35803 -> 35790 bytes
tests/unit/meson.build | 1 +
120 files changed, 851 insertions(+), 1801 deletions(-)
delete mode 100644 hw/acpi/cpu_hotplug.c
create mode 100644 tests/unit/test-qdev.c
delete mode 100644 pc-bios/multiboot.bin
delete mode 100644 pc-bios/optionrom/linuxboot.S
delete mode 100644 pc-bios/optionrom/multiboot.S
--
2.52.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition
2026-02-13 10:21 [PULL v2 00/41] QOM, target/i386 patches for 2026-02-12 Paolo Bonzini
@ 2026-02-13 10:21 ` Paolo Bonzini
2026-02-13 11:08 ` Daniel P. Berrangé
2026-02-13 14:12 ` [PULL v2 00/41] QOM, target/i386 patches for 2026-02-12 Peter Maydell
1 sibling, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2026-02-13 10:21 UTC (permalink / raw)
To: qemu-devel; +Cc: Aidan Khoury
From: Aidan Khoury <aidan@aktech.ai>
The new Diamond Rapids x86 cpu model definition that was added in 7a6dd8bde1
has an unexpected comma in the `.features[FEAT_VMX_EXIT_CTLS]` subobject
initializer, causing the prior initialization to be overridden. For this
reason `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE`
is not included.
Fix this by replacing the comma with the missing bitwise OR to properly
combine all the flags into a single bitmask value.
Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids")
Signed-off-by: Aidan Khoury <aidan@aktech.ai>
---
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 201c5d5c210..eaa01438c1b 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -5579,7 +5579,7 @@ static const X86CPUDefinition builtin_x86_defs[] = {
MSR_VMX_EPT_INVVPID_ALL_CONTEXT |
MSR_VMX_EPT_INVVPID_SINGLE_CONTEXT_NOGLOBALS,
.features[FEAT_VMX_EXIT_CTLS] =
- VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE,
+ VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE |
VMX_VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL |
VMX_VM_EXIT_ACK_INTR_ON_EXIT | VMX_VM_EXIT_SAVE_IA32_PAT |
VMX_VM_EXIT_LOAD_IA32_PAT | VMX_VM_EXIT_SAVE_IA32_EFER |
--
2.52.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition
2026-02-13 10:21 ` [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition Paolo Bonzini
@ 2026-02-13 11:08 ` Daniel P. Berrangé
2026-02-13 11:48 ` Peter Maydell
0 siblings, 1 reply; 7+ messages in thread
From: Daniel P. Berrangé @ 2026-02-13 11:08 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Aidan Khoury
On Fri, Feb 13, 2026 at 11:21:09AM +0100, Paolo Bonzini wrote:
> From: Aidan Khoury <aidan@aktech.ai>
>
> The new Diamond Rapids x86 cpu model definition that was added in 7a6dd8bde1
> has an unexpected comma in the `.features[FEAT_VMX_EXIT_CTLS]` subobject
> initializer, causing the prior initialization to be overridden. For this
> reason `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE`
> is not included.
>
> Fix this by replacing the comma with the missing bitwise OR to properly
> combine all the flags into a single bitmask value.
>
> Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids")
> Signed-off-by: Aidan Khoury <aidan@aktech.ai>
That's missing your S-o-B
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 201c5d5c210..eaa01438c1b 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -5579,7 +5579,7 @@ static const X86CPUDefinition builtin_x86_defs[] = {
> MSR_VMX_EPT_INVVPID_ALL_CONTEXT |
> MSR_VMX_EPT_INVVPID_SINGLE_CONTEXT_NOGLOBALS,
> .features[FEAT_VMX_EXIT_CTLS] =
> - VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE,
> + VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE |
> VMX_VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL |
> VMX_VM_EXIT_ACK_INTR_ON_EXIT | VMX_VM_EXIT_SAVE_IA32_PAT |
> VMX_VM_EXIT_LOAD_IA32_PAT | VMX_VM_EXIT_SAVE_IA32_EFER |
> --
> 2.52.0
>
>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition
2026-02-13 11:08 ` Daniel P. Berrangé
@ 2026-02-13 11:48 ` Peter Maydell
2026-02-13 11:52 ` Daniel P. Berrangé
0 siblings, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2026-02-13 11:48 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: Paolo Bonzini, qemu-devel, Aidan Khoury
On Fri, 13 Feb 2026 at 11:09, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Fri, Feb 13, 2026 at 11:21:09AM +0100, Paolo Bonzini wrote:
> > From: Aidan Khoury <aidan@aktech.ai>
> >
> > The new Diamond Rapids x86 cpu model definition that was added in 7a6dd8bde1
> > has an unexpected comma in the `.features[FEAT_VMX_EXIT_CTLS]` subobject
> > initializer, causing the prior initialization to be overridden. For this
> > reason `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE`
> > is not included.
> >
> > Fix this by replacing the comma with the missing bitwise OR to properly
> > combine all the flags into a single bitmask value.
> >
> > Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids")
> > Signed-off-by: Aidan Khoury <aidan@aktech.ai>
>
> That's missing your S-o-B
I have this pullreq tested and ready to apply -- do you think this
is important enough to respin?
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition
2026-02-13 11:48 ` Peter Maydell
@ 2026-02-13 11:52 ` Daniel P. Berrangé
2026-02-13 11:54 ` Peter Maydell
0 siblings, 1 reply; 7+ messages in thread
From: Daniel P. Berrangé @ 2026-02-13 11:52 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, qemu-devel, Aidan Khoury
On Fri, Feb 13, 2026 at 11:48:29AM +0000, Peter Maydell wrote:
> On Fri, 13 Feb 2026 at 11:09, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Fri, Feb 13, 2026 at 11:21:09AM +0100, Paolo Bonzini wrote:
> > > From: Aidan Khoury <aidan@aktech.ai>
> > >
> > > The new Diamond Rapids x86 cpu model definition that was added in 7a6dd8bde1
> > > has an unexpected comma in the `.features[FEAT_VMX_EXIT_CTLS]` subobject
> > > initializer, causing the prior initialization to be overridden. For this
> > > reason `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE`
> > > is not included.
> > >
> > > Fix this by replacing the comma with the missing bitwise OR to properly
> > > combine all the flags into a single bitmask value.
> > >
> > > Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids")
> > > Signed-off-by: Aidan Khoury <aidan@aktech.ai>
> >
> > That's missing your S-o-B
>
>
> I have this pullreq tested and ready to apply -- do you think this
> is important enough to respin?
I'm not that fussed if it is just 1 out of the 41 patches, but I've
not received the other patches in this pull so haven't checked.
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition
2026-02-13 11:52 ` Daniel P. Berrangé
@ 2026-02-13 11:54 ` Peter Maydell
0 siblings, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2026-02-13 11:54 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: Paolo Bonzini, qemu-devel, Aidan Khoury
On Fri, 13 Feb 2026 at 11:52, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Fri, Feb 13, 2026 at 11:48:29AM +0000, Peter Maydell wrote:
> > On Fri, 13 Feb 2026 at 11:09, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > >
> > > On Fri, Feb 13, 2026 at 11:21:09AM +0100, Paolo Bonzini wrote:
> > > > From: Aidan Khoury <aidan@aktech.ai>
> > > >
> > > > The new Diamond Rapids x86 cpu model definition that was added in 7a6dd8bde1
> > > > has an unexpected comma in the `.features[FEAT_VMX_EXIT_CTLS]` subobject
> > > > initializer, causing the prior initialization to be overridden. For this
> > > > reason `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE`
> > > > is not included.
> > > >
> > > > Fix this by replacing the comma with the missing bitwise OR to properly
> > > > combine all the flags into a single bitmask value.
> > > >
> > > > Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids")
> > > > Signed-off-by: Aidan Khoury <aidan@aktech.ai>
> > >
> > > That's missing your S-o-B
> >
> >
> > I have this pullreq tested and ready to apply -- do you think this
> > is important enough to respin?
>
> I'm not that fussed if it is just 1 out of the 41 patches, but I've
> not received the other patches in this pull so haven't checked.
Looks like it was just this one patch.
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL v2 00/41] QOM, target/i386 patches for 2026-02-12
2026-02-13 10:21 [PULL v2 00/41] QOM, target/i386 patches for 2026-02-12 Paolo Bonzini
2026-02-13 10:21 ` [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition Paolo Bonzini
@ 2026-02-13 14:12 ` Peter Maydell
1 sibling, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2026-02-13 14:12 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Fri, 13 Feb 2026 at 10:21, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit cd5a79dc98e3087e7658e643bdbbb0baec77ac8a:
>
> Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2026-02-05 13:54:50 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 7db36b822316a830ae803e903a12e920e3273b85:
>
> target/i386/mshv: remove unused optimization of gva=>gpa translation (2026-02-13 11:16:52 +0100)
>
> ----------------------------------------------------------------
> * hw/i386: Remove deprecated PC 2.6 and 2.7 machines
> * i386/cpu: Fix incorrect initializer in Diamond Rapids definition
> * qom: Clean up property release
> * target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
> * target/i386/kvm: reset AMD and perfmon-v2 PMU registers during VM reset
> * mshv: Cleanup
> * target/i386: convert SEV-ES termination requests to guest panic events
>
> ----------------------------------------------------------------
Applied, thanks (I decided one missing s-o-b wasn't worth respinning).
Please update the changelog at https://wiki.qemu.org/ChangeLog/11.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-02-13 14:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-13 10:21 [PULL v2 00/41] QOM, target/i386 patches for 2026-02-12 Paolo Bonzini
2026-02-13 10:21 ` [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition Paolo Bonzini
2026-02-13 11:08 ` Daniel P. Berrangé
2026-02-13 11:48 ` Peter Maydell
2026-02-13 11:52 ` Daniel P. Berrangé
2026-02-13 11:54 ` Peter Maydell
2026-02-13 14:12 ` [PULL v2 00/41] QOM, target/i386 patches for 2026-02-12 Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.