All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Kunwu Chan <kunwu.chan@linux.dev>
Cc: Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor@kernel.org>, Alexandre Ghiti <alex@ghiti.fr>,
	Anup Patel <anup@brainfault.org>,
	Atish Patra <atishp@rivosinc.com>, Zong Li <zong.li@sifive.com>,
	Deepak Gupta <debug@rivosinc.com>,
	Zhouyi Zhou <zhouzhouyi@gmail.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code
Date: Fri, 20 Feb 2026 23:38:03 +0800	[thread overview]
Message-ID: <aZh_25dtac8wDFNe@xhacker> (raw)
In-Reply-To: <20260214023804.677127-1-kunwu.chan@linux.dev>

On Sat, Feb 14, 2026 at 10:38:02AM +0800, Kunwu Chan wrote:
> Fix a few minor issues found in riscv XIP-related code:

'RESEND' isn't expected to be used as you did in this series.
You sent the v1 series on Feb 14, only 4 days ago, the series doesn't
miss any dev window.
https://lore.kernel.org/linux-riscv/8ee1b065-b021-411b-b5ee-22c4a108cbce@linux.dev/T/#t

> 
> - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> - head.S: spelling typo and wrong #endif comment

I'm sorry, but how important is fixing comment/spelling typo or #endif
comment among maintainship? The riscv XIP code doesn't stand on itself,
but heavily affects and is affected by other riscv arch common code.

> 
> Kunwu Chan (2):
>   riscv: xip_fixup.h: fix comment typo and whitespace issue
>   riscv: head.S: fix typo and wrong #endif comment
> 
>  arch/riscv/include/asm/xip_fixup.h | 4 ++--
>  arch/riscv/kernel/head.S           | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@kernel.org>
To: Kunwu Chan <kunwu.chan@linux.dev>
Cc: Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor@kernel.org>, Alexandre Ghiti <alex@ghiti.fr>,
	Anup Patel <anup@brainfault.org>,
	Atish Patra <atishp@rivosinc.com>, Zong Li <zong.li@sifive.com>,
	Deepak Gupta <debug@rivosinc.com>,
	Zhouyi Zhou <zhouzhouyi@gmail.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code
Date: Fri, 20 Feb 2026 23:38:03 +0800	[thread overview]
Message-ID: <aZh_25dtac8wDFNe@xhacker> (raw)
In-Reply-To: <20260214023804.677127-1-kunwu.chan@linux.dev>

On Sat, Feb 14, 2026 at 10:38:02AM +0800, Kunwu Chan wrote:
> Fix a few minor issues found in riscv XIP-related code:

'RESEND' isn't expected to be used as you did in this series.
You sent the v1 series on Feb 14, only 4 days ago, the series doesn't
miss any dev window.
https://lore.kernel.org/linux-riscv/8ee1b065-b021-411b-b5ee-22c4a108cbce@linux.dev/T/#t

> 
> - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> - head.S: spelling typo and wrong #endif comment

I'm sorry, but how important is fixing comment/spelling typo or #endif
comment among maintainship? The riscv XIP code doesn't stand on itself,
but heavily affects and is affected by other riscv arch common code.

> 
> Kunwu Chan (2):
>   riscv: xip_fixup.h: fix comment typo and whitespace issue
>   riscv: head.S: fix typo and wrong #endif comment
> 
>  arch/riscv/include/asm/xip_fixup.h | 4 ++--
>  arch/riscv/kernel/head.S           | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2026-02-20 15:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14  2:38 [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code Kunwu Chan
2026-02-14  2:38 ` Kunwu Chan
2026-02-14  2:38 ` [PATCH RESEND 1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue Kunwu Chan
2026-02-14  2:38   ` Kunwu Chan
2026-02-14  2:38 ` [PATCH RESEND 2/2] riscv: head.S: fix typo and wrong #endif comment Kunwu Chan
2026-02-14  2:38   ` Kunwu Chan
2026-02-17 21:12 ` [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code Paul Walmsley
2026-02-17 21:12   ` Paul Walmsley
2026-02-18  0:58   ` Nam Cao
2026-02-18  0:58     ` Nam Cao
2026-02-20 15:38 ` Jisheng Zhang [this message]
2026-02-20 15:38   ` Jisheng Zhang
2026-02-20 22:39   ` Conor Dooley
2026-02-20 22:39     ` Conor Dooley
2026-03-18 23:23 ` Paul Walmsley
2026-03-18 23:23   ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZh_25dtac8wDFNe@xhacker \
    --to=jszhang@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atishp@rivosinc.com \
    --cc=conor@kernel.org \
    --cc=debug@rivosinc.com \
    --cc=kunwu.chan@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=zhouzhouyi@gmail.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.