All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: liuyd.fnst@fujitsu.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used
Date: Mon, 23 Feb 2026 03:54:46 +0000	[thread overview]
Message-ID: <aZvPhtEoEC0PE8sl@gmail.com> (raw)
In-Reply-To: <20260213043115.19961-1-liuyd.fnst@fujitsu.com>

merged.

Bruce

In message: [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used
on 13/02/2026 Yiding Liu (Fujitsu) via lists.yoctoproject.org wrote:

> irqbalance: correct to install /etc/default for sysvinit
> 
> 1.This commit uses option --with-pkgconfdir for sysvinit to correct to install /etc/default
>   Without this fix, there will show do_package QA Issue when sysvinit is used
>   ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance: Files/directories were installed but not shipped in any package:
>     /usr/etc
>     /usr/etc/default
>     /usr/etc/default/irqbalance.env
> 
>   Previous PACKAGECONFIG[systemd]�only works when systemd is used. So making this patch to fix it.
> 
> 2.Merge DEPENDS for systemd into PACKAGECONFIG[systemd]
> 
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
> Changes in v2:
> - Improved commit message to explain the sysvinit case
> - Use PACKAGECONFIG instead of EXTRA_OECONF
> 
> ---
>  recipes-extended/irqbalance/irqbalance.inc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/recipes-extended/irqbalance/irqbalance.inc b/recipes-extended/irqbalance/irqbalance.inc
> index 35b6388e..0c570e12 100644
> --- a/recipes-extended/irqbalance/irqbalance.inc
> +++ b/recipes-extended/irqbalance/irqbalance.inc
> @@ -14,7 +14,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>  		   "
>  
>  DEPENDS = "glib-2.0"
> -DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
>  
>  INITSCRIPT_NAME = "irqbalanced"
>  INITSCRIPT_PARAMS = "defaults"
> @@ -34,7 +33,7 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
>  #
>  PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
>  PACKAGECONFIG[libcap-ng] = "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
> -PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},,,"
> +PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},--with-pkgconfdir=${sysconfdir},systemd,"
>  
>  do_install () {
>          oe_runmake 'DESTDIR=${D}' install
> -- 
> 2.43.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9586): https://lists.yoctoproject.org/g/meta-virtualization/message/9586
> Mute This Topic: https://lists.yoctoproject.org/mt/117787082/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



  reply	other threads:[~2026-02-23  3:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  4:31 [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used Liu Yiding
2026-02-23  3:54 ` Bruce Ashfield [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-12  3:09 Liu Yiding
2026-02-12  4:57 ` Bruce Ashfield
2026-02-13  3:02   ` 回复: " Yiding Liu (Fujitsu)
2026-02-13  3:04     ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZvPhtEoEC0PE8sl@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=liuyd.fnst@fujitsu.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.