All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used
@ 2026-02-13  4:31 Liu Yiding
  2026-02-23  3:54 ` Bruce Ashfield
  0 siblings, 1 reply; 5+ messages in thread
From: Liu Yiding @ 2026-02-13  4:31 UTC (permalink / raw)
  To: meta-virtualization

irqbalance: correct to install /etc/default for sysvinit

1.This commit uses option --with-pkgconfdir for sysvinit to correct to install /etc/default
  Without this fix, there will show do_package QA Issue when sysvinit is used
  ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance: Files/directories were installed but not shipped in any package:
    /usr/etc
    /usr/etc/default
    /usr/etc/default/irqbalance.env

  Previous PACKAGECONFIG[systemd] only works when systemd is used. So making this patch to fix it.

2.Merge DEPENDS for systemd into PACKAGECONFIG[systemd]

Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
---
Changes in v2:
- Improved commit message to explain the sysvinit case
- Use PACKAGECONFIG instead of EXTRA_OECONF

---
 recipes-extended/irqbalance/irqbalance.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/recipes-extended/irqbalance/irqbalance.inc b/recipes-extended/irqbalance/irqbalance.inc
index 35b6388e..0c570e12 100644
--- a/recipes-extended/irqbalance/irqbalance.inc
+++ b/recipes-extended/irqbalance/irqbalance.inc
@@ -14,7 +14,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
 		   "
 
 DEPENDS = "glib-2.0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
 
 INITSCRIPT_NAME = "irqbalanced"
 INITSCRIPT_PARAMS = "defaults"
@@ -34,7 +33,7 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
 #
 PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
 PACKAGECONFIG[libcap-ng] = "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
-PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},,,"
+PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},--with-pkgconfdir=${sysconfdir},systemd,"
 
 do_install () {
         oe_runmake 'DESTDIR=${D}' install
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used
@ 2026-02-12  3:09 Liu Yiding
  2026-02-12  4:57 ` Bruce Ashfield
  0 siblings, 1 reply; 5+ messages in thread
From: Liu Yiding @ 2026-02-12  3:09 UTC (permalink / raw)
  To: meta-virtualization

irqbalance: correct to install /etc/default for sysvinit

1. This commit uses option --with-pkgconfdir to correct to install /etc/default when sysvinit is used.
   Without this fix, there will show do_package QA Issue
   ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance: Files/directories were installed but not shipped in any package:
     /usr/etc
     /usr/etc/default
     /usr/etc/default/irqbalance.env

  Previous PACKAGECONFIG[systemd] only works when systemd is used. When using sysvinit, --with-pkgconfdir=${sysconfdir} can't work, so making this patch to fix it.

2. Merge DEPENDS for systemd into PACKAGECONFIG[systemd]

Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
---
 recipes-extended/irqbalance/irqbalance.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-extended/irqbalance/irqbalance.inc b/recipes-extended/irqbalance/irqbalance.inc
index 35b6388e..b7b34a0b 100644
--- a/recipes-extended/irqbalance/irqbalance.inc
+++ b/recipes-extended/irqbalance/irqbalance.inc
@@ -14,7 +14,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
 		   "
 
 DEPENDS = "glib-2.0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
 
 INITSCRIPT_NAME = "irqbalanced"
 INITSCRIPT_PARAMS = "defaults"
@@ -25,6 +24,7 @@ SYSTEMD_PACKAGES = "irqbalance"
 SYSTEMD_SERVICE:irqbalance = "irqbalance.service"
 
 EXTRA_OECONF = "--program-transform-name= \
+                --with-pkgconfdir=${sysconfdir} \
 	       "
 
 # let the recipes or appends define options
@@ -34,7 +34,7 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
 #
 PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
 PACKAGECONFIG[libcap-ng] = "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
-PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},,,"
+PACKAGECONFIG[systemd] = "--with-systemd,,systemd"
 
 do_install () {
         oe_runmake 'DESTDIR=${D}' install
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-02-23  3:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-13  4:31 [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used Liu Yiding
2026-02-23  3:54 ` Bruce Ashfield
  -- strict thread matches above, loose matches on Subject: below --
2026-02-12  3:09 Liu Yiding
2026-02-12  4:57 ` Bruce Ashfield
2026-02-13  3:02   ` 回复: " Yiding Liu (Fujitsu)
2026-02-13  3:04     ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.