[meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used

[meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used

[Liu Yiding]

irqbalance: correct to install /etc/default for sysvinit

1. This commit uses option --with-pkgconfdir to correct to install /etc/default when sysvinit is used.
   Without this fix, there will show do_package QA Issue
   ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance: Files/directories were installed but not shipped in any package:
     /usr/etc
     /usr/etc/default
     /usr/etc/default/irqbalance.env

  Previous PACKAGECONFIG[systemd] only works when systemd is used. When using sysvinit, --with-pkgconfdir=${sysconfdir} can't work, so making this patch to fix it.

2. Merge DEPENDS for systemd into PACKAGECONFIG[systemd]

Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
---
 recipes-extended/irqbalance/irqbalance.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-extended/irqbalance/irqbalance.inc b/recipes-extended/irqbalance/irqbalance.inc
index 35b6388e..b7b34a0b 100644
--- a/recipes-extended/irqbalance/irqbalance.inc
+++ b/recipes-extended/irqbalance/irqbalance.inc
@@ -14,7 +14,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
 		   "
 
 DEPENDS = "glib-2.0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
 
 INITSCRIPT_NAME = "irqbalanced"
 INITSCRIPT_PARAMS = "defaults"
@@ -25,6 +24,7 @@ SYSTEMD_PACKAGES = "irqbalance"
 SYSTEMD_SERVICE:irqbalance = "irqbalance.service"
 
 EXTRA_OECONF = "--program-transform-name= \
+                --with-pkgconfdir=${sysconfdir} \
 	       "
 
 # let the recipes or appends define options
@@ -34,7 +34,7 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
 #
 PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
 PACKAGECONFIG[libcap-ng] = "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
-PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},,,"
+PACKAGECONFIG[systemd] = "--with-systemd,,systemd"
 
 do_install () {
         oe_runmake 'DESTDIR=${D}' install
-- 
2.43.0

Re: [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 3102 bytes --]

On Wed, Feb 11, 2026 at 10:09 PM Yiding Liu (Fujitsu) via
lists.yoctoproject.org <liuyd.fnst=fujitsu.com@lists.yoctoproject.org>
wrote:

> irqbalance: correct to install /etc/default for sysvinit
>
> 1. This commit uses option --with-pkgconfdir to correct to install
> /etc/default when sysvinit is used.
>    Without this fix, there will show do_package QA Issue
>    ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance:
> Files/directories were installed but not shipped in any package:
>      /usr/etc
>      /usr/etc/default
>      /usr/etc/default/irqbalance.env
>
>   Previous PACKAGECONFIG[systemd] only works when systemd is used. When
> using sysvinit, --with-pkgconfdir=${sysconfdir} can't work, so making this
> patch to fix it.
>
> 2. Merge DEPENDS for systemd into PACKAGECONFIG[systemd]
>
>
You need to address my review comments directly.

Also, summarize what has changed in a v2 below the --- in the patch itself.

Cheers,

Bruce



> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
>  recipes-extended/irqbalance/irqbalance.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-extended/irqbalance/irqbalance.inc
> b/recipes-extended/irqbalance/irqbalance.inc
> index 35b6388e..b7b34a0b 100644
> --- a/recipes-extended/irqbalance/irqbalance.inc
> +++ b/recipes-extended/irqbalance/irqbalance.inc
> @@ -14,7 +14,6 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>                    "
>
>  DEPENDS = "glib-2.0"
> -DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
> '', d)}"
>
>  INITSCRIPT_NAME = "irqbalanced"
>  INITSCRIPT_PARAMS = "defaults"
> @@ -25,6 +24,7 @@ SYSTEMD_PACKAGES = "irqbalance"
>  SYSTEMD_SERVICE:irqbalance = "irqbalance.service"
>
>  EXTRA_OECONF = "--program-transform-name= \
> +                --with-pkgconfdir=${sysconfdir} \
>                "
>
>  # let the recipes or appends define options
> @@ -34,7 +34,7 @@ PACKAGECONFIG ?=
> "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
>  #
>  PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
>  PACKAGECONFIG[libcap-ng] =
> "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
> -PACKAGECONFIG[systemd] = "--with-systemd
> --with-pkgconfdir=${sysconfdir},,,"
> +PACKAGECONFIG[systemd] = "--with-systemd,,systemd"
>
>  do_install () {
>          oe_runmake 'DESTDIR=${D}' install
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9582):
> https://lists.yoctoproject.org/g/meta-virtualization/message/9582
> Mute This Topic: https://lists.yoctoproject.org/mt/117769267/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 5132 bytes --]

Re: [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 4582 bytes --]

On Thu, Feb 12, 2026 at 10:02 PM Yiding Liu (Fujitsu) <
liuyd.fnst@fujitsu.com> wrote:

> Hi Bruce
>
>     I'm sorry to misunderstood your emails.
>
>     Now I will resend the v2 patch like following:
>
>    1. To use PACKAGECONFIG instead of EXTRA_OECONF
>
>      PACKAGECONFIG[systemd] = "--with-systemd
> --with-pkgconfdir=${sysconfdir},--with-pkgconfdir=${sysconfdir},systemd,"
>
>
>    2. Summarize what has changed in a v2 below the --- like
>    ......
>    Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
>
> ---
> Changes in v2:
> - Improved commit message to explain the sysvinit case
> - Use PACKAGECONFIG instead of EXTRA_OECONF
>
>       Is that OK?
>
>
Yes, that's it!

Normally I would have just edited it myself, but I had to get to some other
reviews.

Thanks for the contribution, it is much appreciated.

Bruce



> Liu
>
>
> ------------------------------
> *发件人:* Bruce Ashfield <bruce.ashfield@gmail.com>
> *发送时间:* 2026年2月12日 12:57
> *收件人:* Liu, Yiding/刘 乙丁 <liuyd.fnst@fujitsu.com>
> *抄送:* meta-virtualization@lists.yoctoproject.org <
> meta-virtualization@lists.yoctoproject.org>
> *主题:* Re: [meta-virtualization][PATCH v2] irqbalance: Fix QA error when
> sysvinit is used
>
>
>
> On Wed, Feb 11, 2026 at 10:09 PM Yiding Liu (Fujitsu) via
> lists.yoctoproject.org <liuyd.fnst=fujitsu.com@lists.yoctoproject.org>
> wrote:
>
> irqbalance: correct to install /etc/default for sysvinit
>
> 1. This commit uses option --with-pkgconfdir to correct to install
> /etc/default when sysvinit is used.
>    Without this fix, there will show do_package QA Issue
>    ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance:
> Files/directories were installed but not shipped in any package:
>      /usr/etc
>      /usr/etc/default
>      /usr/etc/default/irqbalance.env
>
>   Previous PACKAGECONFIG[systemd] only works when systemd is used. When
> using sysvinit, --with-pkgconfdir=${sysconfdir} can't work, so making this
> patch to fix it.
>
> 2. Merge DEPENDS for systemd into PACKAGECONFIG[systemd]
>
>
> You need to address my review comments directly.
>
> Also, summarize what has changed in a v2 below the --- in the patch itself.
>
> Cheers,
>
> Bruce
>
>
>
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
>  recipes-extended/irqbalance/irqbalance.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-extended/irqbalance/irqbalance.inc
> b/recipes-extended/irqbalance/irqbalance.inc
> index 35b6388e..b7b34a0b 100644
> --- a/recipes-extended/irqbalance/irqbalance.inc
> +++ b/recipes-extended/irqbalance/irqbalance.inc
> @@ -14,7 +14,6 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>                    "
>
>  DEPENDS = "glib-2.0"
> -DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
> '', d)}"
>
>  INITSCRIPT_NAME = "irqbalanced"
>  INITSCRIPT_PARAMS = "defaults"
> @@ -25,6 +24,7 @@ SYSTEMD_PACKAGES = "irqbalance"
>  SYSTEMD_SERVICE:irqbalance = "irqbalance.service"
>
>  EXTRA_OECONF = "--program-transform-name= \
> +                --with-pkgconfdir=${sysconfdir} \
>                "
>
>  # let the recipes or appends define options
> @@ -34,7 +34,7 @@ PACKAGECONFIG ?=
> "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
>  #
>  PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
>  PACKAGECONFIG[libcap-ng] =
> "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
> -PACKAGECONFIG[systemd] = "--with-systemd
> --with-pkgconfdir=${sysconfdir},,,"
> +PACKAGECONFIG[systemd] = "--with-systemd,,systemd"
>
>  do_install () {
>          oe_runmake 'DESTDIR=${D}' install
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9582):
> https://lists.yoctoproject.org/g/meta-virtualization/message/9582
> Mute This Topic: https://lists.yoctoproject.org/mt/117769267/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 11903 bytes --]

[meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used

[Liu Yiding]

irqbalance: correct to install /etc/default for sysvinit

1.This commit uses option --with-pkgconfdir for sysvinit to correct to install /etc/default
  Without this fix, there will show do_package QA Issue when sysvinit is used
  ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance: Files/directories were installed but not shipped in any package:
    /usr/etc
    /usr/etc/default
    /usr/etc/default/irqbalance.env

  Previous PACKAGECONFIG[systemd] only works when systemd is used. So making this patch to fix it.

2.Merge DEPENDS for systemd into PACKAGECONFIG[systemd]

Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
---
Changes in v2:
- Improved commit message to explain the sysvinit case
- Use PACKAGECONFIG instead of EXTRA_OECONF

---
 recipes-extended/irqbalance/irqbalance.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/recipes-extended/irqbalance/irqbalance.inc b/recipes-extended/irqbalance/irqbalance.inc
index 35b6388e..0c570e12 100644
--- a/recipes-extended/irqbalance/irqbalance.inc
+++ b/recipes-extended/irqbalance/irqbalance.inc
@@ -14,7 +14,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
 		   "
 
 DEPENDS = "glib-2.0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
 
 INITSCRIPT_NAME = "irqbalanced"
 INITSCRIPT_PARAMS = "defaults"
@@ -34,7 +33,7 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
 #
 PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
 PACKAGECONFIG[libcap-ng] = "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
-PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},,,"
+PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},--with-pkgconfdir=${sysconfdir},systemd,"
 
 do_install () {
         oe_runmake 'DESTDIR=${D}' install
-- 
2.43.0

Re: [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used

[Bruce Ashfield]

merged.

Bruce

In message: [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit is used
on 13/02/2026 Yiding Liu (Fujitsu) via lists.yoctoproject.org wrote:

> irqbalance: correct to install /etc/default for sysvinit
> 
> 1.This commit uses option --with-pkgconfdir for sysvinit to correct to install /etc/default
>   Without this fix, there will show do_package QA Issue when sysvinit is used
>   ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance: Files/directories were installed but not shipped in any package:
>     /usr/etc
>     /usr/etc/default
>     /usr/etc/default/irqbalance.env
> 
>   Previous PACKAGECONFIG[systemd]�only works when systemd is used. So making this patch to fix it.
> 
> 2.Merge DEPENDS for systemd into PACKAGECONFIG[systemd]
> 
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
> Changes in v2:
> - Improved commit message to explain the sysvinit case
> - Use PACKAGECONFIG instead of EXTRA_OECONF
> 
> ---
>  recipes-extended/irqbalance/irqbalance.inc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/recipes-extended/irqbalance/irqbalance.inc b/recipes-extended/irqbalance/irqbalance.inc
> index 35b6388e..0c570e12 100644
> --- a/recipes-extended/irqbalance/irqbalance.inc
> +++ b/recipes-extended/irqbalance/irqbalance.inc
> @@ -14,7 +14,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>  		   "
>  
>  DEPENDS = "glib-2.0"
> -DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
>  
>  INITSCRIPT_NAME = "irqbalanced"
>  INITSCRIPT_PARAMS = "defaults"
> @@ -34,7 +33,7 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd',
>  #
>  PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
>  PACKAGECONFIG[libcap-ng] = "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
> -PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},,,"
> +PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},--with-pkgconfdir=${sysconfdir},systemd,"
>  
>  do_install () {
>          oe_runmake 'DESTDIR=${D}' install
> -- 
> 2.43.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9586): https://lists.yoctoproject.org/g/meta-virtualization/message/9586
> Mute This Topic: https://lists.yoctoproject.org/mt/117787082/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>