[Buildroot] [PATCH 0/2] package/openscap: fix build failure for openscap

[Buildroot] [PATCH 0/2] package/openscap: fix build failure for openscap

[Alexis Lothoré via buildroot]

Hello,
this small series aims to fix yet another build failure detected by the
autobuilder for the recently merged openscap package.
- first commit fixes an unrelated issue about wrong comment management
  when missing dependencies
- second commit fixes the build failure raised by [1]

Alexis

[1] https://autobuild.buildroot.org/results/2d9475b7cd2d413c99d6233ebb213bc932f1e398/

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
Alexis Lothoré (2):
      package/openscap: fix dependencies doc
      package/openscap: add dependency on NPTL threads

 package/openscap/Config.in | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
---
base-commit: 346d6667febdbec9a3c57e47009ab21e121b5b1d
change-id: 20260304-openscap_nptl_threads-43fa4be43566

Best regards,
-- 
Alexis Lothoré <alexis.lothore@bootlin.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/2] package/openscap: fix dependencies doc

[Alexis Lothoré via buildroot]

The comment displayed in menuconfig for openscap when we are lacking
dependencies is currently broken: it should be an or of inverted
expected values.

Update the comment for openscap when it is missing some dependency.

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
 package/openscap/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/package/openscap/Config.in b/package/openscap/Config.in
index 317055c75327..b5f809315c91 100644
--- a/package/openscap/Config.in
+++ b/package/openscap/Config.in
@@ -19,6 +19,5 @@ config BR2_PACKAGE_OPENSCAP
 	  https://www.open-scap.org/
 	  https://github.com/OpenSCAP/openscap
 
-comment "openscap needs a toolchain w/ dynamic library"
-	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
-	depends on BR2_STATIC_LIBS
+comment "openscap needs libgpg-error and a toolchain w/ dynamic library"
+	depends on !BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS || BR2_STATIC_LIBS

-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/openscap: add dependency on NPTL threads

[Alexis Lothoré via buildroot]

Openscap code is calling NPTL functions such as pthread_barrier_wait,
which are not provided by pthreads.

Make the requirement on NPTL threads explicit by adding the
corresponding  dependency in openscap Config.in.

Fixes: https://autobuild.buildroot.org/results/2d9475b7cd2d413c99d6233ebb213bc932f1e398/
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
 package/openscap/Config.in | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/package/openscap/Config.in b/package/openscap/Config.in
index b5f809315c91..fa77905898af 100644
--- a/package/openscap/Config.in
+++ b/package/openscap/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_OPENSCAP
 	bool "openscap"
 	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS  # libgcrypt
 	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	select BR2_PACKAGE_LIBCURL
 	# In theory should build without crypto, but in practice it
 	# doesn't: https://github.com/OpenSCAP/openscap/issues/2310
@@ -19,5 +20,7 @@ config BR2_PACKAGE_OPENSCAP
 	  https://www.open-scap.org/
 	  https://github.com/OpenSCAP/openscap
 
-comment "openscap needs libgpg-error and a toolchain w/ dynamic library"
-	depends on !BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS || BR2_STATIC_LIBS
+comment "openscap needs libgpg-error and a toolchain w/ dynamic library and NPTL threads"
+	depends on !BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS || \
+		BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_HAS_THREADS_NPTL

-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/openscap: fix dependencies doc

[Thomas Petazzoni via buildroot]

On Wed, Mar 04, 2026 at 09:22:39AM +0100, Alexis Lothoré wrote:
> The comment displayed in menuconfig for openscap when we are lacking
> dependencies is currently broken: it should be an or of inverted
> expected values.
> 
> Update the comment for openscap when it is missing some dependency.
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> ---
>  package/openscap/Config.in | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/openscap/Config.in b/package/openscap/Config.in
> index 317055c75327..b5f809315c91 100644
> --- a/package/openscap/Config.in
> +++ b/package/openscap/Config.in
> @@ -19,6 +19,5 @@ config BR2_PACKAGE_OPENSCAP
>  	  https://www.open-scap.org/
>  	  https://github.com/OpenSCAP/openscap
>  
> -comment "openscap needs a toolchain w/ dynamic library"
> -	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
> -	depends on BR2_STATIC_LIBS
> +comment "openscap needs libgpg-error and a toolchain w/ dynamic library"
> +	depends on !BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS || BR2_STATIC_LIBS

Sorry, but the existing comment is correct. We want to show the
comment when we're on an architecture that we can support, but the
toolchain lacks some features.

So as far as I can see the existing code is correct, and your patch
changes it to be incorrect :-/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/openscap: add dependency on NPTL threads

[Thomas Petazzoni via buildroot]

On Wed, Mar 04, 2026 at 09:22:40AM +0100, Alexis Lothoré wrote:
> +comment "openscap needs libgpg-error and a toolchain w/ dynamic library and NPTL threads"

Should be just "toolchain w/ dynamic library, NPTL"

(and of course rebased without PATCH 1/2, as it is not correct)

Other than that, looks good to me, thanks!

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/openscap: fix dependencies doc

[Alexis Lothoré via buildroot]

Hi Thomas,

On Wed Mar 4, 2026 at 7:04 PM CET, Thomas Petazzoni wrote:
> On Wed, Mar 04, 2026 at 09:22:39AM +0100, Alexis Lothoré wrote:
>> The comment displayed in menuconfig for openscap when we are lacking
>> dependencies is currently broken: it should be an or of inverted
>> expected values.
>> 
>> Update the comment for openscap when it is missing some dependency.
>> 
>> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
>> ---
>>  package/openscap/Config.in | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>> 
>> diff --git a/package/openscap/Config.in b/package/openscap/Config.in
>> index 317055c75327..b5f809315c91 100644
>> --- a/package/openscap/Config.in
>> +++ b/package/openscap/Config.in
>> @@ -19,6 +19,5 @@ config BR2_PACKAGE_OPENSCAP
>>  	  https://www.open-scap.org/
>>  	  https://github.com/OpenSCAP/openscap
>>  
>> -comment "openscap needs a toolchain w/ dynamic library"
>> -	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
>> -	depends on BR2_STATIC_LIBS
>> +comment "openscap needs libgpg-error and a toolchain w/ dynamic library"
>> +	depends on !BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS || BR2_STATIC_LIBS
>
> Sorry, but the existing comment is correct. We want to show the
> comment when we're on an architecture that we can support, but the
> toolchain lacks some features.
>
> So as far as I can see the existing code is correct, and your patch
> changes it to be incorrect :-/

I guess I've been missing this subtlety between toolchain dependency and
non-toolchain dependency, and so  I though that it was a mistake that
slipped through ;) I've educated myself by re-reading the corresponding
section in BR manual, and indeed it is plain wrong, my bad for the
noise.

V2 incoming, with this patch dropped, and the second one updated
accordingly.

Alexis

> Thomas




-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot