From: Markus Elfring <Markus.Elfring@web.de>
To: "Algea Cao" <algea.cao@rock-chips.com>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mark Yao" <markyao0591@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Rob Herring" <robh@kernel.org>, "Robert Foss" <rfoss@kernel.org>,
"Sandy Huang" <hjc@rock-chips.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexandre Arnoud <aarnoud@me.com>,
Luis de Arquer <ldearquer@gmail.com>
Subject: Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library
Date: Sun, 8 Sep 2024 11:11:23 +0200 [thread overview]
Message-ID: <ab8a17d0-9505-4e81-b5ec-4a3025c48245@web.de> (raw)
In-Reply-To: <20240831-b4-rk3588-bridge-upstream-v5-2-9503bece0136@collabora.com>
…
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
> @@ -0,0 +1,708 @@
…
> +static int dw_hdmi_qp_i2c_xfer(struct i2c_adapter *adap,
> + struct i2c_msg *msgs, int num)
> +{
…
> + mutex_lock(&i2c->lock);
…
> + dw_hdmi_qp_mod(hdmi, 0, I2CM_OP_DONE_MASK_N | I2CM_NACK_RCVD_MASK_N,
> + MAINUNIT_1_INT_MASK_N);
> +
> + mutex_unlock(&i2c->lock);
> +
> + return ret;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&i2c->lock);”?
https://elixir.bootlin.com/linux/v6.11-rc6/source/include/linux/mutex.h#L196
Regards,
Markus
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: "Algea Cao" <algea.cao@rock-chips.com>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mark Yao" <markyao0591@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Rob Herring" <robh@kernel.org>, "Robert Foss" <rfoss@kernel.org>,
"Sandy Huang" <hjc@rock-chips.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexandre Arnoud <aarnoud@me.com>,
Luis de Arquer <ldearquer@gmail.com>
Subject: Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library
Date: Sun, 8 Sep 2024 11:11:23 +0200 [thread overview]
Message-ID: <ab8a17d0-9505-4e81-b5ec-4a3025c48245@web.de> (raw)
In-Reply-To: <20240831-b4-rk3588-bridge-upstream-v5-2-9503bece0136@collabora.com>
…
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
> @@ -0,0 +1,708 @@
…
> +static int dw_hdmi_qp_i2c_xfer(struct i2c_adapter *adap,
> + struct i2c_msg *msgs, int num)
> +{
…
> + mutex_lock(&i2c->lock);
…
> + dw_hdmi_qp_mod(hdmi, 0, I2CM_OP_DONE_MASK_N | I2CM_NACK_RCVD_MASK_N,
> + MAINUNIT_1_INT_MASK_N);
> +
> + mutex_unlock(&i2c->lock);
> +
> + return ret;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&i2c->lock);”?
https://elixir.bootlin.com/linux/v6.11-rc6/source/include/linux/mutex.h#L196
Regards,
Markus
next prev parent reply other threads:[~2024-09-08 9:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 21:55 [PATCH v5 0/4] Add initial support for the Rockchip RK3588 HDMI TX Controller Cristian Ciocaltea
2024-08-30 21:55 ` Cristian Ciocaltea
2024-08-30 21:55 ` [PATCH v5 1/4] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP Cristian Ciocaltea
2024-08-30 21:55 ` Cristian Ciocaltea
2024-08-31 6:16 ` Krzysztof Kozlowski
2024-08-31 6:16 ` Krzysztof Kozlowski
2024-08-31 13:58 ` Heiko Stübner
2024-08-31 13:58 ` Heiko Stübner
2024-08-31 21:53 ` Cristian Ciocaltea
2024-08-31 21:53 ` Cristian Ciocaltea
2024-09-01 6:40 ` Andy Yan
2024-09-01 6:40 ` Andy Yan
2024-09-01 10:23 ` Krzysztof Kozlowski
2024-09-01 10:23 ` Krzysztof Kozlowski
2024-08-30 21:55 ` [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library Cristian Ciocaltea
2024-08-30 21:55 ` Cristian Ciocaltea
2024-09-08 9:11 ` Markus Elfring [this message]
2024-09-08 9:11 ` Markus Elfring
2024-09-10 15:52 ` Cristian Ciocaltea
2024-09-10 15:52 ` Cristian Ciocaltea
2024-08-30 21:55 ` [PATCH v5 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller Cristian Ciocaltea
2024-08-30 21:55 ` Cristian Ciocaltea
2024-08-31 6:13 ` Krzysztof Kozlowski
2024-08-31 6:13 ` Krzysztof Kozlowski
2024-08-31 22:01 ` Cristian Ciocaltea
2024-08-31 22:01 ` Cristian Ciocaltea
2024-09-02 1:09 ` Shimrra Shai
2024-09-02 1:09 ` Shimrra Shai
2024-09-02 22:14 ` Cristian Ciocaltea
2024-09-02 22:14 ` Cristian Ciocaltea
2024-08-30 21:55 ` [PATCH v5 4/4] drm/rockchip: Add basic RK3588 HDMI output support Cristian Ciocaltea
2024-08-30 21:55 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab8a17d0-9505-4e81-b5ec-4a3025c48245@web.de \
--to=markus.elfring@web.de \
--cc=aarnoud@me.com \
--cc=airlied@gmail.com \
--cc=algea.cao@rock-chips.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=ldearquer@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyao0591@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.