Re: [PATCH v2 3/9] media: rockchip: rkcif: add support for rk3588 vicap mipi capture

From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: michael.riesch@collabora.com
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Кузнецов Михаил" <mai.kuznetsov.misha@gmail.com>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
	"Collabora Kernel Team" <kernel@collabora.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/9] media: rockchip: rkcif: add support for rk3588 vicap mipi capture
Date: Tue, 17 Mar 2026 14:08:33 +0100	[thread overview]
Message-ID: <ablRBViDR996euua@mdjait-mobl> (raw)
In-Reply-To: <20250430-rk3588-vicap-v2-3-77de5ee9048e@collabora.com>

Hi Michael,

Thank you for this nice patch!

On Tue, Mar 17, 2026 at 10:32:21AM +0100, Michael Riesch via B4 Relay wrote:
> From: Michael Riesch <michael.riesch@collabora.com>
> 
> The RK3588 Video Capture (VICAP) unit features a Digital Video Port
> (DVP) and six MIPI CSI-2 capture interfaces. Add initial support
> for this variant to the rkcif driver and enable the MIPI CSI-2
> capture interfaces.
> 
> Signed-off-by: Michael Riesch <michael.riesch@collabora.com>

[...]

>  static inline unsigned int rkcif_mipi_get_reg(struct rkcif_interface *interface,
>  					      unsigned int index)
>  {
> @@ -631,6 +765,8 @@ static int rkcif_mipi_start_streaming(struct rkcif_stream *stream)
>  	rkcif_mipi_stream_write(stream, RKCIF_MIPI_CTRL1, ctrl1);
>  	rkcif_mipi_stream_write(stream, RKCIF_MIPI_CTRL0, ctrl0);
>  
> +	rkcif_mipi_write(interface, RKCIF_MIPI_CTRL, RKCIF_MIPI_CTRL_CAP_EN);
> +

while this is the correct solution for rk3588, for the rk3568 vicap this
will write 0x1 to the VICAP_MIPI_CTRL : 0x00A0 which will enable the water line.

--
Kind Regards
Mehdi Djait