Re: [PATCH v2 1/9] Documentation: admin-guide: media: add rk3588 vicap

From: Charalampos Mitrodimas <charmitro@posteo.net>
To: Michael Riesch via B4 Relay
	<devnull+michael.riesch.collabora.com@kernel.org>
Cc: "Mehdi Djait" <mehdi.djait@linux.intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Кузнецов Михаил" <mai.kuznetsov.misha@gmail.com>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
	"Collabora Kernel Team" <kernel@collabora.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	michael.riesch@collabora.com, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] Documentation: admin-guide: media: add rk3588 vicap
Date: Thu, 19 Mar 2026 19:30:14 +0000	[thread overview]
Message-ID: <m2h5qbd3cv.fsf@posteo.net> (raw)
In-Reply-To: <20250430-rk3588-vicap-v2-1-77de5ee9048e@collabora.com>

Michael Riesch via B4 Relay <devnull+michael.riesch.collabora.com@kernel.org> writes:

> From: Michael Riesch <michael.riesch@collabora.com>
>
> Add a section that describes the Rockchip RK3588 VICAP.
>
> Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
> ---
>  .../admin-guide/media/rkcif-rk3588-vicap.dot       | 29 ++++++++++++++++++++
>  Documentation/admin-guide/media/rkcif.rst          | 32 ++++++++++++++++++++++
>  2 files changed, 61 insertions(+)
>
> diff --git a/Documentation/admin-guide/media/rkcif-rk3588-vicap.dot b/Documentation/admin-guide/media/rkcif-rk3588-vicap.dot
> new file mode 100644
> index 000000000000..f6d3404920b5
> --- /dev/null
> +++ b/Documentation/admin-guide/media/rkcif-rk3588-vicap.dot
> @@ -0,0 +1,29 @@
> +digraph board {
> +        rankdir=TB
> +        n00000007 [label="{{<port0> 0} | rkcif-mipi2\n/dev/v4l-subdev0 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green]
> +        n00000007:port1 -> n0000000a
> +        n00000007:port1 -> n00000010 [style=dashed]
> +        n00000007:port1 -> n00000016 [style=dashed]
> +        n00000007:port1 -> n0000001c [style=dashed]
> +        n0000000a [label="rkcif-mipi2-id0\n/dev/video0", shape=box, style=filled, fillcolor=yellow]
> +        n00000010 [label="rkcif-mipi2-id1\n/dev/video1", shape=box, style=filled, fillcolor=yellow]
> +        n00000016 [label="rkcif-mipi2-id2\n/dev/video2", shape=box, style=filled, fillcolor=yellow]
> +        n0000001c [label="rkcif-mipi2-id3\n/dev/video3", shape=box, style=filled, fillcolor=yellow]
> +        n00000025 [label="{{<port0> 0} | rkcif-mipi4\n/dev/v4l-subdev1 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green]
> +        n00000025:port1 -> n00000028
> +        n00000025:port1 -> n0000002e [style=dashed]
> +        n00000025:port1 -> n00000034 [style=dashed]
> +        n00000025:port1 -> n0000003a [style=dashed]
> +        n00000028 [label="rkcif-mipi4-id0\n/dev/video4", shape=box, style=filled, fillcolor=yellow]
> +        n0000002e [label="rkcif-mipi4-id1\n/dev/video5", shape=box, style=filled, fillcolor=yellow]
> +        n00000034 [label="rkcif-mipi4-id2\n/dev/video6", shape=box, style=filled, fillcolor=yellow]
> +        n0000003a [label="rkcif-mipi4-id3\n/dev/video7", shape=box, style=filled, fillcolor=yellow]
> +        n00000043 [label="{{<port0> 0} | dw-mipi-csi2rx fdd30000.csi\n/dev/v4l-subdev2 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green]
> +        n00000043:port1 -> n00000007:port0
> +        n00000048 [label="{{<port0> 0} | dw-mipi-csi2rx fdd50000.csi\n/dev/v4l-subdev3 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green]
> +        n00000048:port1 -> n00000025:port0
> +        n0000004d [label="{{} | imx415 3-001a\n/dev/v4l-subdev4 | {<port0> 0}}", shape=Mrecord, style=filled, fillcolor=green]
> +        n0000004d:port0 -> n00000043:port0
> +        n00000051 [label="{{} | imx415 4-001a\n/dev/v4l-subdev5 | {<port0> 0}}", shape=Mrecord, style=filled, fillcolor=green]
> +        n00000051:port0 -> n00000048:port0
> +}
> diff --git a/Documentation/admin-guide/media/rkcif.rst b/Documentation/admin-guide/media/rkcif.rst
> index 2558c121abc4..fcd7f8cfc5d3 100644
> --- a/Documentation/admin-guide/media/rkcif.rst
> +++ b/Documentation/admin-guide/media/rkcif.rst
> @@ -77,3 +77,35 @@ and the following video devices:
>  .. kernel-figure:: rkcif-rk3568-vicap.dot
>      :alt:   Topology of the RK3568 Video Capture (VICAP) unit
>      :align: center
> +
> +Rockchip RK3588 Video Capture (VICAP)
> +-------------------------------------
> +
> +The RK3588 Video Capture (VICAP) unit features a digital video port and six
> +MIPI CSI-2 capture interfaces that can receive video data independently.
> +The DVP accepts parallel video data, BT.656 and BT.1120.
> +Since the BT.1120 protocol may feature more than one stream, the RK3568 VICAP

Nit, should this be RK3588 instead of RK3568?

> +DVP features four DMA engines that can capture different streams.
> +Similarly, the RK3588 VICAP MIPI CSI-2 receivers feature four DMA engines each
> +to handle different Virtual Channels (VCs).
> +
> +The rkcif driver represents this hardware variant by exposing the following
> +V4L2 subdevices:
> +
> +* dw-mipi-csi2rx fdd30000.csi: MIPI CSI-2 receiver connected to MIPI DPHY0
> +* dw-mipi-csi2rx fdd50000.csi: MIPI CSI-2 receiver connected to MIPI DPHY1
> +* rkcif-mipi2: INTERFACE/CROP block for the MIPI CSI-2 receiver connected to
> +  MIPI DPHY0
> +* rkcif-mipi4: INTERFACE/CROP block for the MIPI CSI-2 receiver connected to
> +  MIPI DPHY1
> +
> +and the following video devices:
> +
> +* rkcif-mipi2-id{0,1,2,3}: The DMA engines connected to the rkcif-mipi2
> +  INTERFACE/CROP block.
> +* rkcif-mipi4-id{0,1,2,3}: The DMA engines connected to the rkcif-mipi4
> +  INTERFACE/CROP block.
> +
> +.. kernel-figure:: rkcif-rk3588-vicap.dot
> +    :alt:   Topology of the RK3588 Video Capture (VICAP) unit
> +    :align: center