From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state
Date: Tue, 09 Jan 2018 14:22:45 +0100 [thread overview]
Message-ID: <ad09e651b944f56ddb167b20cd9995f6@agner.ch> (raw)
In-Reply-To: <20180109092232.GA26312@b29396-OptiPlex-7040>
On 2018-01-09 10:22, Dong Aisheng wrote:
> On Tue, Jan 02, 2018 at 05:42:17PM +0100, Stefan Agner wrote:
>> When the CPU is in ARM power off state the ARM architected
>> timers are stopped. The flag is already present in the higher
>> power WAIT mode.
>>
>> This allows to use the ARM generic timer on i.MX 6UL/6ULL SoC.
>> Without the flag the kernel freezes when the timer enters the
>> first time ARM power off mode.
>>
>> Cc: Anson Huang <anson.huang@nxp.com>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>
> It seems ok at my side.
> Did you meet the real issue? If yes, how to reproduce?
Enable the timer added with Patch 5, use a U-Boot with this patchset
applied:
https://www.mail-archive.com/u-boot at lists.denx.de/msg273287.html
And boot... For me it freezed somewhere early during systemd boot phase,
presumably the first time the CPU got into this idle mode.
--
Stefan
>
> Both mx6sx and mx6ul are using GPT which do not need that flag, suppose
> we should remove it, right?
> Anson can help confirm it.
>
> Regards
> Dong Aisheng
>
>> ---
>> arch/arm/mach-imx/cpuidle-imx6sx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-imx/cpuidle-imx6sx.c
>> index c5a5c3a70ab1..d0f14b761ff7 100644
>> --- a/arch/arm/mach-imx/cpuidle-imx6sx.c
>> +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c
>> @@ -89,6 +89,7 @@ static struct cpuidle_driver imx6sx_cpuidle_driver = {
>> */
>> .exit_latency = 300,
>> .target_residency = 500,
>> + .flags = CPUIDLE_FLAG_TIMER_STOP,
>> .enter = imx6sx_enter_wait,
>> .name = "LOW-POWER-IDLE",
>> .desc = "ARM power off",
>> --
>> 2.15.1
>>
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
To: Dong Aisheng <dongas86-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
fabio.estevam-3arQi8VN3Tc@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Anson Huang <anson.huang-3arQi8VN3Tc@public.gmane.org>,
linux-imx-3arQi8VN3Tc@public.gmane.org
Subject: Re: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state
Date: Tue, 09 Jan 2018 14:22:45 +0100 [thread overview]
Message-ID: <ad09e651b944f56ddb167b20cd9995f6@agner.ch> (raw)
In-Reply-To: <20180109092232.GA26312@b29396-OptiPlex-7040>
On 2018-01-09 10:22, Dong Aisheng wrote:
> On Tue, Jan 02, 2018 at 05:42:17PM +0100, Stefan Agner wrote:
>> When the CPU is in ARM power off state the ARM architected
>> timers are stopped. The flag is already present in the higher
>> power WAIT mode.
>>
>> This allows to use the ARM generic timer on i.MX 6UL/6ULL SoC.
>> Without the flag the kernel freezes when the timer enters the
>> first time ARM power off mode.
>>
>> Cc: Anson Huang <anson.huang-3arQi8VN3Tc@public.gmane.org>
>> Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
>
> It seems ok at my side.
> Did you meet the real issue? If yes, how to reproduce?
Enable the timer added with Patch 5, use a U-Boot with this patchset
applied:
https://www.mail-archive.com/u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org/msg273287.html
And boot... For me it freezed somewhere early during systemd boot phase,
presumably the first time the CPU got into this idle mode.
--
Stefan
>
> Both mx6sx and mx6ul are using GPT which do not need that flag, suppose
> we should remove it, right?
> Anson can help confirm it.
>
> Regards
> Dong Aisheng
>
>> ---
>> arch/arm/mach-imx/cpuidle-imx6sx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-imx/cpuidle-imx6sx.c
>> index c5a5c3a70ab1..d0f14b761ff7 100644
>> --- a/arch/arm/mach-imx/cpuidle-imx6sx.c
>> +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c
>> @@ -89,6 +89,7 @@ static struct cpuidle_driver imx6sx_cpuidle_driver = {
>> */
>> .exit_latency = 300,
>> .target_residency = 500,
>> + .flags = CPUIDLE_FLAG_TIMER_STOP,
>> .enter = imx6sx_enter_wait,
>> .name = "LOW-POWER-IDLE",
>> .desc = "ARM power off",
>> --
>> 2.15.1
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Agner <stefan@agner.ch>
To: Dong Aisheng <dongas86@gmail.com>
Cc: shawnguo@kernel.org, kernel@pengutronix.de,
fabio.estevam@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Anson Huang <anson.huang@nxp.com>,
linux-imx@nxp.com
Subject: Re: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state
Date: Tue, 09 Jan 2018 14:22:45 +0100 [thread overview]
Message-ID: <ad09e651b944f56ddb167b20cd9995f6@agner.ch> (raw)
In-Reply-To: <20180109092232.GA26312@b29396-OptiPlex-7040>
On 2018-01-09 10:22, Dong Aisheng wrote:
> On Tue, Jan 02, 2018 at 05:42:17PM +0100, Stefan Agner wrote:
>> When the CPU is in ARM power off state the ARM architected
>> timers are stopped. The flag is already present in the higher
>> power WAIT mode.
>>
>> This allows to use the ARM generic timer on i.MX 6UL/6ULL SoC.
>> Without the flag the kernel freezes when the timer enters the
>> first time ARM power off mode.
>>
>> Cc: Anson Huang <anson.huang@nxp.com>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>
> It seems ok at my side.
> Did you meet the real issue? If yes, how to reproduce?
Enable the timer added with Patch 5, use a U-Boot with this patchset
applied:
https://www.mail-archive.com/u-boot@lists.denx.de/msg273287.html
And boot... For me it freezed somewhere early during systemd boot phase,
presumably the first time the CPU got into this idle mode.
--
Stefan
>
> Both mx6sx and mx6ul are using GPT which do not need that flag, suppose
> we should remove it, right?
> Anson can help confirm it.
>
> Regards
> Dong Aisheng
>
>> ---
>> arch/arm/mach-imx/cpuidle-imx6sx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-imx/cpuidle-imx6sx.c
>> index c5a5c3a70ab1..d0f14b761ff7 100644
>> --- a/arch/arm/mach-imx/cpuidle-imx6sx.c
>> +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c
>> @@ -89,6 +89,7 @@ static struct cpuidle_driver imx6sx_cpuidle_driver = {
>> */
>> .exit_latency = 300,
>> .target_residency = 500,
>> + .flags = CPUIDLE_FLAG_TIMER_STOP,
>> .enter = imx6sx_enter_wait,
>> .name = "LOW-POWER-IDLE",
>> .desc = "ARM power off",
>> --
>> 2.15.1
>>
next prev parent reply other threads:[~2018-01-09 13:22 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 16:42 [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-05 16:45 ` Rob Herring
2018-01-05 16:45 ` Rob Herring
2018-01-06 10:47 ` Stefan Agner
2018-01-06 10:47 ` Stefan Agner
2018-01-08 1:37 ` Andy Duan
2018-01-08 1:37 ` Andy Duan
2018-01-08 1:37 ` Andy Duan
2018-01-09 9:24 ` Dong Aisheng
2018-01-09 9:24 ` Dong Aisheng
2018-01-02 16:42 ` [PATCH 3/7] ARM: dts: imx6ull: add additional pinfunc defines for i.MX 6ULL Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-05 16:49 ` Rob Herring
2018-01-05 16:49 ` Rob Herring
2018-01-05 16:49 ` Rob Herring
2018-01-07 9:52 ` Stefan Agner
2018-01-07 9:52 ` Stefan Agner
2018-01-07 9:52 ` Stefan Agner
2018-01-09 9:30 ` Dong Aisheng
2018-01-09 9:30 ` Dong Aisheng
2018-01-09 9:30 ` Dong Aisheng
2018-01-02 16:42 ` [PATCH 4/7] ARM: dts: imx6ul: add interrupt of virt-capable GIC Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` [PATCH 5/7] ARM: dts: imx6ul: add ARM architected timer Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-09 9:34 ` Dong Aisheng
2018-01-09 9:34 ` Dong Aisheng
2018-01-09 9:34 ` Dong Aisheng
2018-01-09 13:18 ` Stefan Agner
2018-01-09 13:18 ` Stefan Agner
2018-01-09 13:18 ` Stefan Agner
2018-01-02 16:42 ` [PATCH 6/7] ARM: dts: imx6ull: add IOMUXC SNVS instance Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-09 9:35 ` Dong Aisheng
2018-01-09 9:35 ` Dong Aisheng
2018-01-02 16:42 ` [PATCH 7/7] ARM: dts: imx6ull: add UART8 support Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-09 9:38 ` Dong Aisheng
2018-01-09 9:38 ` Dong Aisheng
2018-01-09 9:22 ` [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state Dong Aisheng
2018-01-09 9:22 ` Dong Aisheng
2018-01-09 9:22 ` Dong Aisheng
2018-01-09 9:25 ` Anson Huang
2018-01-09 9:25 ` Anson Huang
2018-01-09 10:13 ` Lucas Stach
2018-01-09 10:13 ` Lucas Stach
2018-01-09 13:37 ` Stefan Agner
2018-01-09 13:37 ` Stefan Agner
2018-01-09 13:37 ` Stefan Agner
2018-01-09 14:04 ` Lucas Stach
2018-01-09 14:04 ` Lucas Stach
2018-01-09 22:21 ` Stefan Agner
2018-01-09 22:21 ` Stefan Agner
2018-01-09 13:22 ` Stefan Agner [this message]
2018-01-09 13:22 ` Stefan Agner
2018-01-09 13:22 ` Stefan Agner
2018-01-10 17:48 ` Lucas Stach
2018-01-10 17:48 ` Lucas Stach
2018-01-10 17:48 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad09e651b944f56ddb167b20cd9995f6@agner.ch \
--to=stefan@agner.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.