From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state
Date: Tue, 09 Jan 2018 14:37:50 +0100 [thread overview]
Message-ID: <bacee8fe00b0ab54dfa6692bfc956ffd@agner.ch> (raw)
In-Reply-To: <1515492803.12538.29.camel@pengutronix.de>
On 2018-01-09 11:13, Lucas Stach wrote:
> Am Dienstag, den 09.01.2018, 09:25 +0000 schrieb Anson Huang:
>>
>> Best Regards!
>> Anson Huang
>>
>>
>> > -----Original Message-----
>> > From: Dong Aisheng [mailto:dongas86 at gmail.com]
>> > Sent: 2018-01-09 5:23 PM
>> > To: Stefan Agner <stefan@agner.ch>
>> > Cc: shawnguo at kernel.org; kernel at pengutronix.de; Fabio Estevam
>> > <fabio.estevam@nxp.com>; robh+dt at kernel.org; mark.rutland at arm.com;
>> > linux-arm-kernel at lists.infradead.org; devicetree at vger.kernel.org;
>> > linux-
>> > kernel at vger.kernel.org; Anson Huang <anson.huang@nxp.com>; dl-
>> > linux-imx
>> > <linux-imx@nxp.com>
>> > Subject: Re: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power
>> > off state
>> >
>> > On Tue, Jan 02, 2018 at 05:42:17PM +0100, Stefan Agner wrote:
>> > > When the CPU is in ARM power off state the ARM architected timers
>> > > are
>> > > stopped. The flag is already present in the higher power WAIT
>> > > mode.
>> > >
>> > > This allows to use the ARM generic timer on i.MX 6UL/6ULL SoC.
>> > > Without the flag the kernel freezes when the timer enters the
>> > > first
>> > > time ARM power off mode.
>> > >
>> > > Cc: Anson Huang <anson.huang@nxp.com>
>> > > Signed-off-by: Stefan Agner <stefan@agner.ch>
>> >
>> > It seems ok at my side.
>> > Did you meet the real issue? If yes, how to reproduce?
>> >
>> > Both mx6sx and mx6ul are using GPT which do not need that flag,
>> > suppose we
>> > should remove it, right?
>> > Anson can help confirm it.
>>
>> For UP system like i.MX6SX, we do NOT enable "cortex-a9-twd-timer",
>> so local
>> timer is NOT used, GPT is used instead, GPT's clock is NOT disabled
>> when cpuidle,
>> so I think we should remove all these Timer stop flag for 6SX
>> CPUIDLE.
>
> It's correct to set the flag even on UP systems, as the flag means the
> CPU _local_ timer is stopped in this sleep mode. Also there are systems
> out there which are using the TWD on UP, as it operates at a higher
> frequency leading to better wakeup granularity.
Documentation/devicetree/bindings/arm/twd.txt states that TWD provides
"per-cpu local timer". But as far as I can see TWD still uses SPI
interrupts, routed through GIC, so is this the differentiation?
--
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
To: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Anson Huang <anson.huang-3arQi8VN3Tc@public.gmane.org>,
Dong Aisheng <dongas86-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
dl-linux-imx <linux-imx-3arQi8VN3Tc@public.gmane.org>,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state
Date: Tue, 09 Jan 2018 14:37:50 +0100 [thread overview]
Message-ID: <bacee8fe00b0ab54dfa6692bfc956ffd@agner.ch> (raw)
In-Reply-To: <1515492803.12538.29.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On 2018-01-09 11:13, Lucas Stach wrote:
> Am Dienstag, den 09.01.2018, 09:25 +0000 schrieb Anson Huang:
>>
>> Best Regards!
>> Anson Huang
>>
>>
>> > -----Original Message-----
>> > From: Dong Aisheng [mailto:dongas86-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
>> > Sent: 2018-01-09 5:23 PM
>> > To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
>> > Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; Fabio Estevam
>> > <fabio.estevam-3arQi8VN3Tc@public.gmane.org>; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org;
>> > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
>> > linux-
>> > kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Anson Huang <anson.huang-3arQi8VN3Tc@public.gmane.org>; dl-
>> > linux-imx
>> > <linux-imx-3arQi8VN3Tc@public.gmane.org>
>> > Subject: Re: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power
>> > off state
>> >
>> > On Tue, Jan 02, 2018 at 05:42:17PM +0100, Stefan Agner wrote:
>> > > When the CPU is in ARM power off state the ARM architected timers
>> > > are
>> > > stopped. The flag is already present in the higher power WAIT
>> > > mode.
>> > >
>> > > This allows to use the ARM generic timer on i.MX 6UL/6ULL SoC.
>> > > Without the flag the kernel freezes when the timer enters the
>> > > first
>> > > time ARM power off mode.
>> > >
>> > > Cc: Anson Huang <anson.huang-3arQi8VN3Tc@public.gmane.org>
>> > > Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
>> >
>> > It seems ok at my side.
>> > Did you meet the real issue? If yes, how to reproduce?
>> >
>> > Both mx6sx and mx6ul are using GPT which do not need that flag,
>> > suppose we
>> > should remove it, right?
>> > Anson can help confirm it.
>>
>> For UP system like i.MX6SX, we do NOT enable "cortex-a9-twd-timer",
>> so local
>> timer is NOT used, GPT is used instead, GPT's clock is NOT disabled
>> when cpuidle,
>> so I think we should remove all these Timer stop flag for 6SX
>> CPUIDLE.
>
> It's correct to set the flag even on UP systems, as the flag means the
> CPU _local_ timer is stopped in this sleep mode. Also there are systems
> out there which are using the TWD on UP, as it operates at a higher
> frequency leading to better wakeup granularity.
Documentation/devicetree/bindings/arm/twd.txt states that TWD provides
"per-cpu local timer". But as far as I can see TWD still uses SPI
interrupts, routed through GIC, so is this the differentiation?
--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Agner <stefan@agner.ch>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Anson Huang <anson.huang@nxp.com>,
Dong Aisheng <dongas86@gmail.com>,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
dl-linux-imx <linux-imx@nxp.com>,
kernel@pengutronix.de, Fabio Estevam <fabio.estevam@nxp.com>,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state
Date: Tue, 09 Jan 2018 14:37:50 +0100 [thread overview]
Message-ID: <bacee8fe00b0ab54dfa6692bfc956ffd@agner.ch> (raw)
In-Reply-To: <1515492803.12538.29.camel@pengutronix.de>
On 2018-01-09 11:13, Lucas Stach wrote:
> Am Dienstag, den 09.01.2018, 09:25 +0000 schrieb Anson Huang:
>>
>> Best Regards!
>> Anson Huang
>>
>>
>> > -----Original Message-----
>> > From: Dong Aisheng [mailto:dongas86@gmail.com]
>> > Sent: 2018-01-09 5:23 PM
>> > To: Stefan Agner <stefan@agner.ch>
>> > Cc: shawnguo@kernel.org; kernel@pengutronix.de; Fabio Estevam
>> > <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com;
>> > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
>> > linux-
>> > kernel@vger.kernel.org; Anson Huang <anson.huang@nxp.com>; dl-
>> > linux-imx
>> > <linux-imx@nxp.com>
>> > Subject: Re: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power
>> > off state
>> >
>> > On Tue, Jan 02, 2018 at 05:42:17PM +0100, Stefan Agner wrote:
>> > > When the CPU is in ARM power off state the ARM architected timers
>> > > are
>> > > stopped. The flag is already present in the higher power WAIT
>> > > mode.
>> > >
>> > > This allows to use the ARM generic timer on i.MX 6UL/6ULL SoC.
>> > > Without the flag the kernel freezes when the timer enters the
>> > > first
>> > > time ARM power off mode.
>> > >
>> > > Cc: Anson Huang <anson.huang@nxp.com>
>> > > Signed-off-by: Stefan Agner <stefan@agner.ch>
>> >
>> > It seems ok at my side.
>> > Did you meet the real issue? If yes, how to reproduce?
>> >
>> > Both mx6sx and mx6ul are using GPT which do not need that flag,
>> > suppose we
>> > should remove it, right?
>> > Anson can help confirm it.
>>
>> For UP system like i.MX6SX, we do NOT enable "cortex-a9-twd-timer",
>> so local
>> timer is NOT used, GPT is used instead, GPT's clock is NOT disabled
>> when cpuidle,
>> so I think we should remove all these Timer stop flag for 6SX
>> CPUIDLE.
>
> It's correct to set the flag even on UP systems, as the flag means the
> CPU _local_ timer is stopped in this sleep mode. Also there are systems
> out there which are using the TWD on UP, as it operates at a higher
> frequency leading to better wakeup granularity.
Documentation/devicetree/bindings/arm/twd.txt states that TWD provides
"per-cpu local timer". But as far as I can see TWD still uses SPI
interrupts, routed through GIC, so is this the differentiation?
--
Stefan
next prev parent reply other threads:[~2018-01-09 13:37 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 16:42 [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-05 16:45 ` Rob Herring
2018-01-05 16:45 ` Rob Herring
2018-01-06 10:47 ` Stefan Agner
2018-01-06 10:47 ` Stefan Agner
2018-01-08 1:37 ` Andy Duan
2018-01-08 1:37 ` Andy Duan
2018-01-08 1:37 ` Andy Duan
2018-01-09 9:24 ` Dong Aisheng
2018-01-09 9:24 ` Dong Aisheng
2018-01-02 16:42 ` [PATCH 3/7] ARM: dts: imx6ull: add additional pinfunc defines for i.MX 6ULL Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-05 16:49 ` Rob Herring
2018-01-05 16:49 ` Rob Herring
2018-01-05 16:49 ` Rob Herring
2018-01-07 9:52 ` Stefan Agner
2018-01-07 9:52 ` Stefan Agner
2018-01-07 9:52 ` Stefan Agner
2018-01-09 9:30 ` Dong Aisheng
2018-01-09 9:30 ` Dong Aisheng
2018-01-09 9:30 ` Dong Aisheng
2018-01-02 16:42 ` [PATCH 4/7] ARM: dts: imx6ul: add interrupt of virt-capable GIC Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` [PATCH 5/7] ARM: dts: imx6ul: add ARM architected timer Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-09 9:34 ` Dong Aisheng
2018-01-09 9:34 ` Dong Aisheng
2018-01-09 9:34 ` Dong Aisheng
2018-01-09 13:18 ` Stefan Agner
2018-01-09 13:18 ` Stefan Agner
2018-01-09 13:18 ` Stefan Agner
2018-01-02 16:42 ` [PATCH 6/7] ARM: dts: imx6ull: add IOMUXC SNVS instance Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-09 9:35 ` Dong Aisheng
2018-01-09 9:35 ` Dong Aisheng
2018-01-02 16:42 ` [PATCH 7/7] ARM: dts: imx6ull: add UART8 support Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-02 16:42 ` Stefan Agner
2018-01-09 9:38 ` Dong Aisheng
2018-01-09 9:38 ` Dong Aisheng
2018-01-09 9:22 ` [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state Dong Aisheng
2018-01-09 9:22 ` Dong Aisheng
2018-01-09 9:22 ` Dong Aisheng
2018-01-09 9:25 ` Anson Huang
2018-01-09 9:25 ` Anson Huang
2018-01-09 10:13 ` Lucas Stach
2018-01-09 10:13 ` Lucas Stach
2018-01-09 13:37 ` Stefan Agner [this message]
2018-01-09 13:37 ` Stefan Agner
2018-01-09 13:37 ` Stefan Agner
2018-01-09 14:04 ` Lucas Stach
2018-01-09 14:04 ` Lucas Stach
2018-01-09 22:21 ` Stefan Agner
2018-01-09 22:21 ` Stefan Agner
2018-01-09 13:22 ` Stefan Agner
2018-01-09 13:22 ` Stefan Agner
2018-01-09 13:22 ` Stefan Agner
2018-01-10 17:48 ` Lucas Stach
2018-01-10 17:48 ` Lucas Stach
2018-01-10 17:48 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bacee8fe00b0ab54dfa6692bfc956ffd@agner.ch \
--to=stefan@agner.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.