All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: "Waskiewicz Jr\, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: "Rose\, Gregory V" <gregory.v.rose@intel.com>,
	"chavey\@google.com" <chavey@google.com>, "Kirsher\,
	Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
	"gospo\@redhat.com" <gospo@redhat.com>
Subject: Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module
Date: Thu, 10 Dec 2009 11:57:40 -0800	[thread overview]
Message-ID: <adamy1qlhzf.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <Pine.WNT.4.64.0912091743160.8780@ppwaskie-MOBL2.amr.corp.intel.com> (Waskiewicz Jr's message of "Wed, 9 Dec 2009 17:44:17 -0800 (Pacific Standard Time)")


 > > >+#ifdef CONFIG_PCI_IOV
 > > >+       /* disable iov and allow time for transactions to clear */
 > > >+       pci_disable_sriov(adapter->pdev);
 > > >+#endif
 > > >+       msleep(500);
 > > >
 > > >what is the sleep used for ?
 > > [Rose, Gregory V] 
 > > 
 > > It's mostly a safety valve to give plenty of time for all bus transactions to complete or time out.
 > 
 > I think Chavey is pointing out that if CONFIG_PCI_IOV is not enabled, 
 > you'd be sleeping for 500 msecs for no reason.  You should probably stick 
 > the msleep(500) inside the ifdef.

pci_disable_sriov() calls sriov_disable(), which already does
ssleep(1).  Do you really need another 500 msec of sleep after that 1000
msecs?  My impression of the PCI spec was that the 1 second wait is
supposed to be sufficient.

 - R.

  parent reply	other threads:[~2009-12-10 19:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10  1:15 [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module chavey
2009-12-10  1:40 ` Rose, Gregory V
2009-12-10  1:44   ` Waskiewicz Jr, Peter P
2009-12-10  1:53     ` Rose, Gregory V
2009-12-10 19:57     ` Roland Dreier [this message]
2009-12-10 20:02       ` Rose, Gregory V
  -- strict thread matches above, loose matches on Subject: below --
2009-12-08 22:13 [RFC PATCH 01/12] ixgbe: Mailbox header and code module Jeff Kirsher
2009-12-08 22:14 ` [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module Jeff Kirsher
2009-12-10  0:45   ` Simon Horman
2009-12-10  0:49     ` Rose, Gregory V
2009-12-10  1:04       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adamy1qlhzf.fsf@roland-alpha.cisco.com \
    --to=rdreier@cisco.com \
    --cc=chavey@google.com \
    --cc=gospo@redhat.com \
    --cc=gregory.v.rose@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.