* Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module
@ 2009-12-10 1:15 chavey
2009-12-10 1:40 ` Rose, Gregory V
0 siblings, 1 reply; 10+ messages in thread
From: chavey @ 2009-12-10 1:15 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose, peter.p.waskiewicz.jr
From: Greg Rose <gregory.v.rose@intel.com>
Adds SR-IOV features supported by the 82599 controller to the main driver
module. If the CONFIG_PCI_IOV kernel option is selected then the SR-IOV
features are enabled. Use the max_vfs module option to allocate up to 63
virtual functions per physical port.
Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
+static inline void ixgbe_disable_sriov(struct ixgbe_adapter *adapter)
+{
+ struct ixgbe_hw *hw = &adapter->hw;
+ u32 gcr;
+ u32 gpie;
+ u32 vmdctl;
+
+#ifdef CONFIG_PCI_IOV
+ /* disable iov and allow time for transactions to clear */
+ pci_disable_sriov(adapter->pdev);
+#endif
+ msleep(500);
what is the sleep used for ?
if this is to wait for pci_disable then add it
in the #ifdef above.
i s there a registerthat can be checked to ensure that
the device is in the expected state ? (similar to line 311 of
the orginal patch)
@@ -2269,6 +2376,20 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter)
}
IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc);
+ if (adapter->num_vfs) {
+ u32 reg;
+
+ /* Map PF MAC address in RAR Entry 0 to first pool
+ * following VFs */
+ hw->mac.ops.set_vmdq(hw, 0, adapter->num_vfs);
+
+ /* Set up VF register offsets for selected VT Mode, i.e.
+ * 64 VFs for SR-IOV */
+ reg = IXGBE_READ_REG(hw, IXGBE_GCR_EXT);
+ reg |= 0x80000003;
what is the significance of the 0x80000003 ?
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-10 1:15 [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module chavey @ 2009-12-10 1:40 ` Rose, Gregory V 2009-12-10 1:44 ` Waskiewicz Jr, Peter P 0 siblings, 1 reply; 10+ messages in thread From: Rose, Gregory V @ 2009-12-10 1:40 UTC (permalink / raw) To: chavey@google.com, Kirsher, Jeffrey T Cc: netdev@vger.kernel.org, gospo@redhat.com, Waskiewicz Jr, Peter P >-----Original Message----- >From: chavey@google.com [mailto:chavey@google.com] >Sent: Wednesday, December 09, 2009 5:15 PM >To: Kirsher, Jeffrey T >Cc: netdev@vger.kernel.org; gospo@redhat.com; Rose, Gregory V; >Waskiewicz Jr, Peter P >Subject: Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module > >From: Greg Rose <gregory.v.rose@intel.com> > >Adds SR-IOV features supported by the 82599 controller to the main >driver >module. If the CONFIG_PCI_IOV kernel option is selected then the SR-IOV >features are enabled. Use the max_vfs module option to allocate up to >63 >virtual functions per physical port. > >--- > >+static inline void ixgbe_disable_sriov(struct ixgbe_adapter *adapter) >+{ >+ struct ixgbe_hw *hw = &adapter->hw; >+ u32 gcr; >+ u32 gpie; >+ u32 vmdctl; >+ >+#ifdef CONFIG_PCI_IOV >+ /* disable iov and allow time for transactions to clear */ >+ pci_disable_sriov(adapter->pdev); >+#endif >+ msleep(500); > >what is the sleep used for ? [Rose, Gregory V] It's mostly a safety valve to give plenty of time for all bus transactions to complete or time out. >if this is to wait for pci_disable then add it >in the #ifdef above. >i s there a registerthat can be checked to ensure that >the device is in the expected state ? (similar to line 311 of >the orginal patch) [Rose, Gregory V] Not reliably. > > >@@ -2269,6 +2376,20 @@ static void ixgbe_configure_rx(struct >ixgbe_adapter *adapter) > } > IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc); > >+ if (adapter->num_vfs) { >+ u32 reg; >+ >+ /* Map PF MAC address in RAR Entry 0 to first pool >+ * following VFs */ >+ hw->mac.ops.set_vmdq(hw, 0, adapter->num_vfs); >+ >+ /* Set up VF register offsets for selected VT Mode, i.e. >+ * 64 VFs for SR-IOV */ >+ reg = IXGBE_READ_REG(hw, IXGBE_GCR_EXT); >+ reg |= 0x80000003; > >what is the significance of the 0x80000003 ? [Rose, Gregory V] Oh, a magic number. We'll fix that. In this case it's to set up the correct PCIe configuration on the device. - Greg ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-10 1:40 ` Rose, Gregory V @ 2009-12-10 1:44 ` Waskiewicz Jr, Peter P 2009-12-10 1:53 ` Rose, Gregory V 2009-12-10 19:57 ` Roland Dreier 0 siblings, 2 replies; 10+ messages in thread From: Waskiewicz Jr, Peter P @ 2009-12-10 1:44 UTC (permalink / raw) To: Rose, Gregory V Cc: chavey@google.com, Kirsher, Jeffrey T, netdev@vger.kernel.org, gospo@redhat.com, Waskiewicz Jr, Peter P On Wed, 9 Dec 2009, Rose, Gregory V wrote: > >-----Original Message----- > >From: chavey@google.com [mailto:chavey@google.com] > >Sent: Wednesday, December 09, 2009 5:15 PM > >To: Kirsher, Jeffrey T > >Cc: netdev@vger.kernel.org; gospo@redhat.com; Rose, Gregory V; > >Waskiewicz Jr, Peter P > >Subject: Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module > > > >From: Greg Rose <gregory.v.rose@intel.com> > > > >Adds SR-IOV features supported by the 82599 controller to the main > >driver > >module. If the CONFIG_PCI_IOV kernel option is selected then the SR-IOV > >features are enabled. Use the max_vfs module option to allocate up to > >63 > >virtual functions per physical port. > > > >--- > > > >+static inline void ixgbe_disable_sriov(struct ixgbe_adapter *adapter) > >+{ > >+ struct ixgbe_hw *hw = &adapter->hw; > >+ u32 gcr; > >+ u32 gpie; > >+ u32 vmdctl; > >+ > >+#ifdef CONFIG_PCI_IOV > >+ /* disable iov and allow time for transactions to clear */ > >+ pci_disable_sriov(adapter->pdev); > >+#endif > >+ msleep(500); > > > >what is the sleep used for ? > [Rose, Gregory V] > > It's mostly a safety valve to give plenty of time for all bus transactions to complete or time out. I think Chavey is pointing out that if CONFIG_PCI_IOV is not enabled, you'd be sleeping for 500 msecs for no reason. You should probably stick the msleep(500) inside the ifdef. -PJ > > >if this is to wait for pci_disable then add it > >in the #ifdef above. > >i s there a registerthat can be checked to ensure that > >the device is in the expected state ? (similar to line 311 of > >the orginal patch) > [Rose, Gregory V] > > Not reliably. > > > > > > >@@ -2269,6 +2376,20 @@ static void ixgbe_configure_rx(struct > >ixgbe_adapter *adapter) > > } > > IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc); > > > >+ if (adapter->num_vfs) { > >+ u32 reg; > >+ > >+ /* Map PF MAC address in RAR Entry 0 to first pool > >+ * following VFs */ > >+ hw->mac.ops.set_vmdq(hw, 0, adapter->num_vfs); > >+ > >+ /* Set up VF register offsets for selected VT Mode, i.e. > >+ * 64 VFs for SR-IOV */ > >+ reg = IXGBE_READ_REG(hw, IXGBE_GCR_EXT); > >+ reg |= 0x80000003; > > > >what is the significance of the 0x80000003 ? > > [Rose, Gregory V] > > Oh, a magic number. We'll fix that. > > In this case it's to set up the correct PCIe configuration on the device. > > - Greg > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-10 1:44 ` Waskiewicz Jr, Peter P @ 2009-12-10 1:53 ` Rose, Gregory V 2009-12-10 19:57 ` Roland Dreier 1 sibling, 0 replies; 10+ messages in thread From: Rose, Gregory V @ 2009-12-10 1:53 UTC (permalink / raw) To: Waskiewicz Jr, Peter P Cc: chavey@google.com, Kirsher, Jeffrey T, netdev@vger.kernel.org, gospo@redhat.com >-----Original Message----- >From: Waskiewicz Jr, Peter P >Sent: Wednesday, December 09, 2009 5:44 PM >To: Rose, Gregory V >Cc: chavey@google.com; Kirsher, Jeffrey T; netdev@vger.kernel.org; >gospo@redhat.com; Waskiewicz Jr, Peter P >Subject: RE: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module > >On Wed, 9 Dec 2009, Rose, Gregory V wrote: > >> >-----Original Message----- >> >From: chavey@google.com [mailto:chavey@google.com] [snippage] >> >+static inline void ixgbe_disable_sriov(struct ixgbe_adapter >*adapter) >> >+{ >> >+ struct ixgbe_hw *hw = &adapter->hw; >> >+ u32 gcr; >> >+ u32 gpie; >> >+ u32 vmdctl; >> >+ >> >+#ifdef CONFIG_PCI_IOV >> >+ /* disable iov and allow time for transactions to clear */ >> >+ pci_disable_sriov(adapter->pdev); >> >+#endif >> >+ msleep(500); >> > >> >what is the sleep used for ? >> [Rose, Gregory V] >> >> It's mostly a safety valve to give plenty of time for all bus >transactions to complete or time out. > >I think Chavey is pointing out that if CONFIG_PCI_IOV is not enabled, >you'd be sleeping for 500 msecs for no reason. You should probably >stick >the msleep(500) inside the ifdef. > >-PJ [Rose, Gregory V] Oh, missed that due to my preconceptions. My reading of the code is that this function should never be called unless SR-IOV was enabled in the first place (could be wrong of course). However, for code correctness and readability I agree that the msleep should be moved within the #ifdef. Added to my community comment notes. - Greg ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-10 1:44 ` Waskiewicz Jr, Peter P 2009-12-10 1:53 ` Rose, Gregory V @ 2009-12-10 19:57 ` Roland Dreier 2009-12-10 20:02 ` Rose, Gregory V 1 sibling, 1 reply; 10+ messages in thread From: Roland Dreier @ 2009-12-10 19:57 UTC (permalink / raw) To: Waskiewicz Jr, Peter P Cc: Rose, Gregory V, chavey@google.com, Kirsher, Jeffrey T, netdev@vger.kernel.org, gospo@redhat.com > > >+#ifdef CONFIG_PCI_IOV > > >+ /* disable iov and allow time for transactions to clear */ > > >+ pci_disable_sriov(adapter->pdev); > > >+#endif > > >+ msleep(500); > > > > > >what is the sleep used for ? > > [Rose, Gregory V] > > > > It's mostly a safety valve to give plenty of time for all bus transactions to complete or time out. > > I think Chavey is pointing out that if CONFIG_PCI_IOV is not enabled, > you'd be sleeping for 500 msecs for no reason. You should probably stick > the msleep(500) inside the ifdef. pci_disable_sriov() calls sriov_disable(), which already does ssleep(1). Do you really need another 500 msec of sleep after that 1000 msecs? My impression of the PCI spec was that the 1 second wait is supposed to be sufficient. - R. ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-10 19:57 ` Roland Dreier @ 2009-12-10 20:02 ` Rose, Gregory V 0 siblings, 0 replies; 10+ messages in thread From: Rose, Gregory V @ 2009-12-10 20:02 UTC (permalink / raw) To: Roland Dreier, Waskiewicz Jr, Peter P Cc: chavey@google.com, Kirsher, Jeffrey T, netdev@vger.kernel.org, gospo@redhat.com >-----Original Message----- >From: Roland Dreier [mailto:rdreier@cisco.com] >Sent: Thursday, December 10, 2009 11:58 AM >To: Waskiewicz Jr, Peter P >Cc: Rose, Gregory V; chavey@google.com; Kirsher, Jeffrey T; >netdev@vger.kernel.org; gospo@redhat.com >Subject: Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module > > > > > >+#ifdef CONFIG_PCI_IOV > > > >+ /* disable iov and allow time for transactions to clear */ > > > >+ pci_disable_sriov(adapter->pdev); > > > >+#endif > > > >+ msleep(500); > > > > > > > >what is the sleep used for ? > > > [Rose, Gregory V] > > > > > > It's mostly a safety valve to give plenty of time for all bus >transactions to complete or time out. > > > > I think Chavey is pointing out that if CONFIG_PCI_IOV is not enabled, > > you'd be sleeping for 500 msecs for no reason. You should probably >stick > > the msleep(500) inside the ifdef. > >pci_disable_sriov() calls sriov_disable(), which already does >ssleep(1). Do you really need another 500 msec of sleep after that 1000 >msecs? My impression of the PCI spec was that the 1 second wait is >supposed to be sufficient. [Rose, Gregory V] I think you're correct. I'll just pull the msleep(500) and do some local functional testing to make sure it doesn't cause any problems. If not then I'll remove it permanently. - Greg ^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC PATCH 01/12] ixgbe: Mailbox header and code module @ 2009-12-08 22:13 Jeff Kirsher 2009-12-08 22:14 ` [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module Jeff Kirsher 0 siblings, 1 reply; 10+ messages in thread From: Jeff Kirsher @ 2009-12-08 22:13 UTC (permalink / raw) To: netdev; +Cc: gospo, Greg Rose, Peter P Waskiewicz Jr, Jeff Kirsher From: Greg Rose <gregory.v.rose@intel.com> The 82599 virtual function device and the master 82599 physical function device implement a mailbox utility for communication between the devices using some SRAM scratch memory and a doorbell/answering mechanism enabled via interrupt and/or polling. This C module and accompanying header file implement the base functions for use of this feature. Signed-off-by: Greg Rose <gregory.v.rose@intel.com> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/ixgbe/ixgbe_mbx.c | 480 +++++++++++++++++++++++++++++++++++++++++ drivers/net/ixgbe/ixgbe_mbx.h | 96 ++++++++ 2 files changed, 576 insertions(+), 0 deletions(-) create mode 100644 drivers/net/ixgbe/ixgbe_mbx.c create mode 100644 drivers/net/ixgbe/ixgbe_mbx.h diff --git a/drivers/net/ixgbe/ixgbe_mbx.c b/drivers/net/ixgbe/ixgbe_mbx.c new file mode 100644 index 0000000..5cd5ae8 --- /dev/null +++ b/drivers/net/ixgbe/ixgbe_mbx.c @@ -0,0 +1,480 @@ +/******************************************************************************* + + Intel 10 Gigabit PCI Express Linux driver + Copyright(c) 1999 - 2009 Intel Corporation. + + This program is free software; you can redistribute it and/or modify it + under the terms and conditions of the GNU General Public License, + version 2, as published by the Free Software Foundation. + + This program is distributed in the hope it will be useful, but WITHOUT + ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + more details. + + You should have received a copy of the GNU General Public License along with + this program; if not, write to the Free Software Foundation, Inc., + 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. + + The full GNU General Public License is included in this distribution in + the file called "COPYING". + + Contact Information: + e1000-devel Mailing List <e1000-devel@lists.sourceforge.net> + Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497 + +*******************************************************************************/ + +#include <linux/pci.h> +#include <linux/delay.h> +#include "ixgbe_type.h" +#include "ixgbe_common.h" +#include "ixgbe_mbx.h" + +/** + * ixgbe_read_mbx - Reads a message from the mailbox + * @hw: pointer to the HW structure + * @msg: The message buffer + * @size: Length of buffer + * @mbx_id: id of mailbox to read + * + * returns SUCCESS if it successfuly read message from buffer + **/ +s32 ixgbe_read_mbx(struct ixgbe_hw *hw, u32 *msg, u16 size, u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + s32 ret_val = IXGBE_ERR_MBX; + + /* limit read to size of mailbox */ + if (size > mbx->size) + size = mbx->size; + + if (mbx->ops.read) + ret_val = mbx->ops.read(hw, msg, size, mbx_id); + + return ret_val; +} + +/** + * ixgbe_write_mbx - Write a message to the mailbox + * @hw: pointer to the HW structure + * @msg: The message buffer + * @size: Length of buffer + * @mbx_id: id of mailbox to write + * + * returns SUCCESS if it successfully copied message into the buffer + **/ +s32 ixgbe_write_mbx(struct ixgbe_hw *hw, u32 *msg, u16 size, u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + s32 ret_val = 0; + + if (size > mbx->size) + ret_val = IXGBE_ERR_MBX; + + else if (mbx->ops.write) + ret_val = mbx->ops.write(hw, msg, size, mbx_id); + + return ret_val; +} + +/** + * ixgbe_check_for_msg - checks to see if someone sent us mail + * @hw: pointer to the HW structure + * @mbx_id: id of mailbox to check + * + * returns SUCCESS if the Status bit was found or else ERR_MBX + **/ +s32 ixgbe_check_for_msg(struct ixgbe_hw *hw, u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + s32 ret_val = IXGBE_ERR_MBX; + + if (mbx->ops.check_for_msg) + ret_val = mbx->ops.check_for_msg(hw, mbx_id); + + return ret_val; +} + +/** + * ixgbe_check_for_ack - checks to see if someone sent us ACK + * @hw: pointer to the HW structure + * @mbx_id: id of mailbox to check + * + * returns SUCCESS if the Status bit was found or else ERR_MBX + **/ +s32 ixgbe_check_for_ack(struct ixgbe_hw *hw, u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + s32 ret_val = IXGBE_ERR_MBX; + + if (mbx->ops.check_for_ack) + ret_val = mbx->ops.check_for_ack(hw, mbx_id); + + return ret_val; +} + +/** + * ixgbe_check_for_rst - checks to see if other side has reset + * @hw: pointer to the HW structure + * @mbx_id: id of mailbox to check + * + * returns SUCCESS if the Status bit was found or else ERR_MBX + **/ +s32 ixgbe_check_for_rst(struct ixgbe_hw *hw, u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + s32 ret_val = IXGBE_ERR_MBX; + + if (mbx->ops.check_for_rst) + ret_val = mbx->ops.check_for_rst(hw, mbx_id); + + return ret_val; +} + +/** + * ixgbe_poll_for_msg - Wait for message notification + * @hw: pointer to the HW structure + * @mbx_id: id of mailbox to write + * + * returns SUCCESS if it successfully received a message notification + **/ +static s32 ixgbe_poll_for_msg(struct ixgbe_hw *hw, u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + int countdown = mbx->timeout; + + if (!countdown || !mbx->ops.check_for_msg) + goto out; + + while (countdown && mbx->ops.check_for_msg(hw, mbx_id)) { + countdown--; + if (!countdown) + break; + udelay(mbx->usec_delay); + } + + /* if we failed, all future posted messages fail until reset */ + if (!countdown) + mbx->timeout = 0; +out: + return countdown ? 0 : IXGBE_ERR_MBX; +} + +/** + * ixgbe_poll_for_ack - Wait for message acknowledgement + * @hw: pointer to the HW structure + * @mbx_id: id of mailbox to write + * + * returns SUCCESS if it successfully received a message acknowledgement + **/ +static s32 ixgbe_poll_for_ack(struct ixgbe_hw *hw, u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + int countdown = mbx->timeout; + + if (!countdown || !mbx->ops.check_for_ack) + goto out; + + while (countdown && mbx->ops.check_for_ack(hw, mbx_id)) { + countdown--; + if (!countdown) + break; + udelay(mbx->usec_delay); + } + + /* if we failed, all future posted messages fail until reset */ + if (!countdown) + mbx->timeout = 0; +out: + return countdown ? 0 : IXGBE_ERR_MBX; +} + +/** + * ixgbe_read_posted_mbx - Wait for message notification and receive message + * @hw: pointer to the HW structure + * @msg: The message buffer + * @size: Length of buffer + * @mbx_id: id of mailbox to write + * + * returns SUCCESS if it successfully received a message notification and + * copied it into the receive buffer. + **/ +s32 ixgbe_read_posted_mbx(struct ixgbe_hw *hw, u32 *msg, u16 size, u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + s32 ret_val = IXGBE_ERR_MBX; + + if (!mbx->ops.read) + goto out; + + ret_val = ixgbe_poll_for_msg(hw, mbx_id); + + /* if ack received read message, otherwise we timed out */ + if (!ret_val) + ret_val = mbx->ops.read(hw, msg, size, mbx_id); +out: + return ret_val; +} + +/** + * ixgbe_write_posted_mbx - Write a message to the mailbox, wait for ack + * @hw: pointer to the HW structure + * @msg: The message buffer + * @size: Length of buffer + * @mbx_id: id of mailbox to write + * + * returns SUCCESS if it successfully copied message into the buffer and + * received an ack to that message within delay * timeout period + **/ +s32 ixgbe_write_posted_mbx(struct ixgbe_hw *hw, u32 *msg, u16 size, + u16 mbx_id) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + s32 ret_val = IXGBE_ERR_MBX; + + /* exit if either we can't write or there isn't a defined timeout */ + if (!mbx->ops.write || !mbx->timeout) + goto out; + + /* send msg */ + ret_val = mbx->ops.write(hw, msg, size, mbx_id); + + /* if msg sent wait until we receive an ack */ + if (!ret_val) + ret_val = ixgbe_poll_for_ack(hw, mbx_id); +out: + return ret_val; +} + +/** + * ixgbe_init_mbx_ops_generic - Initialize MB function pointers + * @hw: pointer to the HW structure + * + * Setup the mailbox read and write message function pointers + **/ +void ixgbe_init_mbx_ops_generic(struct ixgbe_hw *hw) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + + mbx->ops.read_posted = ixgbe_read_posted_mbx; + mbx->ops.write_posted = ixgbe_write_posted_mbx; +} + +static s32 ixgbe_check_for_bit_pf(struct ixgbe_hw *hw, u32 mask, s32 index) +{ + u32 mbvficr = IXGBE_READ_REG(hw, IXGBE_MBVFICR(index)); + s32 ret_val = IXGBE_ERR_MBX; + + if (mbvficr & mask) { + ret_val = 0; + IXGBE_WRITE_REG(hw, IXGBE_MBVFICR(index), mask); + } + + return ret_val; +} + +/** + * ixgbe_check_for_msg_pf - checks to see if the VF has sent mail + * @hw: pointer to the HW structure + * @vf_number: the VF index + * + * returns SUCCESS if the VF has set the Status bit or else ERR_MBX + **/ +static s32 ixgbe_check_for_msg_pf(struct ixgbe_hw *hw, u16 vf_number) +{ + s32 ret_val = IXGBE_ERR_MBX; + s32 index = IXGBE_MBVFICR_INDEX(vf_number); + u32 vf_bit = vf_number % 16; + + if (!ixgbe_check_for_bit_pf(hw, IXGBE_MBVFICR_VFREQ_VF1 << vf_bit, + index)) { + ret_val = 0; + hw->mbx.stats.reqs++; + } + + return ret_val; +} + +/** + * ixgbe_check_for_ack_pf - checks to see if the VF has ACKed + * @hw: pointer to the HW structure + * @vf_number: the VF index + * + * returns SUCCESS if the VF has set the Status bit or else ERR_MBX + **/ +static s32 ixgbe_check_for_ack_pf(struct ixgbe_hw *hw, u16 vf_number) +{ + s32 ret_val = IXGBE_ERR_MBX; + s32 index = IXGBE_MBVFICR_INDEX(vf_number); + u32 vf_bit = vf_number % 16; + + if (!ixgbe_check_for_bit_pf(hw, IXGBE_MBVFICR_VFACK_VF1 << vf_bit, + index)) { + ret_val = 0; + hw->mbx.stats.acks++; + } + + return ret_val; +} + +/** + * ixgbe_check_for_rst_pf - checks to see if the VF has reset + * @hw: pointer to the HW structure + * @vf_number: the VF index + * + * returns SUCCESS if the VF has set the Status bit or else ERR_MBX + **/ +static s32 ixgbe_check_for_rst_pf(struct ixgbe_hw *hw, u16 vf_number) +{ + u32 reg_offset = (vf_number < 32) ? 0 : 1; + u32 vf_shift = vf_number % 32; + u32 vflre = 0; + s32 ret_val = IXGBE_ERR_MBX; + + if (hw->mac.type == ixgbe_mac_82599EB) + vflre = IXGBE_READ_REG(hw, IXGBE_VFLRE(reg_offset)); + + if (vflre & (1 << vf_shift)) { + ret_val = 0; + IXGBE_WRITE_REG(hw, IXGBE_VFLREC(reg_offset), (1 << vf_shift)); + hw->mbx.stats.rsts++; + } + + return ret_val; +} + +/** + * ixgbe_obtain_mbx_lock_pf - obtain mailbox lock + * @hw: pointer to the HW structure + * @vf_number: the VF index + * + * return SUCCESS if we obtained the mailbox lock + **/ +static s32 ixgbe_obtain_mbx_lock_pf(struct ixgbe_hw *hw, u16 vf_number) +{ + s32 ret_val = IXGBE_ERR_MBX; + u32 p2v_mailbox; + + /* Take ownership of the buffer */ + IXGBE_WRITE_REG(hw, IXGBE_PFMAILBOX(vf_number), IXGBE_PFMAILBOX_PFU); + + /* reserve mailbox for vf use */ + p2v_mailbox = IXGBE_READ_REG(hw, IXGBE_PFMAILBOX(vf_number)); + if (p2v_mailbox & IXGBE_PFMAILBOX_PFU) + ret_val = 0; + + return ret_val; +} + +/** + * ixgbe_write_mbx_pf - Places a message in the mailbox + * @hw: pointer to the HW structure + * @msg: The message buffer + * @size: Length of buffer + * @vf_number: the VF index + * + * returns SUCCESS if it successfully copied message into the buffer + **/ +static s32 ixgbe_write_mbx_pf(struct ixgbe_hw *hw, u32 *msg, u16 size, + u16 vf_number) +{ + s32 ret_val; + u16 i; + + /* lock the mailbox to prevent pf/vf race condition */ + ret_val = ixgbe_obtain_mbx_lock_pf(hw, vf_number); + if (ret_val) + goto out_no_write; + + /* flush msg and acks as we are overwriting the message buffer */ + ixgbe_check_for_msg_pf(hw, vf_number); + ixgbe_check_for_ack_pf(hw, vf_number); + + /* copy the caller specified message to the mailbox memory buffer */ + for (i = 0; i < size; i++) + IXGBE_WRITE_REG_ARRAY(hw, IXGBE_PFMBMEM(vf_number), i, msg[i]); + + /* Interrupt VF to tell it a message has been sent and release buffer*/ + IXGBE_WRITE_REG(hw, IXGBE_PFMAILBOX(vf_number), IXGBE_PFMAILBOX_STS); + + /* update stats */ + hw->mbx.stats.msgs_tx++; + +out_no_write: + return ret_val; + +} + +/** + * ixgbe_read_mbx_pf - Read a message from the mailbox + * @hw: pointer to the HW structure + * @msg: The message buffer + * @size: Length of buffer + * @vf_number: the VF index + * + * This function copies a message from the mailbox buffer to the caller's + * memory buffer. The presumption is that the caller knows that there was + * a message due to a VF request so no polling for message is needed. + **/ +static s32 ixgbe_read_mbx_pf(struct ixgbe_hw *hw, u32 *msg, u16 size, + u16 vf_number) +{ + s32 ret_val; + u16 i; + + /* lock the mailbox to prevent pf/vf race condition */ + ret_val = ixgbe_obtain_mbx_lock_pf(hw, vf_number); + if (ret_val) + goto out_no_read; + + /* copy the message to the mailbox memory buffer */ + for (i = 0; i < size; i++) + msg[i] = IXGBE_READ_REG_ARRAY(hw, IXGBE_PFMBMEM(vf_number), i); + + /* Acknowledge the message and release buffer */ + IXGBE_WRITE_REG(hw, IXGBE_PFMAILBOX(vf_number), IXGBE_PFMAILBOX_ACK); + + /* update stats */ + hw->mbx.stats.msgs_rx++; + +out_no_read: + return ret_val; +} + +/** + * ixgbe_init_mbx_params_pf - set initial values for pf mailbox + * @hw: pointer to the HW structure + * + * Initializes the hw->mbx struct to correct values for pf mailbox + */ +s32 ixgbe_init_mbx_params_pf(struct ixgbe_hw *hw) +{ + struct ixgbe_mbx_info *mbx = &hw->mbx; + + if (hw->mac.type == ixgbe_mac_82599EB) { + mbx->timeout = 0; + mbx->usec_delay = 0; + + mbx->size = IXGBE_VFMAILBOX_SIZE; + + mbx->stats.msgs_tx = 0; + mbx->stats.msgs_rx = 0; + mbx->stats.reqs = 0; + mbx->stats.acks = 0; + mbx->stats.rsts = 0; + } + + return 0; +} + +struct ixgbe_mbx_operations mbx_ops_82599 = { + .read = ixgbe_read_mbx_pf, + .write = ixgbe_write_mbx_pf, + .read_posted = ixgbe_read_posted_mbx, + .write_posted = ixgbe_write_posted_mbx, + .check_for_msg = ixgbe_check_for_msg_pf, + .check_for_ack = ixgbe_check_for_ack_pf, + .check_for_rst = ixgbe_check_for_rst_pf, +}; + diff --git a/drivers/net/ixgbe/ixgbe_mbx.h b/drivers/net/ixgbe/ixgbe_mbx.h new file mode 100644 index 0000000..5b3629b --- /dev/null +++ b/drivers/net/ixgbe/ixgbe_mbx.h @@ -0,0 +1,96 @@ +/******************************************************************************* + + Intel 10 Gigabit PCI Express Linux driver + Copyright(c) 1999 - 2009 Intel Corporation. + + This program is free software; you can redistribute it and/or modify it + under the terms and conditions of the GNU General Public License, + version 2, as published by the Free Software Foundation. + + This program is distributed in the hope it will be useful, but WITHOUT + ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + more details. + + You should have received a copy of the GNU General Public License along with + this program; if not, write to the Free Software Foundation, Inc., + 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. + + The full GNU General Public License is included in this distribution in + the file called "COPYING". + + Contact Information: + e1000-devel Mailing List <e1000-devel@lists.sourceforge.net> + Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497 + +*******************************************************************************/ + +#ifndef _IXGBE_MBX_H_ +#define _IXGBE_MBX_H_ + +#include "ixgbe_type.h" + +#define IXGBE_VFMAILBOX_SIZE 16 /* 16 32 bit words - 64 bytes */ +#define IXGBE_ERR_MBX -100 + +#define IXGBE_VFMAILBOX 0x002FC +#define IXGBE_VFMBMEM 0x00200 + +#define IXGBE_PFMAILBOX(x) (0x04B00 + (4 * x)) +#define IXGBE_PFMBMEM(vfn) (0x13000 + (64 * vfn)) + +#define IXGBE_PFMAILBOX_STS 0x00000001 /* Initiate message send to VF */ +#define IXGBE_PFMAILBOX_ACK 0x00000002 /* Ack message recv'd from VF */ +#define IXGBE_PFMAILBOX_VFU 0x00000004 /* VF owns the mailbox buffer */ +#define IXGBE_PFMAILBOX_PFU 0x00000008 /* PF owns the mailbox buffer */ +#define IXGBE_PFMAILBOX_RVFU 0x00000010 /* Reset VFU - used when VF stuck */ + +#define IXGBE_MBVFICR_VFREQ_MASK 0x0000FFFF /* bits for VF messages */ +#define IXGBE_MBVFICR_VFREQ_VF1 0x00000001 /* bit for VF 1 message */ +#define IXGBE_MBVFICR_VFACK_MASK 0xFFFF0000 /* bits for VF acks */ +#define IXGBE_MBVFICR_VFACK_VF1 0x00010000 /* bit for VF 1 ack */ + + +/* If it's a IXGBE_VF_* msg then it originates in the VF and is sent to the + * PF. The reverse is true if it is IXGBE_PF_*. + * Message ACK's are the value or'd with 0xF0000000 + */ +#define IXGBE_VT_MSGTYPE_ACK 0x80000000 /* Messages below or'd with + * this are the ACK */ +#define IXGBE_VT_MSGTYPE_NACK 0x40000000 /* Messages below or'd with + * this are the NACK */ +#define IXGBE_VT_MSGTYPE_CTS 0x20000000 /* Indicates that VF is still + clear to send requests */ +#define IXGBE_VT_MSGINFO_SHIFT 16 +/* bits 23:16 are used for exra info for certain messages */ +#define IXGBE_VT_MSGINFO_MASK (0xFF << IXGBE_VT_MSGINFO_SHIFT) + +#define IXGBE_VF_RESET 0x01 /* VF requests reset */ +#define IXGBE_VF_SET_MAC_ADDR 0x02 /* VF requests PF to set MAC addr */ +#define IXGBE_VF_SET_MULTICAST 0x03 /* VF requests PF to set MC addr */ +#define IXGBE_VF_SET_VLAN 0x04 /* VF requests PF to set VLAN */ +#define IXGBE_VF_SET_LPE 0x05 /* VF requests PF to set VMOLR.LPE */ + +/* length of permanent address message returned from PF */ +#define IXGBE_VF_PERMADDR_MSG_LEN 4 +/* word in permanent address message with the current multicast type */ +#define IXGBE_VF_MC_TYPE_WORD 3 + +#define IXGBE_PF_CONTROL_MSG 0x0100 /* PF control message */ + +#define IXGBE_VF_MBX_INIT_TIMEOUT 2000 /* number of retries on mailbox */ +#define IXGBE_VF_MBX_INIT_DELAY 500 /* microseconds between retries */ + +s32 ixgbe_read_mbx(struct ixgbe_hw *, u32 *, u16, u16); +s32 ixgbe_write_mbx(struct ixgbe_hw *, u32 *, u16, u16); +s32 ixgbe_read_posted_mbx(struct ixgbe_hw *, u32 *, u16, u16); +s32 ixgbe_write_posted_mbx(struct ixgbe_hw *, u32 *, u16, u16); +s32 ixgbe_check_for_msg(struct ixgbe_hw *, u16); +s32 ixgbe_check_for_ack(struct ixgbe_hw *, u16); +s32 ixgbe_check_for_rst(struct ixgbe_hw *, u16); +void ixgbe_init_mbx_ops_generic(struct ixgbe_hw *hw); +s32 ixgbe_init_mbx_params_pf(struct ixgbe_hw *); + +extern struct ixgbe_mbx_operations mbx_ops_82599; + +#endif /* _IXGBE_MBX_H_ */ ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-08 22:13 [RFC PATCH 01/12] ixgbe: Mailbox header and code module Jeff Kirsher @ 2009-12-08 22:14 ` Jeff Kirsher 2009-12-10 0:45 ` Simon Horman 0 siblings, 1 reply; 10+ messages in thread From: Jeff Kirsher @ 2009-12-08 22:14 UTC (permalink / raw) To: netdev; +Cc: gospo, Greg Rose, Peter P Waskiewicz Jr, Jeff Kirsher From: Greg Rose <gregory.v.rose@intel.com> Adds SR-IOV features supported by the 82599 controller to the main driver module. If the CONFIG_PCI_IOV kernel option is selected then the SR-IOV features are enabled. Use the max_vfs module option to allocate up to 63 virtual functions per physical port. Signed-off-by: Greg Rose <gregory.v.rose@intel.com> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/ixgbe/ixgbe_main.c | 270 ++++++++++++++++++++++++++++++++++++++-- 1 files changed, 259 insertions(+), 11 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 35ea8c9..0bde380 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -45,6 +45,7 @@ #include "ixgbe.h" #include "ixgbe_common.h" #include "ixgbe_dcb_82599.h" +#include "ixgbe_sriov.h" char ixgbe_driver_name[] = "ixgbe"; static const char ixgbe_driver_string[] = @@ -124,6 +125,13 @@ static struct notifier_block dca_notifier = { }; #endif +#ifdef CONFIG_PCI_IOV +static unsigned int max_vfs; +module_param(max_vfs, uint, 0); +MODULE_PARM_DESC(max_vfs, "Maximum number of virtual functions to allocate " + "per physical function"); +#endif /* CONFIG_PCI_IOV */ + MODULE_AUTHOR("Intel Corporation, <linux.nics@intel.com>"); MODULE_DESCRIPTION("Intel(R) 10 Gigabit PCI Express Network Driver"); MODULE_LICENSE("GPL"); @@ -131,6 +139,42 @@ MODULE_VERSION(DRV_VERSION); #define DEFAULT_DEBUG_LEVEL_SHIFT 3 +static inline void ixgbe_disable_sriov(struct ixgbe_adapter *adapter) +{ + struct ixgbe_hw *hw = &adapter->hw; + u32 gcr; + u32 gpie; + u32 vmdctl; + +#ifdef CONFIG_PCI_IOV + /* disable iov and allow time for transactions to clear */ + pci_disable_sriov(adapter->pdev); +#endif + msleep(500); + + /* turn off device IOV mode */ + gcr = IXGBE_READ_REG(hw, IXGBE_GCR_EXT); + gcr &= ~(0x80000003); + IXGBE_WRITE_REG(hw, IXGBE_GCR_EXT, gcr); + gpie = IXGBE_READ_REG(hw, IXGBE_GPIE); + gpie &= ~IXGBE_GPIE_VTMODE_MASK; + IXGBE_WRITE_REG(hw, IXGBE_GPIE, gpie); + + /* set default pool back to 0 */ + vmdctl = IXGBE_READ_REG(hw, IXGBE_VT_CTL); + vmdctl &= ~IXGBE_VT_CTL_POOL_MASK; + IXGBE_WRITE_REG(hw, IXGBE_VT_CTL, vmdctl); + + /* take a breather then clean up driver data */ + msleep(100); + if (adapter->vfinfo) + kfree(adapter->vfinfo); + adapter->vfinfo = NULL; + + adapter->num_vfs = 0; + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; +} + static void ixgbe_release_hw_control(struct ixgbe_adapter *adapter) { u32 ctrl_ext; @@ -1020,7 +1064,12 @@ static void ixgbe_configure_msix(struct ixgbe_adapter *adapter) /* set up to autoclear timer, and the vectors */ mask = IXGBE_EIMS_ENABLE_MASK; - mask &= ~(IXGBE_EIMS_OTHER | IXGBE_EIMS_LSC); + if (adapter->num_vfs) + mask &= ~(IXGBE_EIMS_OTHER | + IXGBE_EIMS_MAILBOX | + IXGBE_EIMS_LSC); + else + mask &= ~(IXGBE_EIMS_OTHER | IXGBE_EIMS_LSC); IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIAC, mask); } @@ -1249,6 +1298,9 @@ static irqreturn_t ixgbe_msix_lsc(int irq, void *data) if (eicr & IXGBE_EICR_LSC) ixgbe_check_lsc(adapter); + if (eicr & IXGBE_EICR_MAILBOX) + ixgbe_msg_task(adapter); + if (hw->mac.type == ixgbe_mac_82598EB) ixgbe_check_fan_failure(adapter, eicr); @@ -1763,6 +1815,8 @@ static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter) mask |= IXGBE_EIMS_ECC; mask |= IXGBE_EIMS_GPI_SDP1; mask |= IXGBE_EIMS_GPI_SDP2; + if (adapter->num_vfs) + mask |= IXGBE_EIMS_MAILBOX; } if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE || adapter->flags & IXGBE_FLAG_FDIR_PERFECT_CAPABLE) @@ -1771,6 +1825,11 @@ static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter) IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMS, mask); ixgbe_irq_enable_queues(adapter, ~0); IXGBE_WRITE_FLUSH(&adapter->hw); + + if (adapter->num_vfs > 32) { + u32 eitrsel = (1 << (adapter->num_vfs - 32)) - 1; + IXGBE_WRITE_REG(&adapter->hw, IXGBE_EITRSEL, eitrsel); + } } /** @@ -1900,6 +1959,8 @@ static inline void ixgbe_irq_disable(struct ixgbe_adapter *adapter) IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, 0xFFFF0000); IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC_EX(0), ~0); IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC_EX(1), ~0); + if (adapter->num_vfs > 32) + IXGBE_WRITE_REG(&adapter->hw, IXGBE_EITRSEL, 0); } IXGBE_WRITE_FLUSH(&adapter->hw); if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED) { @@ -1984,18 +2045,32 @@ static void ixgbe_configure_tx(struct ixgbe_adapter *adapter) if (hw->mac.type == ixgbe_mac_82599EB) { u32 rttdcs; + u32 mask; /* disable the arbiter while setting MTQC */ rttdcs = IXGBE_READ_REG(hw, IXGBE_RTTDCS); rttdcs |= IXGBE_RTTDCS_ARBDIS; IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, rttdcs); - /* We enable 8 traffic classes, DCB only */ - if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) - IXGBE_WRITE_REG(hw, IXGBE_MTQC, (IXGBE_MTQC_RT_ENA | - IXGBE_MTQC_8TC_8TQ)); - else + /* set transmit pool layout */ + mask = (IXGBE_FLAG_SRIOV_ENABLED | IXGBE_FLAG_DCB_ENABLED); + switch (adapter->flags & mask) { + + case (IXGBE_FLAG_SRIOV_ENABLED): + IXGBE_WRITE_REG(hw, IXGBE_MTQC, + (IXGBE_MTQC_VT_ENA | IXGBE_MTQC_64VF)); + break; + + case (IXGBE_FLAG_DCB_ENABLED): + /* We enable 8 traffic classes, DCB only */ + IXGBE_WRITE_REG(hw, IXGBE_MTQC, + (IXGBE_MTQC_RT_ENA | IXGBE_MTQC_8TC_8TQ)); + break; + + default: IXGBE_WRITE_REG(hw, IXGBE_MTQC, IXGBE_MTQC_64Q_1PB); + break; + } /* re-eable the arbiter */ rttdcs &= ~IXGBE_RTTDCS_ARBDIS; @@ -2054,12 +2129,16 @@ static u32 ixgbe_setup_mrqc(struct ixgbe_adapter *adapter) #ifdef CONFIG_IXGBE_DCB | IXGBE_FLAG_DCB_ENABLED #endif + | IXGBE_FLAG_SRIOV_ENABLED ); switch (mask) { case (IXGBE_FLAG_RSS_ENABLED): mrqc = IXGBE_MRQC_RSSEN; break; + case (IXGBE_FLAG_SRIOV_ENABLED): + mrqc = IXGBE_MRQC_VMDQEN; + break; #ifdef CONFIG_IXGBE_DCB case (IXGBE_FLAG_DCB_ENABLED): mrqc = IXGBE_MRQC_RT8TCEN; @@ -2140,7 +2219,9 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter) int rx_buf_len; /* Decide whether to use packet split mode or not */ - adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED; + /* Do not use packet split if we're in SR-IOV Mode */ + if (!adapter->num_vfs) + adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED; /* Set the RX buffer length according to the mode */ if (adapter->flags & IXGBE_FLAG_RX_PS_ENABLED) { @@ -2152,7 +2233,9 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter) IXGBE_PSRTYPE_IPV4HDR | IXGBE_PSRTYPE_IPV6HDR | IXGBE_PSRTYPE_L2HDR; - IXGBE_WRITE_REG(hw, IXGBE_PSRTYPE(0), psrtype); + IXGBE_WRITE_REG(hw, + IXGBE_PSRTYPE(adapter->num_vfs), + psrtype); } } else { if (!(adapter->flags2 & IXGBE_FLAG2_RSC_ENABLED) && @@ -2238,6 +2321,30 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter) IXGBE_WRITE_REG(hw, IXGBE_RDRXCTL, rdrxctl); } + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) { + u32 vt_reg_bits; + u32 reg_offset, vf_shift; + u32 vmdctl = IXGBE_READ_REG(hw, IXGBE_VT_CTL); + vt_reg_bits = IXGBE_VMD_CTL_VMDQ_EN + | IXGBE_VT_CTL_REPLEN; + vt_reg_bits |= (adapter->num_vfs << + IXGBE_VT_CTL_POOL_SHIFT); + IXGBE_WRITE_REG(hw, IXGBE_VT_CTL, vmdctl | vt_reg_bits); + IXGBE_WRITE_REG(hw, IXGBE_MRQC, 0); + + vf_shift = adapter->num_vfs % 32; + reg_offset = adapter->num_vfs / 32; + IXGBE_WRITE_REG(hw, IXGBE_VFRE(0), 0); + IXGBE_WRITE_REG(hw, IXGBE_VFRE(1), 0); + IXGBE_WRITE_REG(hw, IXGBE_VFTE(0), 0); + IXGBE_WRITE_REG(hw, IXGBE_VFTE(1), 0); + /* Enable only the PF's pool for Tx/Rx */ + IXGBE_WRITE_REG(hw, IXGBE_VFRE(reg_offset), (1 << vf_shift)); + IXGBE_WRITE_REG(hw, IXGBE_VFTE(reg_offset), (1 << vf_shift)); + IXGBE_WRITE_REG(hw, IXGBE_PFDTXGSWC, IXGBE_PFDTXGSWC_VT_LBEN); + ixgbe_set_vmolr(hw, adapter->num_vfs); + } + /* Program MRQC for the distribution of queues */ mrqc = ixgbe_setup_mrqc(adapter); @@ -2269,6 +2376,20 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter) } IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc); + if (adapter->num_vfs) { + u32 reg; + + /* Map PF MAC address in RAR Entry 0 to first pool + * following VFs */ + hw->mac.ops.set_vmdq(hw, 0, adapter->num_vfs); + + /* Set up VF register offsets for selected VT Mode, i.e. + * 64 VFs for SR-IOV */ + reg = IXGBE_READ_REG(hw, IXGBE_GCR_EXT); + reg |= 0x80000003; + IXGBE_WRITE_REG(hw, IXGBE_GCR_EXT, reg); + } + rxcsum = IXGBE_READ_REG(hw, IXGBE_RXCSUM); if (adapter->flags & IXGBE_FLAG_RSS_ENABLED || @@ -2409,7 +2530,7 @@ static u8 *ixgbe_addr_list_itr(struct ixgbe_hw *hw, u8 **mc_addr_ptr, u32 *vmdq) * responsible for configuring the hardware for proper unicast, multicast and * promiscuous mode. **/ -static void ixgbe_set_rx_mode(struct net_device *netdev) +void ixgbe_set_rx_mode(struct net_device *netdev) { struct ixgbe_adapter *adapter = netdev_priv(netdev); struct ixgbe_hw *hw = &adapter->hw; @@ -2449,6 +2570,8 @@ static void ixgbe_set_rx_mode(struct net_device *netdev) addr_list = netdev->mc_list->dmi_addr; hw->mac.ops.update_mc_addr_list(hw, addr_list, addr_count, ixgbe_addr_list_itr); + if (adapter->num_vfs) + ixgbe_restore_vf_multicasts(adapter); } static void ixgbe_napi_enable_all(struct ixgbe_adapter *adapter) @@ -2709,6 +2832,10 @@ static int ixgbe_up_complete(struct ixgbe_adapter *adapter) /* MSI only */ gpie = 0; } + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) { + gpie &= ~IXGBE_GPIE_VTMODE_MASK; + gpie |= IXGBE_GPIE_VTMODE_64; + } /* XXX: to interrupt immediately for EICS writes, enable this */ /* gpie |= IXGBE_GPIE_EIMEN; */ IXGBE_WRITE_REG(hw, IXGBE_GPIE, gpie); @@ -2783,6 +2910,18 @@ static int ixgbe_up_complete(struct ixgbe_adapter *adapter) txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(j)); txdctl |= IXGBE_TXDCTL_ENABLE; IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(j), txdctl); + if (hw->mac.type == ixgbe_mac_82599EB) { + int wait_loop = 10; + /* poll for Tx Enable ready */ + do { + msleep(1); + txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(j)); + } while (--wait_loop && + !(txdctl & IXGBE_TXDCTL_ENABLE)); + if (!wait_loop) + DPRINTK(DRV, ERR, "Could not enable " + "Tx Queue %d\n", j); + } } for (i = 0; i < num_rx_rings; i++) { @@ -2918,7 +3057,8 @@ void ixgbe_reset(struct ixgbe_adapter *adapter) } /* reprogram the RAR[0] in case user changed it. */ - hw->mac.ops.set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV); + hw->mac.ops.set_rar(hw, 0, hw->mac.addr, adapter->num_vfs, + IXGBE_RAH_AV); } /** @@ -3286,6 +3426,19 @@ static inline bool ixgbe_set_fcoe_queues(struct ixgbe_adapter *adapter) } #endif /* IXGBE_FCOE */ +/** + * ixgbe_set_sriov_queues: Allocate queues for IOV use + * @adapter: board private structure to initialize + * + * IOV doesn't actually use anything, so just NAK the + * request for now and let the other queue routines + * figure out what to do. + */ +static inline bool ixgbe_set_sriov_queues(struct ixgbe_adapter *adapter) +{ + return false; +} + /* * ixgbe_set_num_queues: Allocate queues for device, feature dependant * @adapter: board private structure to initialize @@ -3299,6 +3452,15 @@ static inline bool ixgbe_set_fcoe_queues(struct ixgbe_adapter *adapter) **/ static void ixgbe_set_num_queues(struct ixgbe_adapter *adapter) { + /* Start with base case */ + adapter->num_rx_queues = 1; + adapter->num_tx_queues = 1; + adapter->num_rx_pools = adapter->num_rx_queues; + adapter->num_rx_queues_per_pool = 1; + + if (ixgbe_set_sriov_queues(adapter)) + return; + #ifdef IXGBE_FCOE if (ixgbe_set_fcoe_queues(adapter)) goto done; @@ -3570,6 +3732,24 @@ static inline bool ixgbe_cache_ring_fcoe(struct ixgbe_adapter *adapter) #endif /* IXGBE_FCOE */ /** + * ixgbe_cache_ring_sriov - Descriptor ring to register mapping for sriov + * @adapter: board private structure to initialize + * + * SR-IOV doesn't use any descriptor rings but changes the default if + * no other mapping is used. + * + */ +static inline bool ixgbe_cache_ring_sriov(struct ixgbe_adapter *adapter) +{ + adapter->rx_ring[0].reg_idx = adapter->num_vfs * 2; + adapter->tx_ring[0].reg_idx = adapter->num_vfs * 2; + if (adapter->num_vfs) + return true; + else + return false; +} + +/** * ixgbe_cache_ring_register - Descriptor ring to register mapping * @adapter: board private structure to initialize * @@ -3586,6 +3766,9 @@ static void ixgbe_cache_ring_register(struct ixgbe_adapter *adapter) adapter->rx_ring[0].reg_idx = 0; adapter->tx_ring[0].reg_idx = 0; + if (ixgbe_cache_ring_sriov(adapter)) + return; + #ifdef IXGBE_FCOE if (ixgbe_cache_ring_fcoe(adapter)) return; @@ -3695,6 +3878,9 @@ static int ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter) adapter->flags &= ~IXGBE_FLAG_FDIR_HASH_CAPABLE; adapter->flags &= ~IXGBE_FLAG_FDIR_PERFECT_CAPABLE; adapter->atr_sample_rate = 0; + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) + ixgbe_disable_sriov(adapter); + ixgbe_set_num_queues(adapter); err = pci_enable_msi(adapter->pdev); @@ -5460,7 +5646,8 @@ static int ixgbe_set_mac(struct net_device *netdev, void *p) memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); memcpy(hw->mac.addr, addr->sa_data, netdev->addr_len); - hw->mac.ops.set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV); + hw->mac.ops.set_rar(hw, 0, hw->mac.addr, adapter->num_vfs, + IXGBE_RAH_AV); return 0; } @@ -5767,6 +5954,52 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev, goto err_sw_init; } +#ifdef CONFIG_PCI_IOV + if (hw->mac.type == ixgbe_mac_82599EB) { + /* The 82599 supports up to 64 VFs per physical function + * but this implementation limits allocation to 63 so that + * basic networking resources are still available to the + * physical function + */ + adapter->num_vfs = (max_vfs > 63) ? 63 : max_vfs; + if (adapter->num_vfs) { + adapter->flags |= IXGBE_FLAG_SRIOV_ENABLED; + err = pci_enable_sriov(pdev, adapter->num_vfs); + if (err) { + DPRINTK(PROBE, ERR, + "Failed to enable PCI sriov: %d\n", + err); + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; + adapter->num_vfs = 0; + } + } + /* If call to enable VFs succeeded then allocate memory + * for per VF control structures. + */ + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) { + adapter->vfinfo = + kcalloc(adapter->num_vfs, + sizeof(struct vf_data_storage), + GFP_KERNEL); + if (!adapter->vfinfo) { + /* Oh oh */ + DPRINTK(PROBE, ERR, + "Unable to allocate memory for VF " + "Data Storage - SRIOV disabled\n"); + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; + adapter->num_vfs = 0; + } else { + /* Now that we're sure SR-IOV is enabled + * set up the mailbox parameters + */ + ixgbe_init_mbx_params_pf(hw); + memcpy(&hw->mbx.ops, ii->mbx_ops, + sizeof(hw->mbx.ops)); + } + } + } + +#endif /* CONFIG_PCI_IOV */ netdev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX | @@ -5787,6 +6020,9 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev, netdev->vlan_features |= NETIF_F_IPV6_CSUM; netdev->vlan_features |= NETIF_F_SG; + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) + adapter->flags &= ~(IXGBE_FLAG_RSS_ENABLED | + IXGBE_FLAG_DCB_ENABLED); if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) adapter->flags &= ~IXGBE_FLAG_RSS_ENABLED; @@ -5913,6 +6149,13 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev, ixgbe_setup_dca(adapter); } #endif + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) { + DPRINTK(PROBE, INFO, "IOV is enabled with %d VFs\n", + adapter->num_vfs); + for (i = 0; i < adapter->num_vfs; i++) + ixgbe_vf_configuration(pdev, (i | 0x10000000)); + } + /* add san mac addr to netdev */ ixgbe_add_sanmac_netdev(netdev); @@ -5925,6 +6168,8 @@ err_register: ixgbe_clear_interrupt_scheme(adapter); err_sw_init: err_eeprom: + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) + ixgbe_disable_sriov(adapter); clear_bit(__IXGBE_SFP_MODULE_NOT_FOUND, &adapter->state); del_timer_sync(&adapter->sfp_timer); cancel_work_sync(&adapter->sfp_task); @@ -5993,6 +6238,9 @@ static void __devexit ixgbe_remove(struct pci_dev *pdev) if (netdev->reg_state == NETREG_REGISTERED) unregister_netdev(netdev); + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) + ixgbe_disable_sriov(adapter); + ixgbe_clear_interrupt_scheme(adapter); ixgbe_release_hw_control(adapter); ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-08 22:14 ` [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module Jeff Kirsher @ 2009-12-10 0:45 ` Simon Horman 2009-12-10 0:49 ` Rose, Gregory V 0 siblings, 1 reply; 10+ messages in thread From: Simon Horman @ 2009-12-10 0:45 UTC (permalink / raw) To: Jeff Kirsher; +Cc: netdev, gospo, Greg Rose, Peter P Waskiewicz Jr On Tue, Dec 08, 2009 at 02:14:36PM -0800, Jeff Kirsher wrote: > From: Greg Rose <gregory.v.rose@intel.com> > > Adds SR-IOV features supported by the 82599 controller to the main driver > module. If the CONFIG_PCI_IOV kernel option is selected then the SR-IOV > features are enabled. Use the max_vfs module option to allocate up to 63 > virtual functions per physical port. > > Signed-off-by: Greg Rose <gregory.v.rose@intel.com> > Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > --- > > drivers/net/ixgbe/ixgbe_main.c | 270 ++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 259 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c > index 35ea8c9..0bde380 100644 [snip] > @@ -5767,6 +5954,52 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev, > goto err_sw_init; > } > > +#ifdef CONFIG_PCI_IOV > + if (hw->mac.type == ixgbe_mac_82599EB) { > + /* The 82599 supports up to 64 VFs per physical function > + * but this implementation limits allocation to 63 so that > + * basic networking resources are still available to the > + * physical function > + */ > + adapter->num_vfs = (max_vfs > 63) ? 63 : max_vfs; > + if (adapter->num_vfs) { > + adapter->flags |= IXGBE_FLAG_SRIOV_ENABLED; > + err = pci_enable_sriov(pdev, adapter->num_vfs); > + if (err) { > + DPRINTK(PROBE, ERR, > + "Failed to enable PCI sriov: %d\n", > + err); > + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; > + adapter->num_vfs = 0; > + } > + } > + /* If call to enable VFs succeeded then allocate memory > + * for per VF control structures. > + */ > + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) { > + adapter->vfinfo = > + kcalloc(adapter->num_vfs, > + sizeof(struct vf_data_storage), > + GFP_KERNEL); > + if (!adapter->vfinfo) { > + /* Oh oh */ > + DPRINTK(PROBE, ERR, > + "Unable to allocate memory for VF " > + "Data Storage - SRIOV disabled\n"); > + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; > + adapter->num_vfs = 0; A call to pci_disable_sriov(pdev) is needed here? > + } else { > + /* Now that we're sure SR-IOV is enabled > + * set up the mailbox parameters > + */ > + ixgbe_init_mbx_params_pf(hw); > + memcpy(&hw->mbx.ops, ii->mbx_ops, > + sizeof(hw->mbx.ops)); > + } > + } > + } > + > +#endif /* CONFIG_PCI_IOV */ > netdev->features = NETIF_F_SG | > NETIF_F_IP_CSUM | > NETIF_F_HW_VLAN_TX | I wonder if it would be easier on the eyes to break the hunk above out into a ixgbe_probe_vf() function. Something like (compile tested only, I don't have an 82599): static void ixgbe_probe_vf(struct ixgbe_adapter *adapter, const struct ixgbe_info *ii) { #ifdef CONFIG_PCI_IOV struct ixgbe_hw *hw = &adapter->hw; int err; if (hw->mac.type != ixgbe_mac_82599EB || !max_vfs) return; /* The 82599 supports up to 64 VFs per physical function * but this implementation limits allocation to 63 so that * basic networking resources are still available to the * physical function */ adapter->num_vfs = (max_vfs > 63) ? 63 : max_vfs; adapter->flags |= IXGBE_FLAG_SRIOV_ENABLED; err = pci_enable_sriov(adapter->pdev, adapter->num_vfs); if (err) { DPRINTK(PROBE, ERR, "Failed to enable PCI sriov: %d\n", err); goto err_novf; } adapter->vfinfo = kcalloc(adapter->num_vfs, sizeof(struct vf_data_storage), GFP_KERNEL); if (!adapter->vfinfo) { /* Oh oh */ DPRINTK(PROBE, ERR, "Unable to allocate memory for VF " "Data Storage - SRIOV disabled\n"); goto err_sriov; } /* Now that we're sure SR-IOV is enabled * set up the mailbox parameters */ ixgbe_init_mbx_params_pf(hw); memcpy(&hw->mbx.ops, ii->mbx_ops, sizeof(hw->mbx.ops)); return; err_sriov: pci_disable_sriov(adapter->pdev); err_novf: adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; adapter->num_vfs = 0; return; #endif /* CONFIG_PCI_IOV */ ; } ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-10 0:45 ` Simon Horman @ 2009-12-10 0:49 ` Rose, Gregory V 2009-12-10 1:04 ` Simon Horman 0 siblings, 1 reply; 10+ messages in thread From: Rose, Gregory V @ 2009-12-10 0:49 UTC (permalink / raw) To: Simon Horman, Kirsher, Jeffrey T Cc: netdev@vger.kernel.org, gospo@redhat.com, Waskiewicz Jr, Peter P >-----Original Message----- >From: Simon Horman [mailto:horms@verge.net.au] >Sent: Wednesday, December 09, 2009 4:46 PM >To: Kirsher, Jeffrey T >Cc: netdev@vger.kernel.org; gospo@redhat.com; Rose, Gregory V; >Waskiewicz Jr, Peter P >Subject: Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module > >> @@ -5767,6 +5954,52 @@ static int __devinit ixgbe_probe(struct pci_dev >*pdev, >> goto err_sw_init; >> } >> >> +#ifdef CONFIG_PCI_IOV >> + if (hw->mac.type == ixgbe_mac_82599EB) { >> + /* The 82599 supports up to 64 VFs per physical function >> + * but this implementation limits allocation to 63 so that >> + * basic networking resources are still available to the >> + * physical function >> + */ >> + adapter->num_vfs = (max_vfs > 63) ? 63 : max_vfs; >> + if (adapter->num_vfs) { >> + adapter->flags |= IXGBE_FLAG_SRIOV_ENABLED; >> + err = pci_enable_sriov(pdev, adapter->num_vfs); >> + if (err) { >> + DPRINTK(PROBE, ERR, >> + "Failed to enable PCI sriov: %d\n", >> + err); >> + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; >> + adapter->num_vfs = 0; >> + } >> + } >> + /* If call to enable VFs succeeded then allocate memory >> + * for per VF control structures. >> + */ >> + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) { >> + adapter->vfinfo = >> + kcalloc(adapter->num_vfs, >> + sizeof(struct vf_data_storage), >> + GFP_KERNEL); >> + if (!adapter->vfinfo) { >> + /* Oh oh */ >> + DPRINTK(PROBE, ERR, >> + "Unable to allocate memory for VF " >> + "Data Storage - SRIOV disabled\n"); >> + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; >> + adapter->num_vfs = 0; > >A call to pci_disable_sriov(pdev) is needed here? [Rose, Gregory V] Good catch. > >> + } else { >> + /* Now that we're sure SR-IOV is enabled >> + * set up the mailbox parameters >> + */ >> + ixgbe_init_mbx_params_pf(hw); >> + memcpy(&hw->mbx.ops, ii->mbx_ops, >> + sizeof(hw->mbx.ops)); >> + } >> + } >> + } >> + >> +#endif /* CONFIG_PCI_IOV */ >> netdev->features = NETIF_F_SG | >> NETIF_F_IP_CSUM | >> NETIF_F_HW_VLAN_TX | > >I wonder if it would be easier on the eyes to break the hunk above out >into >a ixgbe_probe_vf() function. Something like (compile tested only, I >don't >have an 82599): [Rose, Gregory V] I think that was done with the igb driver. It's a good suggestion. - Greg ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module 2009-12-10 0:49 ` Rose, Gregory V @ 2009-12-10 1:04 ` Simon Horman 0 siblings, 0 replies; 10+ messages in thread From: Simon Horman @ 2009-12-10 1:04 UTC (permalink / raw) To: Rose, Gregory V Cc: Kirsher, Jeffrey T, netdev@vger.kernel.org, gospo@redhat.com, Waskiewicz Jr, Peter P On Wed, Dec 09, 2009 at 04:49:26PM -0800, Rose, Gregory V wrote: > >-----Original Message----- > >From: Simon Horman [mailto:horms@verge.net.au] > >Sent: Wednesday, December 09, 2009 4:46 PM > >To: Kirsher, Jeffrey T > >Cc: netdev@vger.kernel.org; gospo@redhat.com; Rose, Gregory V; > >Waskiewicz Jr, Peter P > >Subject: Re: [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module > > > >> @@ -5767,6 +5954,52 @@ static int __devinit ixgbe_probe(struct pci_dev > >*pdev, > >> goto err_sw_init; > >> } > >> > >> +#ifdef CONFIG_PCI_IOV > >> + if (hw->mac.type == ixgbe_mac_82599EB) { > >> + /* The 82599 supports up to 64 VFs per physical function > >> + * but this implementation limits allocation to 63 so that > >> + * basic networking resources are still available to the > >> + * physical function > >> + */ > >> + adapter->num_vfs = (max_vfs > 63) ? 63 : max_vfs; > >> + if (adapter->num_vfs) { > >> + adapter->flags |= IXGBE_FLAG_SRIOV_ENABLED; > >> + err = pci_enable_sriov(pdev, adapter->num_vfs); > >> + if (err) { > >> + DPRINTK(PROBE, ERR, > >> + "Failed to enable PCI sriov: %d\n", > >> + err); > >> + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; > >> + adapter->num_vfs = 0; > >> + } > >> + } > >> + /* If call to enable VFs succeeded then allocate memory > >> + * for per VF control structures. > >> + */ > >> + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) { > >> + adapter->vfinfo = > >> + kcalloc(adapter->num_vfs, > >> + sizeof(struct vf_data_storage), > >> + GFP_KERNEL); > >> + if (!adapter->vfinfo) { > >> + /* Oh oh */ > >> + DPRINTK(PROBE, ERR, > >> + "Unable to allocate memory for VF " > >> + "Data Storage - SRIOV disabled\n"); > >> + adapter->flags &= ~IXGBE_FLAG_SRIOV_ENABLED; > >> + adapter->num_vfs = 0; > > > >A call to pci_disable_sriov(pdev) is needed here? > [Rose, Gregory V] > > Good catch. Thanks. Actually I only noticed while doing the error paths for my suggestion below. > >> + } else { > >> + /* Now that we're sure SR-IOV is enabled > >> + * set up the mailbox parameters > >> + */ > >> + ixgbe_init_mbx_params_pf(hw); > >> + memcpy(&hw->mbx.ops, ii->mbx_ops, > >> + sizeof(hw->mbx.ops)); > >> + } > >> + } > >> + } > >> + > >> +#endif /* CONFIG_PCI_IOV */ > >> netdev->features = NETIF_F_SG | > >> NETIF_F_IP_CSUM | > >> NETIF_F_HW_VLAN_TX | > > > >I wonder if it would be easier on the eyes to break the hunk above out > >into > >a ixgbe_probe_vf() function. Something like (compile tested only, I > >don't > >have an 82599): > [Rose, Gregory V] > > I think that was done with the igb driver. It's a good suggestion. Yes, something like that is in igb. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-12-10 20:02 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-12-10 1:15 [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module chavey 2009-12-10 1:40 ` Rose, Gregory V 2009-12-10 1:44 ` Waskiewicz Jr, Peter P 2009-12-10 1:53 ` Rose, Gregory V 2009-12-10 19:57 ` Roland Dreier 2009-12-10 20:02 ` Rose, Gregory V -- strict thread matches above, loose matches on Subject: below -- 2009-12-08 22:13 [RFC PATCH 01/12] ixgbe: Mailbox header and code module Jeff Kirsher 2009-12-08 22:14 ` [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module Jeff Kirsher 2009-12-10 0:45 ` Simon Horman 2009-12-10 0:49 ` Rose, Gregory V 2009-12-10 1:04 ` Simon Horman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.