From: Magnus Damm <magnus.damm@gmail.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Nick Piggin <npiggin@suse.de>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: Race in new page migration code?
Date: Tue, 17 Jan 2006 17:29:15 +0900 [thread overview]
Message-ID: <aec7e5c30601170029if0ed895le2c18b26eb7c6a42@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0601152251550.17034@schroedinger.engr.sgi.com>
On 1/16/06, Christoph Lameter <clameter@engr.sgi.com> wrote:
> On Sun, 15 Jan 2006, Nick Piggin wrote:
>
> > OK (either way is fine), but you should still drop the __isolate_lru_page
> > nonsense and revert it like my patch does.
>
> Ok with me. Magnus: You needed the __isolate_lru_page for some other
> purpose. Is that still the case?
It made sense to have it broken out when it was used twice within
vmscan.c, but now when the patch changed a lot and the function is
used only once I guess the best thing is to inline it as Nick
suggested. I will re-add it myself later on when I need it. Thanks.
/ magnus
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Nick Piggin <npiggin@suse.de>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: Race in new page migration code?
Date: Tue, 17 Jan 2006 17:29:15 +0900 [thread overview]
Message-ID: <aec7e5c30601170029if0ed895le2c18b26eb7c6a42@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0601152251550.17034@schroedinger.engr.sgi.com>
On 1/16/06, Christoph Lameter <clameter@engr.sgi.com> wrote:
> On Sun, 15 Jan 2006, Nick Piggin wrote:
>
> > OK (either way is fine), but you should still drop the __isolate_lru_page
> > nonsense and revert it like my patch does.
>
> Ok with me. Magnus: You needed the __isolate_lru_page for some other
> purpose. Is that still the case?
It made sense to have it broken out when it was used twice within
vmscan.c, but now when the patch changed a lot and the function is
used only once I guess the best thing is to inline it as Nick
suggested. I will re-add it myself later on when I need it. Thanks.
/ magnus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-01-17 8:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 15:55 Race in new page migration code? Nick Piggin
2006-01-14 15:55 ` Nick Piggin
2006-01-14 18:01 ` Christoph Lameter
2006-01-14 18:01 ` Christoph Lameter
2006-01-14 18:19 ` Nick Piggin
2006-01-14 18:19 ` Nick Piggin
2006-01-14 18:58 ` Christoph Lameter
2006-01-14 18:58 ` Christoph Lameter
2006-01-15 5:28 ` Nick Piggin
2006-01-15 5:28 ` Nick Piggin
2006-01-16 6:54 ` Christoph Lameter
2006-01-16 6:54 ` Christoph Lameter
2006-01-16 7:44 ` Nick Piggin
2006-01-16 7:44 ` Nick Piggin
2006-01-17 8:29 ` Magnus Damm [this message]
2006-01-17 8:29 ` Magnus Damm
2006-01-17 9:01 ` Nick Piggin
2006-01-17 9:01 ` Nick Piggin
2006-01-17 9:22 ` Magnus Damm
2006-01-17 9:22 ` Magnus Damm
2006-01-15 6:58 ` Nick Piggin
2006-01-15 6:58 ` Nick Piggin
2006-01-15 10:58 ` Hugh Dickins
2006-01-15 10:58 ` Hugh Dickins
2006-01-16 6:51 ` Christoph Lameter
2006-01-16 6:51 ` Christoph Lameter
2006-01-16 12:32 ` Hugh Dickins
2006-01-16 12:32 ` Hugh Dickins
2006-01-16 15:47 ` Christoph Lameter
2006-01-16 15:47 ` Christoph Lameter
2006-01-16 16:06 ` Hugh Dickins
2006-01-16 16:06 ` Hugh Dickins
2006-01-16 16:10 ` Christoph Lameter
2006-01-16 16:10 ` Christoph Lameter
2006-01-16 16:28 ` Hugh Dickins
2006-01-16 16:28 ` Hugh Dickins
2006-01-16 16:51 ` Andi Kleen
2006-01-16 16:51 ` Andi Kleen
2006-01-16 16:56 ` Nick Piggin
2006-01-16 16:56 ` Nick Piggin
2006-01-17 5:06 ` Christoph Lameter
2006-01-17 5:06 ` Christoph Lameter
2006-01-17 11:16 ` Nick Piggin
2006-01-17 11:16 ` Nick Piggin
2006-01-17 17:29 ` Christoph Lameter
2006-01-17 17:29 ` Christoph Lameter
2006-01-17 18:46 ` Lee Schermerhorn
2006-01-17 18:46 ` Lee Schermerhorn
2006-01-17 18:48 ` Christoph Lameter
2006-01-17 18:48 ` Christoph Lameter
2006-01-17 19:01 ` Hugh Dickins
2006-01-17 19:01 ` Hugh Dickins
2006-01-17 20:15 ` Christoph Lameter
2006-01-17 20:15 ` Christoph Lameter
2006-01-17 20:49 ` Hugh Dickins
2006-01-17 20:49 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30601170029if0ed895le2c18b26eb7c6a42@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.