Re: [PATCH 00/17] Q35 initial support for HVM guests

["Roger Pau Monné" <roger.pau@citrix.com>]

On Fri, Mar 13, 2026 at 04:35:01PM +0000, Thierry Escande wrote:
> This series introduces initial Q35 chipset support for HVM guests, based on the
> patchset at [1] by Alexey Gerasimenko.
> 
> Basic support means that this patchset allows to start an HVM guest that
> emulates a Q35 chipset via Qemu and implements access to PCIe extended
> configuration space for such devices emulated by Qemu.
> 
> Support for PCIe device passthrough is not implemented yet. This is planned but
> implies modifications in the hypervisor and the firmwares, mainly for the
> support of multiple PCI buses.

Why do you need multi bus support to expose PCIe capabilities?  I'm
not seeing the relation between those two.  You could still expose a
single bus on the MCFG table.

> In order to create a Q35 guest, a new domain config option has been added,
> named 'device_model_machine'. Possible values are:
> - "i440" - i440 emulation (default)
> - "q35"  - emulate a Q35 machine
> 
> If the option is omitted it defaults to "i440", not impacting existing domain
> configuration files.
> 
> DSDT files for Q35 and i440 are largely similar so the existing file dsdt.asl
> has been split with i440 and q35 specific parts put in seperated files.
> 
> The PCIe MMCONFIG area is configured by hvmloader and its base address and size
> are set in Xen using a new pair of hypercalls HVMOP_get|set_ecam_space.

I guess I will see how that looks like in the series, but the setting
of the ECAM region would better be done by the toolstack.  Setting it
in hvmloader is possibly not the best placement, because it doesn't
run for PVH guests (and we will want ECAM support for PVH at some
point), and there's also a vague plan/intention to get rid of
hvmloader even for HVM guests eventually.

> Access
> to the MMCONFIG area from a guest is trapped by Xen and transfered to the
> emulator as XEN_DMOP_IO_RANGE_PCI ioreq type.

Thanks for doing this bit, IIRC from when this was last posted this
was the biggest shortcoming of the series when originally submitted.

Thanks, Roger.