Re: [PATCH v4 04/13] hw/riscv/boot: Provide a simple halting payload

[Nicholas Piggin <npiggin@gmail.com>]

On Tue, May 05, 2026 at 10:06:08AM +0200, Philippe Mathieu-Daudé wrote:
> On 5/5/26 01:52, Nicholas Piggin wrote:
> > On Thu, Apr 30, 2026 at 09:35:33AM +1000, Alistair Francis wrote:
> > > On Sat, Apr 25, 2026 at 11:21 PM Joel Stanley <joel@jms.id.au> wrote:
> > > > 
> > > > From: Nicholas Piggin <npiggin@gmail.com>
> > > > 
> > > > OpenSBI hangs before any console output if the domain init code sees the
> > > > next stage is not in an executable region.
> > > 
> > > That's an OpenSBI bug though and needs to be fixed there and not just
> > > hacked around in QEMU.
> > 
> > You're right of course. OpenSBI has other no-output crash cases in early
> > boot code (not just this), so it would be nice to fix properly. It wasn't
> > trivial to fix (IIRC because serial device is not detected before a
> > bunch of the early failures), I have some hacks, but I need to go back
> > and come up with something nicer.
> > 
> > This is only related to Atlantis by coincidence of the physical address
> > map. It can be dropped out of the series.
> 
> Meanwhile add it in hw/riscv/tt_atlantis.c:
> 
>   static void
>   tt_atlantis_setup_opensbi_halting_payload_fixup(RISCVBootInfo *info,
>                                                   hwaddr addr)
>   { ... }
> 
> and call in tt_atlantis_machine_init()!

I was going to drop it entirely but that might be better if Alistair
doesn't mind. It means we can keep the opensbi functional test. It's
still a hack just the same, but at least not touching greater-riscv.

Thanks,
Nick