[LTP] [PATCH v3] gitignore: ignore ltp-agent setup files

[LTP] [PATCH v3] gitignore: ignore ltp-agent setup files

[Andrea Cervesato]

From: Andrea Cervesato <andrea.cervesato@suse.com>

The ltp-agent tool injects a number of files and symlinks into the LTP
working directory at runtime (AGENTS.md, GEMINI.md, .agents, .claude,
and the agents/, linter/ and skills/ symlinks pointing at the agent
data). These are local helpers used by the agent and must never be
tracked or committed.

Directory entries for the injected symlinks are anchored to the
repository root (leading '/') and have no trailing slash, so they match
the ltp-agent symlinks without shadowing any unrelated subdirectory of
the same name.

Also ignore a few local agent working files: the /.pi/ session
directory and review-inline.txt scratch files.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
Changes in v3:
- add .pi and review file
- Link to v2: https://lore.kernel.org/r/20260601-gitignore_ltp_agent-v2-1-fe5ab986ebd8@suse.com

Changes in v2:
- fix files shadowing
- Link to v1: https://lore.kernel.org/r/20260530-gitignore_ltp_agent-v1-1-e8812d8de8c5@suse.com
---
 .gitignore | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/.gitignore b/.gitignore
index f10cd0c80e3655ad720e465f47c12ad0d51e7cd1..891ffb7b77325a83daa99e6f04bdc51f95490655 100644
--- a/.gitignore
+++ b/.gitignore
@@ -63,3 +63,16 @@ compile_commands.json
 
 # added by scripts/checkpatch.pl
 .checkpatch-camelcase.*
+
+# ltp-agent setup
+AGENTS.md
+GEMINI.md
+.agents
+.claude
+/agents
+/linter
+/skills
+
+# agents files
+/.pi/
+review-inline.txt

---
base-commit: 5ccf816f5d0e6c0ec3d808be456dd9ffa2a7736d
change-id: 20260530-gitignore_ltp_agent-0c7c137b6156

Best regards,
-- 
Andrea Cervesato <andrea.cervesato@suse.com>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v3] gitignore: ignore ltp-agent setup files

[Petr Vorel]

Hi Andrea,

Generally LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

> The ltp-agent tool injects a number of files and symlinks into the LTP
> working directory at runtime (AGENTS.md, GEMINI.md, .agents, .claude,
> and the agents/, linter/ and skills/ symlinks pointing at the agent
> data). These are local helpers used by the agent and must never be
> tracked or committed.

> Directory entries for the injected symlinks are anchored to the
> repository root (leading '/') and have no trailing slash, so they match
> the ltp-agent symlinks without shadowing any unrelated subdirectory of
> the same name.

Out of curiosity, here you talk about /agents /linters and /skills, right?

> Also ignore a few local agent working files: the /.pi/ session
> directory and review-inline.txt scratch files.

> diff --git a/.gitignore b/.gitignore
> index f10cd0c80e3655ad720e465f47c12ad0d51e7cd1..891ffb7b77325a83daa99e6f04bdc51f95490655 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -63,3 +63,16 @@ compile_commands.json

>  # added by scripts/checkpatch.pl
>  .checkpatch-camelcase.*
> +
> +# ltp-agent setup
Maybe link the agent project to make it obviou
# https://github.com/linux-test-project/ltp-agent

> +AGENTS.md
> +GEMINI.md
> +.agents
> +.claude
I wonder shouldn't all the above have leading '/' (slash)?
OK to change before merge.

> +/agents
> +/linter
> +/skills
> +
> +# agents files
What is the difference between "files" and "setup"?

> +/.pi/
> +review-inline.txt
And here as well leading slash?


Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v3] gitignore: ignore ltp-agent setup files

[Cyril Hrubis]

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v3] gitignore: ignore ltp-agent setup files

[Andrea Cervesato via ltp]

Hi Petr,

> Hi Andrea,
> 
> Generally LGTM.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> > The ltp-agent tool injects a number of files and symlinks into the LTP
> > working directory at runtime (AGENTS.md, GEMINI.md, .agents, .claude,
> > and the agents/, linter/ and skills/ symlinks pointing at the agent
> > data). These are local helpers used by the agent and must never be
> > tracked or committed.
> 
> > Directory entries for the injected symlinks are anchored to the
> > repository root (leading '/') and have no trailing slash, so they match
> > the ltp-agent symlinks without shadowing any unrelated subdirectory of
> > the same name.
> 
> Out of curiosity, here you talk about /agents /linters and /skills, right?

Yes

> 
> > Also ignore a few local agent working files: the /.pi/ session
> > directory and review-inline.txt scratch files.
> 
> > diff --git a/.gitignore b/.gitignore
> > index f10cd0c80e3655ad720e465f47c12ad0d51e7cd1..891ffb7b77325a83daa99e6f04bdc51f95490655 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -63,3 +63,16 @@ compile_commands.json
> 
> >  # added by scripts/checkpatch.pl
> >  .checkpatch-camelcase.*
> > +
> > +# ltp-agent setup
> Maybe link the agent project to make it obviou
> # https://github.com/linux-test-project/ltp-agent

I will add it

> 
> > +AGENTS.md
> > +GEMINI.md
> > +.agents
> > +.claude
> I wonder shouldn't all the above have leading '/' (slash)?
> OK to change before merge.

Sure

> 
> > +/agents
> > +/linter
> > +/skills
> > +
> > +# agents files
> What is the difference between "files" and "setup"?

I wanted to split ltp-agent stuff from generic agents usage such
as pi (https://pi.dev/) and spurious files produced by ltp-review
skill.

> 
> > +/.pi/
> > +review-inline.txt
> And here as well leading slash?

good idea indeed

> 
> 
> Kind regards,
> Petr

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] gitignore: ignore ltp-agent setup files

[linuxtestproject.agent]

Hi Andrea,

On Mon, 01 Jun 2026 08:46:10 +0200, Andrea Cervesato wrote:
> gitignore: ignore ltp-agent setup files

Infrastructure-only patch (`.gitignore` only) — code review checklist
skipped per protocol.

COMMIT MESSAGE
--------------
The subject follows <area>: <description> format with imperative mood.

The body accurately enumerates the injected artefacts: AGENTS.md, GEMINI.md,
.agents, .claude, and the agents/, linter/, skills/ symlinks.

The rationale for root-anchoring /agents, /linter, and /skills with a
leading '/' and no trailing slash is correct:
  - Leading '/' prevents shadowing same-named subdirectories deeper in the
    tree (e.g. a hypothetical testcases/foo/agents/).
  - Omitting the trailing slash is necessary because these are symlinks; a
    trailing slash in .gitignore only matches real directories, not symlinks,
    so the entries would silently fail to suppress them without it.

/.pi/ correctly uses both a root anchor and a trailing slash (actual
directory, not a symlink).

PATCH CORRECTNESS
-----------------
All nine added entries map 1:1 to the artefacts described in the body.
The two comment headers ("# ltp-agent setup" and "# agents files") cleanly
separate the injected runtime artefacts from the scratch working files.

The unanchored entries (.agents, .claude, review-inline.txt, AGENTS.md,
GEMINI.md) lack a leading '/'. This makes them match anywhere in the tree,
not just at the root. For .agents and .claude this is a slight overshoot
compared to the anchored treatment of /agents, /linter, /skills, but the
commit body does not claim these are anchored. In practice, no test code
creates .agents or .claude subdirectories, so no false suppression is
expected. This is noted for completeness but does not require a fix.

Verdict: Reviewed ✓

Reviewed-by: LTP AI Reviewer <ltp-ai@ltp.example.com>

LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v3] gitignore: ignore ltp-agent setup files

[Andrea Cervesato via ltp]

Merged, Thanks!

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp