CMIPCI

CMIPCI

[Lawrence Walton]

Looks like CMIPCI does not compile right now.

gcc -Wp,-MD,./.cmipci.o.d -D__KERNEL__ -I/usr/src/linux-2.5.28/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -g -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4  -nostdinc -iwithprefix include -DMODULE   -DKBUILD_BASENAME=cmipci   -c -o cmipci.o cmipci.c
cmipci.c:2482: macro `synchronize_irq' used without args
cmipci.c:2739: warning: `snd_cmipci_remove' defined but not used
make[2]: *** [cmipci.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.5.28/sound/pci'
make[1]: *** [pci] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.28/sound'
make: *** [sound] Error 2

-- 
*--* Mail: lawrence@otak.com
*--* Voice: 425.739.4247
*--* Fax: 425.827.9577
*--* HTTP://www.otak-k.com/~lawrence/
--------------------------------------
- - - - - - O t a k  i n c . - - - - - 

Re: CMIPCI

[Linus Torvalds]

In article <20020724220223.GA761@the-penguin.otak.com>,
Lawrence Walton  <lawrence@the-penguin.otak.com> wrote:
>Looks like CMIPCI does not compile right now.

For "'synchronize_irq()' used without args", you only need to add the
irq number as the argument, and it should work. Please test to verify,
and send in a patch..

		Linus

Re: CMIPCI

[Lawrence Walton]

Linus Torvalds [torvalds@transmeta.com] wrote:
> In article <20020724220223.GA761@the-penguin.otak.com>,
> Lawrence Walton  <lawrence@the-penguin.otak.com> wrote:
> >Looks like CMIPCI does not compile right now.
> 
> For "'synchronize_irq()' used without args", you only need to add the
> irq number as the argument, and it should work. Please test to verify,
> and send in a patch..
> 
> 		Linus

Here it is my first LK patch.
tested even. :)


--- cmipci.c.orig	2002-07-24 17:01:44.000000000 -0700
+++ cmipci.c	2002-07-24 17:02:43.000000000 -0700
@@ -2479,7 +2479,7 @@
 		/* reset mixer */
 		snd_cmipci_mixer_write(cm, 0, 0);
 
-		synchronize_irq();
+		synchronize_irq(dev->irq);
 
 		free_irq(cm->irq, (void *)cm);
 	}



-- 
*--* Mail: lawrence@otak.com
*--* Voice: 425.739.4247
*--* Fax: 425.827.9577
*--* HTTP://www.otak-k.com/~lawrence/
--------------------------------------
- - - - - - O t a k  i n c . - - - - -