* CMIPCI
@ 2002-07-24 22:02 Lawrence Walton
2002-07-24 22:34 ` CMIPCI Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: Lawrence Walton @ 2002-07-24 22:02 UTC (permalink / raw)
To: linux-kernel
Looks like CMIPCI does not compile right now.
gcc -Wp,-MD,./.cmipci.o.d -D__KERNEL__ -I/usr/src/linux-2.5.28/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -g -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -nostdinc -iwithprefix include -DMODULE -DKBUILD_BASENAME=cmipci -c -o cmipci.o cmipci.c
cmipci.c:2482: macro `synchronize_irq' used without args
cmipci.c:2739: warning: `snd_cmipci_remove' defined but not used
make[2]: *** [cmipci.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.5.28/sound/pci'
make[1]: *** [pci] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.28/sound'
make: *** [sound] Error 2
--
*--* Mail: lawrence@otak.com
*--* Voice: 425.739.4247
*--* Fax: 425.827.9577
*--* HTTP://www.otak-k.com/~lawrence/
--------------------------------------
- - - - - - O t a k i n c . - - - - -
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: CMIPCI
2002-07-24 22:02 CMIPCI Lawrence Walton
@ 2002-07-24 22:34 ` Linus Torvalds
2002-07-25 0:08 ` CMIPCI Lawrence Walton
0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2002-07-24 22:34 UTC (permalink / raw)
To: linux-kernel
In article <20020724220223.GA761@the-penguin.otak.com>,
Lawrence Walton <lawrence@the-penguin.otak.com> wrote:
>Looks like CMIPCI does not compile right now.
For "'synchronize_irq()' used without args", you only need to add the
irq number as the argument, and it should work. Please test to verify,
and send in a patch..
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: CMIPCI
2002-07-24 22:34 ` CMIPCI Linus Torvalds
@ 2002-07-25 0:08 ` Lawrence Walton
0 siblings, 0 replies; 3+ messages in thread
From: Lawrence Walton @ 2002-07-25 0:08 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
Linus Torvalds [torvalds@transmeta.com] wrote:
> In article <20020724220223.GA761@the-penguin.otak.com>,
> Lawrence Walton <lawrence@the-penguin.otak.com> wrote:
> >Looks like CMIPCI does not compile right now.
>
> For "'synchronize_irq()' used without args", you only need to add the
> irq number as the argument, and it should work. Please test to verify,
> and send in a patch..
>
> Linus
Here it is my first LK patch.
tested even. :)
--- cmipci.c.orig 2002-07-24 17:01:44.000000000 -0700
+++ cmipci.c 2002-07-24 17:02:43.000000000 -0700
@@ -2479,7 +2479,7 @@
/* reset mixer */
snd_cmipci_mixer_write(cm, 0, 0);
- synchronize_irq();
+ synchronize_irq(dev->irq);
free_irq(cm->irq, (void *)cm);
}
--
*--* Mail: lawrence@otak.com
*--* Voice: 425.739.4247
*--* Fax: 425.827.9577
*--* HTTP://www.otak-k.com/~lawrence/
--------------------------------------
- - - - - - O t a k i n c . - - - - -
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-07-25 0:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-07-24 22:02 CMIPCI Lawrence Walton
2002-07-24 22:34 ` CMIPCI Linus Torvalds
2002-07-25 0:08 ` CMIPCI Lawrence Walton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.