[PATCH] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a
@ 2026-06-04 13:15 Denis Batishchev
  2026-06-04 15:23 ` Takashi Iwai
  2026-06-09 13:56 ` [PATCH v2] " Denis Batishchev
  0 siblings, 2 replies; 5+ messages in thread
From: Denis Batishchev @ 2026-06-04 13:15 UTC (permalink / raw)
  To: perex; +Cc: tiwai, ii343hbka, linux-sound, linux-kernel, stable

The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec.
Without a quirk no fixup is selected and the mic-mute LED stays off.
It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the
already-supported 14" variant (SSID 103c:8dfb), so add it.

Note: I don't know how to fix sound-mute LED though.

Signed-off-by: Denis Batishchev <ii343hbka@gmail.com>
Cc: <stable@vger.kernel.org>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 78a865709..8eebf9159 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a
  2026-06-04 13:15 [PATCH] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a Denis Batishchev
@ 2026-06-04 15:23 ` Takashi Iwai
       [not found]   ` <CA+W-NrXBVkm6bvTT8+Ri=1y11A0zBK7fFVmb5m_nKHjTu9O51g@mail.gmail.com>
  2026-06-09 13:56 ` [PATCH v2] " Denis Batishchev
  1 sibling, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2026-06-04 15:23 UTC (permalink / raw)
  To: Denis Batishchev; +Cc: perex, tiwai, linux-sound, linux-kernel, stable

On Thu, 04 Jun 2026 15:15:18 +0200,
Denis Batishchev wrote:
> 
> The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec.
> Without a quirk no fixup is selected and the mic-mute LED stays off.
> It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the
> already-supported 14" variant (SSID 103c:8dfb), so add it.
> 
> Note: I don't know how to fix sound-mute LED though.

What does this mean?  Is this patch confirmed to work or not?

> Signed-off-by: Denis Batishchev <ii343hbka@gmail.com>
> Cc: <stable@vger.kernel.org>
> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 78a865709..8eebf9159 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> +	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>  	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>  	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),

The table is sorted in PCI SSID order.  Please try to put the entry at
the right position.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <CA+W-NrXBVkm6bvTT8+Ri=1y11A0zBK7fFVmb5m_nKHjTu9O51g@mail.gmail.com>]

* Re: [PATCH] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a
       [not found]   ` <CA+W-NrXBVkm6bvTT8+Ri=1y11A0zBK7fFVmb5m_nKHjTu9O51g@mail.gmail.com>
@ 2026-06-05  6:21     ` Takashi Iwai
  0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2026-06-05  6:21 UTC (permalink / raw)
  To: Denis Batishchev
  Cc: Takashi Iwai, perex, tiwai, linux-sound, linux-kernel, stable

On Thu, 04 Jun 2026 21:52:41 +0200,
Denis Batishchev wrote:
> 
> 
> This patch fixes the mic-mute led at HP Elitebook 6 g1a.

Ah, so you mean there is another LED for the audio-mute and it's not
covered by this patch?  Please make the description a bit more
clearer.


thanks,

Takashi


> On Thu, Jun 4, 2026, 17:23 Takashi Iwai <tiwai@suse.de> wrote:
> 
>     On Thu, 04 Jun 2026 15:15:18 +0200,
>     Denis Batishchev wrote:
>     >
>     > The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec.
>     > Without a quirk no fixup is selected and the mic-mute LED stays off.
>     > It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the
>     > already-supported 14" variant (SSID 103c:8dfb), so add it.
>     >
>     > Note: I don't know how to fix sound-mute LED though.
>    
>     What does this mean?  Is this patch confirmed to work or not?
>    
>     > Signed-off-by: Denis Batishchev <ii343hbka@gmail.com>
>     > Cc: <stable@vger.kernel.org>
>     > ---
>     >  sound/hda/codecs/realtek/alc269.c | 1 +
>     >  1 file changed, 1 insertion(+)
>     >
>     > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/
>     realtek/alc269.c
>     > index 78a865709..8eebf9159 100644
>     > --- a/sound/hda/codecs/realtek/alc269.c
>     > +++ b/sound/hda/codecs/realtek/alc269.c
>     > @@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =
>     {
>     >       SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12",
>     ALC236_FIXUP_HP_GPIO_LED),
>     >       SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6",
>     ALC236_FIXUP_HP_GPIO_LED),
>     >       SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14",
>     ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>     > +     SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14",
>     ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>     >       SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12",
>     ALC236_FIXUP_HP_GPIO_LED),
>     >       SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16",
>     ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>     >       SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12",
>     ALC236_FIXUP_HP_GPIO_LED),
>    
>     The table is sorted in PCI SSID order.  Please try to put the entry at
>     the right position.
> 
>     thanks,
>    
>     Takashi
> 
> -- Денис
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a
  2026-06-04 13:15 [PATCH] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a Denis Batishchev
  2026-06-04 15:23 ` Takashi Iwai
@ 2026-06-09 13:56 ` Denis Batishchev
  2026-06-09 14:15   ` Geraldo Nascimento
  1 sibling, 1 reply; 5+ messages in thread
From: Denis Batishchev @ 2026-06-09 13:56 UTC (permalink / raw)
  To: tiwai; +Cc: perex, ii343hbka, linux-sound, linux-kernel, stable

The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec.
Without a quirk no fixup is selected and the mic-mute LED stays off.
It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the
already-supported 14" variant (SSID 103c:8dfb), so add it.

Signed-off-by: Denis Batishchev <ii343hbka@gmail.com>
Cc: <stable@vger.kernel.org>
---
v2: reword commit message as was required by Takashi Iwai

 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 78a865709635..8eebf91595d3 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a
  2026-06-09 13:56 ` [PATCH v2] " Denis Batishchev
@ 2026-06-09 14:15   ` Geraldo Nascimento
  0 siblings, 0 replies; 5+ messages in thread
From: Geraldo Nascimento @ 2026-06-09 14:15 UTC (permalink / raw)
  To: Denis Batishchev; +Cc: tiwai, perex, linux-sound, linux-kernel, stable

Hi Denis,

On Tue, Jun 09, 2026 at 03:56:07PM +0200, Denis Batishchev wrote:
> The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec.
> Without a quirk no fixup is selected and the mic-mute LED stays off.
> It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the
> already-supported 14" variant (SSID 103c:8dfb), so add it.

What is your exact variant of this hardware? Also please refrain from
sending V2 in response to V1: it makes patches harder to track.

> 
> Signed-off-by: Denis Batishchev <ii343hbka@gmail.com>
> Cc: <stable@vger.kernel.org>
> ---
> v2: reword commit message as was required by Takashi Iwai
> 
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 78a865709635..8eebf91595d3 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> +	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),

The description string of the quirk seems copy-pasted. Are you sure
you have the 14" variant?

Thanks,
Geraldo Nascimento

>  	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>  	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),
> -- 
> 2.53.0
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-06-09 14:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-04 13:15 [PATCH] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a Denis Batishchev
2026-06-04 15:23 ` Takashi Iwai
     [not found]   ` <CA+W-NrXBVkm6bvTT8+Ri=1y11A0zBK7fFVmb5m_nKHjTu9O51g@mail.gmail.com>
2026-06-05  6:21     ` Takashi Iwai
2026-06-09 13:56 ` [PATCH v2] " Denis Batishchev
2026-06-09 14:15   ` Geraldo Nascimento

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.