* [PATCH] MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP
@ 2026-06-10 22:01 Ethan Nelson-Moore
2026-06-16 11:01 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-10 22:01 UTC (permalink / raw)
To: GitAuthor: Ethan Nelson-Moore, linux-mips; +Cc: Thomas Bogendoerfer
CMP support was removed in commit 7fb6f7b0af67 ("MIPS: Remove
deprecated CONFIG_MIPS_CMP"), but a comment referring to it remained in
arch/mips/mm/c-r4k.c. Remove it.
Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
arch/mips/mm/c-r4k.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
index 10413b6f6662..d8aadd3dc057 100644
--- a/arch/mips/mm/c-r4k.c
+++ b/arch/mips/mm/c-r4k.c
@@ -1757,11 +1757,6 @@ void r4k_cache_init(void)
build_clear_page();
build_copy_page();
- /*
- * We want to run CMP kernels on core with and without coherent
- * caches. Therefore, do not use CONFIG_MIPS_CMP to decide whether
- * or not to flush caches.
- */
local_r4k___flush_cache_all(NULL);
coherency_setup();
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP
2026-06-10 22:01 [PATCH] MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP Ethan Nelson-Moore
@ 2026-06-16 11:01 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2026-06-16 11:01 UTC (permalink / raw)
To: Ethan Nelson-Moore; +Cc: linux-mips
On Wed, Jun 10, 2026 at 03:01:22PM -0700, Ethan Nelson-Moore wrote:
> CMP support was removed in commit 7fb6f7b0af67 ("MIPS: Remove
> deprecated CONFIG_MIPS_CMP"), but a comment referring to it remained in
> arch/mips/mm/c-r4k.c. Remove it.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> arch/mips/mm/c-r4k.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
> index 10413b6f6662..d8aadd3dc057 100644
> --- a/arch/mips/mm/c-r4k.c
> +++ b/arch/mips/mm/c-r4k.c
> @@ -1757,11 +1757,6 @@ void r4k_cache_init(void)
> build_clear_page();
> build_copy_page();
>
> - /*
> - * We want to run CMP kernels on core with and without coherent
> - * caches. Therefore, do not use CONFIG_MIPS_CMP to decide whether
> - * or not to flush caches.
> - */
> local_r4k___flush_cache_all(NULL);
>
> coherency_setup();
> --
> 2.43.0
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-16 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 22:01 [PATCH] MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP Ethan Nelson-Moore
2026-06-16 11:01 ` Thomas Bogendoerfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.