From: Pranjal Shrivastava <praan@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Trond Myklebust <trondmy@kernel.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Anna Schumaker <anna@kernel.org>,
Shivaji Kant <shivajikant@google.com>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] nfs: Optimize direct I/O to use folios for requests
Date: Thu, 9 Jul 2026 06:19:12 +0000 [thread overview]
Message-ID: <ak89YF6BS-iYf_e_@google.com> (raw)
In-Reply-To: <ak44z-X-SKKhkBkg@google.com>
On Wed, Jul 08, 2026 at 11:47:27AM +0000, Pranjal Shrivastava wrote:
> On Wed, Jul 08, 2026 at 12:48:56AM -0700, Christoph Hellwig wrote:
> > On Tue, Jul 07, 2026 at 12:08:27PM +0000, Pranjal Shrivastava wrote:
> > > Ack. I see! Thanks!
> > >
> > > Regarding the page_folio impasse, how do you suggest we proceed? Should
> > > I expose and use get_contig_folio_len() from bvec? Or should I move the
> > > NFS helper into the iov_iter lib? (or both).
> >
> > Sounds like the best way forward for now.
>
> Ack. I'll reuse get_contig_folio len and move the nfs extractor to
> iov_iter for v3.
>
On a second thought, I guess I'd try taking a stab at writing
iov_iter_extract_folios and handle the vmalloc / slab cases for kvecs.
I believe that would be the right way to go, unless I'm missing
something obvious? Can I take a stab at it in the next version?
Thanks,
Praan
next prev parent reply other threads:[~2026-07-09 6:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 13:39 [PATCH v2 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
2026-06-16 13:39 ` [PATCH v2 1/7] nfs: make nfs_page pin-aware Pranjal Shrivastava
2026-06-16 13:39 ` [PATCH v2 2/7] nfs: Track number of pinned pages in nfs_page Pranjal Shrivastava
2026-06-16 13:39 ` [PATCH v2 3/7] nfs: Introduce nfs_release_request_list helper Pranjal Shrivastava
2026-06-16 13:39 ` [PATCH v2 4/7] nfs: migrate direct I/O to iov_iter_extract_pages Pranjal Shrivastava
2026-06-16 13:39 ` [PATCH v2 5/7] nfs: introduce nfs_direct_extract_pages helper Pranjal Shrivastava
2026-06-16 13:39 ` [PATCH v2 6/7] nfs: Optimize direct I/O to use folios for requests Pranjal Shrivastava
2026-06-16 15:29 ` Trond Myklebust
2026-06-16 17:23 ` Pranjal Shrivastava
2026-06-18 14:10 ` Christoph Hellwig
2026-06-18 18:20 ` Matthew Wilcox
2026-06-19 12:32 ` Pranjal Shrivastava
2026-06-26 6:56 ` Christoph Hellwig
2026-07-03 12:46 ` Pranjal Shrivastava
2026-07-03 14:00 ` Christoph Hellwig
2026-07-07 12:08 ` Pranjal Shrivastava
2026-07-08 7:48 ` Christoph Hellwig
2026-07-08 11:47 ` Pranjal Shrivastava
2026-07-09 6:19 ` Pranjal Shrivastava [this message]
2026-07-09 6:22 ` Christoph Hellwig
2026-07-09 6:22 ` Christoph Hellwig
2026-06-16 13:40 ` [PATCH v2 7/7] nfs: Cleanup the nfs_page_create_from_page helper Pranjal Shrivastava
2026-06-16 14:15 ` [PATCH v2 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
2026-06-18 13:46 ` Chuck Lever
2026-06-19 11:50 ` Pranjal Shrivastava
2026-06-18 14:11 ` Christoph Hellwig
2026-06-19 11:48 ` Pranjal Shrivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak89YF6BS-iYf_e_@google.com \
--to=praan@google.com \
--cc=anna@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=shivajikant@google.com \
--cc=trondmy@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.