Re: [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure

From: Vinod Koul <vkoul@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "Pan Chuang" <panchuang@vivo.com>, "Frank Li" <Frank.Li@nxp.com>,
	"Keguang Zhang" <keguang.zhang@gmail.com>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Amélie Delaunay" <amelie.delaunay@foss.st.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Chen-Yu Tsai" <wens@kernel.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Laxman Dewangan" <ldewangan@nvidia.com>,
	"Jon Hunter" <jonathanh@nvidia.com>,
	"Thierry Reding" <thierry.reding@kernel.org>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
	"Icenowy Zheng" <zhengxingda@iscas.ac.cn>,
	"Kees Cook" <kees@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Miaoqian Lin" <linmq006@gmail.com>,
	"Jyothi Kumar Seerapu" <quic_jseerapu@quicinc.com>,
	"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Cosmin Tanislav" <cosmin-gabriel.tanislav.xa@renesas.com>,
	"John Madieu" <john.madieu.xa@bp.renesas.com>,
	"Thomas Andreatta" <thomasandreatta2000@gmail.com>,
	"open list:FREESCALE eDMA DRIVER" <imx@lists.linux.dev>,
	"open list:FREESCALE eDMA DRIVER" <dmaengine@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"open list:MIPS/LOONGSON1 ARCHITECTURE"
	<linux-mips@vger.kernel.org>,
	"moderated list:MEDIATEK DMA DRIVER"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:MEDIATEK DMA DRIVER"
	<linux-mediatek@lists.infradead.org>,
	"moderated list:ARM/ACTIONS SEMI ARCHITECTURE"
	<linux-actions@lists.infradead.org>,
	"open list:ARM/QUALCOMM MAILING LIST"
	<linux-arm-msm@vger.kernel.org>,
	"open list:SIFIVE DRIVERS" <linux-riscv@lists.infradead.org>,
	"open list:ARM/RISC-V/RENESAS ARCHITECTURE"
	<linux-renesas-soc@vger.kernel.org>,
	"moderated list:STM32 DMA DRIVERS"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"open list:ARM/Allwinner sunXi SoC support"
	<linux-sunxi@lists.linux.dev>,
	"open list:TEGRA ARCHITECTURE SUPPORT"
	<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure
Date: Tue, 14 Jul 2026 17:36:14 +0530	[thread overview]
Message-ID: <alYmNl--mxMK1-86@vaman> (raw)
In-Reply-To: <ak-vkQ8g_ePdY15f@shikoro>

On 09-07-26, 16:26, Wolfram Sang wrote:
> On Thu, Jul 09, 2026 at 09:58:04PM +0800, Pan Chuang wrote:
> > Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
> > error handling in devm_request_*_irq()") added automatic error logging
> > to devm_request_threaded_irq() and devm_request_any_context_irq() via
> > the new devm_request_result() helper. The helper prints device name,
> > IRQ number, handler functions, and error code on failure.
> > 
> > Since devm_request_irq() is a static inline wrapper around
> > devm_request_threaded_irq(), it also benefits from this automatic
> > logging.
> > 
> > This series removes the now-redundant dev_err() and dev_err_probe() calls
> > in dmaengine drivers that follow these devm_request_*_irq() functions,
> > as the core now provides more detailed diagnostic information on failure.
> > 
> > Pan Chuang (26):
> >   dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: loongson-loongson1-apb-dma: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: mediatek-mtk-cqdma: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: mediatek-mtk-hsdma: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: stm32-stm32-dma3: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: stm32-stm32-mdma: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()
> 
> One patch per subsystem for such trivial changes, please.

Yes pretty please

-- 
~Vinod