Re: [PATCH 00/26] dmaengine: Remove redundant dev_err()/dev_err_probe() calls

From: Frank Li <Frank.li@oss.nxp.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: vkoul@kernel.org, Frank.Li@nxp.com, afaerber@suse.de,
	alexandre.torgue@foss.st.com, amelie.delaunay@foss.st.com,
	andersson@kernel.org, angelogioacchino.delregno@collabora.com,
	baolin.wang@linux.alibaba.com, biju.das.jz@bp.renesas.com,
	claudiu.beznea.uj@bp.renesas.com,
	cosmin-gabriel.tanislav.xa@renesas.com, daniel@zonque.org,
	dmaengine@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com,
	geert+renesas@glider.be, haojian.zhuang@gmail.com,
	hayashi.kunihiko@socionext.com, imx@lists.linux.dev,
	jernej.skrabec@gmail.com, john.madieu.xa@bp.renesas.com,
	jonathanh@nvidia.com, kees@kernel.org, keguang.zhang@gmail.com,
	ldewangan@nvidia.com, linmq006@gmail.com,
	linux-actions@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	magnus.damm@gmail.com, mani@kernel.org, matthias.bgg@gmail.com,
	mcoquelin.stm32@gmail.com, mhiramat@kernel.org,
	orsonzhai@gmail.com, patrice.chotard@foss.st.com, pjw@kernel.org,
	quic_jseerapu@quicinc.com, robert.jarzmik@free.fr,
	samuel.holland@sifive.com, sean.wang@mediatek.com,
	thierry.reding@kernel.org, thomasandreatta2000@gmail.com,
	vigneshr@ti.com, wens@kernel.org,
	wsa+renesas@sang-engineering.com, zhang.lyra@gmail.com,
	zhengxingda@iscas.ac.cn
Subject: Re: [PATCH 00/26] dmaengine: Remove redundant dev_err()/dev_err_probe() calls
Date: Fri, 4 Sep 2026 12:02:58 -0400	[thread overview]
Message-ID: <aprrssx-LorAEjV4@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260715064443.525836-1-panchuang@vivo.com>

On Wed, Jul 15, 2026 at 02:44:43PM +0800, Pan Chuang wrote:
> On 2026-07-14 20:06, Vinod Koul wrote:
> > On 09-07-26, 16:26, Wolfram Sang wrote:
> >> On Thu, Jul 09, 2026 at 09:58:04PM +0800, Pan Chuang wrote:
> >>> Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
> >>> error handling in devm_request_*_irq()") added automatic error logging
> >>> to devm_request_threaded_irq() and devm_request_any_context_irq() via
> >>> the new devm_request_result() helper. The helper prints device name,
> >>> IRQ number, handler functions, and error code on failure.
> >>>
> >>> Since devm_request_irq() is a static inline wrapper around
> >>> devm_request_threaded_irq(), it also benefits from this automatic
> >>> logging.
> >>>
> >>> This series removes the now-redundant dev_err() and dev_err_probe() calls
> >>> in dmaengine drivers that follow these devm_request_*_irq() functions,
> >>> as the core now provides more detailed diagnostic information on failure.
> >>>
> >>> Pan Chuang (26):
> >>>   dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: loongson-loongson1-apb-dma: Remove redundant
> >>>     dev_err()/dev_err_probe()
> >>>   dmaengine: mediatek-mtk-cqdma: Remove redundant
> >>>     dev_err()/dev_err_probe()
> >>>   dmaengine: mediatek-mtk-hsdma: Remove redundant
> >>>     dev_err()/dev_err_probe()
> >>>   dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: stm32-stm32-dma3: Remove redundant
> >>>     dev_err()/dev_err_probe()
> >>>   dmaengine: stm32-stm32-mdma: Remove redundant
> >>>     dev_err()/dev_err_probe()
> >>>   dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
> >>>   dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()
> >>
> >> One patch per subsystem for such trivial changes, please.
> >
> > Yes pretty please
> >
> Thanks, I'll merge them in v2.

Did you post v2?

Frank

>
> Best Regards,
> PanChuang