* [PATCH v3 0/2] PHY: Add support for MT8196 DSI PHY @ 2026-07-13 10:38 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-13 10:38 UTC (permalink / raw) To: chunfeng.yun Cc: vkoul, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, angelogioacchino.delregno, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel Changes in v3: - Actually sent the correct patch series (sorry, I had messed up v2) - Added definitions for minimum and maximum PLL rates Changes in v2: - Added a few comments and fix scheduling while atomic issue in clk enable ops by waiting with udelay() instead - Removed one unnecessary delay after clk/pwr isolation disablement This series adds support for the DSI PHY found in the newer MediaTek Dimensity 9400 (MT6991), Genio Pro 5100 (MT8894) and Kompanio Ultra (MT8196) SoCs. AngeloGioacchino Del Regno (2): dt-bindings: phy: mediatek,dsi-phy: Add support for MT8196 phy: mediatek: Add support for MT8196 MIPI DSI PHY .../bindings/phy/mediatek,dsi-phy.yaml | 1 + drivers/phy/mediatek/Makefile | 1 + .../phy/mediatek/phy-mtk-mipi-dsi-mt8196.c | 201 ++++++++++++++++++ drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 1 + drivers/phy/mediatek/phy-mtk-mipi-dsi.h | 2 +- 5 files changed, 205 insertions(+), 1 deletion(-) create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c -- 2.54.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v3 0/2] PHY: Add support for MT8196 DSI PHY @ 2026-07-13 10:38 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-13 10:38 UTC (permalink / raw) To: chunfeng.yun Cc: vkoul, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, angelogioacchino.delregno, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel Changes in v3: - Actually sent the correct patch series (sorry, I had messed up v2) - Added definitions for minimum and maximum PLL rates Changes in v2: - Added a few comments and fix scheduling while atomic issue in clk enable ops by waiting with udelay() instead - Removed one unnecessary delay after clk/pwr isolation disablement This series adds support for the DSI PHY found in the newer MediaTek Dimensity 9400 (MT6991), Genio Pro 5100 (MT8894) and Kompanio Ultra (MT8196) SoCs. AngeloGioacchino Del Regno (2): dt-bindings: phy: mediatek,dsi-phy: Add support for MT8196 phy: mediatek: Add support for MT8196 MIPI DSI PHY .../bindings/phy/mediatek,dsi-phy.yaml | 1 + drivers/phy/mediatek/Makefile | 1 + .../phy/mediatek/phy-mtk-mipi-dsi-mt8196.c | 201 ++++++++++++++++++ drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 1 + drivers/phy/mediatek/phy-mtk-mipi-dsi.h | 2 +- 5 files changed, 205 insertions(+), 1 deletion(-) create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c -- 2.54.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v3 1/2] dt-bindings: phy: mediatek, dsi-phy: Add support for MT8196 2026-07-13 10:38 ` AngeloGioacchino Del Regno (?) @ 2026-07-13 10:38 ` AngeloGioacchino Del Regno -1 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-13 10:38 UTC (permalink / raw) To: chunfeng.yun Cc: vkoul, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, angelogioacchino.delregno, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel, Krzysztof Kozlowski Add support for the MediaTek Kompanio Ultra (MT8196) SoC: this chip features a DSI PHY that is similar to the one found in the MT8183 SoC, but is a new (incremental) revision with a different register layout. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml index c6d0bbdbe0e2..9df1dbe1253b 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml @@ -39,6 +39,7 @@ properties: - const: mediatek,mt2701-mipi-tx - const: mediatek,mt8173-mipi-tx - const: mediatek,mt8183-mipi-tx + - const: mediatek,mt8196-mipi-tx reg: maxItems: 1 -- 2.54.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v3 1/2] dt-bindings: phy: mediatek,dsi-phy: Add support for MT8196 @ 2026-07-13 10:38 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-13 10:38 UTC (permalink / raw) To: chunfeng.yun Cc: vkoul, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, angelogioacchino.delregno, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel, Krzysztof Kozlowski Add support for the MediaTek Kompanio Ultra (MT8196) SoC: this chip features a DSI PHY that is similar to the one found in the MT8183 SoC, but is a new (incremental) revision with a different register layout. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml index c6d0bbdbe0e2..9df1dbe1253b 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml @@ -39,6 +39,7 @@ properties: - const: mediatek,mt2701-mipi-tx - const: mediatek,mt8173-mipi-tx - const: mediatek,mt8183-mipi-tx + - const: mediatek,mt8196-mipi-tx reg: maxItems: 1 -- 2.54.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v3 1/2] dt-bindings: phy: mediatek,dsi-phy: Add support for MT8196 @ 2026-07-13 10:38 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-13 10:38 UTC (permalink / raw) To: chunfeng.yun Cc: vkoul, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, angelogioacchino.delregno, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel, Krzysztof Kozlowski Add support for the MediaTek Kompanio Ultra (MT8196) SoC: this chip features a DSI PHY that is similar to the one found in the MT8183 SoC, but is a new (incremental) revision with a different register layout. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml index c6d0bbdbe0e2..9df1dbe1253b 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml @@ -39,6 +39,7 @@ properties: - const: mediatek,mt2701-mipi-tx - const: mediatek,mt8173-mipi-tx - const: mediatek,mt8183-mipi-tx + - const: mediatek,mt8196-mipi-tx reg: maxItems: 1 -- 2.54.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY 2026-07-13 10:38 ` AngeloGioacchino Del Regno @ 2026-07-13 10:38 ` AngeloGioacchino Del Regno -1 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-13 10:38 UTC (permalink / raw) To: chunfeng.yun Cc: vkoul, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, angelogioacchino.delregno, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel Add support for the MIPI DSI PHY found in the MediaTek MT8196 SoC and its variants. This PHY has a different register layout and provides support for more hardware features compared to the previous generation. This initial driver only adds support for basic functionality that is necessary to drive MIPI DSI displays as a D-PHY. Feature additions like lane-swap, DPHY/CPHY switching, dual-port, and others, may be done in the future. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/phy/mediatek/Makefile | 1 + .../phy/mediatek/phy-mtk-mipi-dsi-mt8196.c | 201 ++++++++++++++++++ drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 1 + drivers/phy/mediatek/phy-mtk-mipi-dsi.h | 2 +- 4 files changed, 204 insertions(+), 1 deletion(-) create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c diff --git a/drivers/phy/mediatek/Makefile b/drivers/phy/mediatek/Makefile index 1b8088df71e8..ed0da708759b 100644 --- a/drivers/phy/mediatek/Makefile +++ b/drivers/phy/mediatek/Makefile @@ -21,4 +21,5 @@ obj-$(CONFIG_PHY_MTK_MIPI_CSI_0_5) += phy-mtk-mipi-csi-0-5.o phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8196.o obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c new file mode 100644 index 000000000000..eac3db9922db --- /dev/null +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c @@ -0,0 +1,201 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2019 MediaTek Inc. + * Author: jitao.shi <jitao.shi@mediatek.com> + * + * Copyright (c) 2026 Collabora Ltd. + * AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> + */ + +#include "phy-mtk-io.h" +#include "phy-mtk-mipi-dsi.h" + +#define MIPITX_LANE_CON 0x0004 +#define RG_DSI_CPHY_T1DRV_EN BIT(0) +#define RG_DSI_ANA_CK_SEL BIT(1) +#define RG_DSI_PHY_CK_SEL BIT(2) +#define RG_DSI_CPHY_EN BIT(3) +#define RG_DSI_PHYCK_INV_EN BIT(4) +#define RG_DSI_PWR04_EN BIT(5) +#define RG_DSI_BG_LPF_EN BIT(6) +#define RG_DSI_BG_CORE_EN BIT(7) +#define RG_DSI_PAD_TIEL_SEL BIT(8) + +#define MIPITX_VOLTAGE_SEL 0x0008 +#define RG_DSI_HSTX_LDO_REF_SEL GENMASK(9, 6) +#define RG_DSI_PRD_REF_SEL GENMASK(5, 0) +#define RG_DSI_PRD_REF_MINI 0 +#define RG_DSI_PRD_REF_DEF 4 +#define RG_DSI_PRD_REF_MAX 7 + +#define MIPITX_PRESERVED 0x000c +#define MIPITX_PRESERVED_DEF 0xffff0040 +#define MIPITX_PRESERVED_MINI 0xffff00f0 + +#define MIPITX_PLL_PWR 0x0028 +#define AD_DSI_PLL_SDM_PWR_ON BIT(0) +#define AD_DSI_PLL_SDM_ISO_EN BIT(1) +#define MIPITX_PLL_CON0 0x002c +#define MIPITX_PLL_CON1 0x0030 +#define RG_DSI_PLL_EN BIT(0) +#define RG_DSI_PLL_POSDIV GENMASK(10, 8) +#define MIPITX_PLL_CON2 0x0034 +#define MIPITX_PLL_CON3 0x0038 +#define MIPITX_PLL_CON4 0x003c +#define RG_DSI_PLL_IBIAS GENMASK(11, 10) + +#define MIPITX_D2_SW_CTL_EN 0x015c +#define MIPITX_D0_SW_CTL_EN 0x025c +#define MIPITX_CK_CKMODE_EN 0x0320 +#define DSI_CK_CKMODE_EN BIT(0) +#define MIPITX_CK_SW_CTL_EN 0x035c +#define MIPITX_D1_SW_CTL_EN 0x045c +#define MIPITX_D3_SW_CTL_EN 0x055c +#define DSI_SW_CTL_EN BIT(0) + +#define DSI_PHY_XTAL_CLK_HZ 26000000 +#define DSI_PHY_PLL_MIN_RATE_HZ 125000000 +#define DSI_PHY_PLL_MAX_RATE_HZ 2000000000 + +static int mtk_mipi_tx_pll_enable(struct clk_hw *hw) +{ + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw); + void __iomem *base = mipi_tx->regs; + u32 voltage = RG_DSI_PRD_REF_MINI; + u32 pres = MIPITX_PRESERVED_MINI; + unsigned long long pcw_calc; + unsigned int txdiv, txdiv0; + u32 pcw; + + dev_dbg(mipi_tx->dev, "enable: %u bps\n", mipi_tx->data_rate); + + if (mipi_tx->data_rate >= DSI_PHY_PLL_MAX_RATE_HZ) { + /* Select higher signaling voltage for fast data rates */ + voltage = RG_DSI_PRD_REF_DEF; + pres = MIPITX_PRESERVED_DEF; + txdiv = 1; + txdiv0 = 0; + } else if (mipi_tx->data_rate >= 1000000000) { + txdiv = 2; + txdiv0 = 1; + } else if (mipi_tx->data_rate >= 500000000) { + txdiv = 4; + txdiv0 = 2; + } else if (mipi_tx->data_rate > 250000000) { + txdiv = 8; + txdiv0 = 3; + } else if (mipi_tx->data_rate >= 125000000) { + txdiv = 16; + txdiv0 = 4; + } else { + return -EINVAL; + } + + pcw_calc = ((u64)(mipi_tx->data_rate / 2) * txdiv) << 24; + pcw_calc = div_u64(pcw_calc, DSI_PHY_XTAL_CLK_HZ); + + if (pcw_calc > U32_MAX) { + dev_err(mipi_tx->dev, "Calculated PCW=%llu overflow!\n", pcw_calc); + return -EINVAL; + } + pcw = (u32)pcw_calc; + + mtk_phy_update_field(base + MIPITX_VOLTAGE_SEL, RG_DSI_PRD_REF_SEL, voltage); + writel(pres, base + MIPITX_PRESERVED); + + /* Enable the SDM and wait for power to stabilize */ + mtk_phy_set_bits(base + MIPITX_PLL_PWR, AD_DSI_PLL_SDM_PWR_ON); + mtk_phy_clear_bits(base + MIPITX_PLL_CON1, RG_DSI_PLL_EN); + udelay(30); + + /* Disable isolation and program PLL's PCW and dividers */ + mtk_phy_clear_bits(base + MIPITX_PLL_PWR, AD_DSI_PLL_SDM_ISO_EN); + writel(pcw, base + MIPITX_PLL_CON0); + mtk_phy_update_field(base + MIPITX_PLL_CON1, RG_DSI_PLL_POSDIV, txdiv0); + + /* Enable the PLL and wait for the clock output to stabilize */ + mtk_phy_set_bits(base + MIPITX_PLL_CON1, RG_DSI_PLL_EN); + udelay(30); + + return 0; +} + +static void mtk_mipi_tx_pll_disable(struct clk_hw *hw) +{ + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw); + void __iomem *base = mipi_tx->regs; + + mtk_phy_clear_bits(base + MIPITX_PLL_CON1, RG_DSI_PLL_EN); + + mtk_phy_set_bits(base + MIPITX_PLL_PWR, AD_DSI_PLL_SDM_ISO_EN); + mtk_phy_clear_bits(base + MIPITX_PLL_PWR, AD_DSI_PLL_SDM_PWR_ON); +} + +static int mtk_mipi_tx_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) +{ + req->rate = clamp_val(req->rate, + DSI_PHY_PLL_MIN_RATE_HZ, DSI_PHY_PLL_MAX_RATE_HZ); + + return 0; +} + +static const struct clk_ops mtk_mipi_tx_pll_ops = { + .enable = mtk_mipi_tx_pll_enable, + .disable = mtk_mipi_tx_pll_disable, + .determine_rate = mtk_mipi_tx_pll_determine_rate, + .set_rate = mtk_mipi_tx_pll_set_rate, + .recalc_rate = mtk_mipi_tx_pll_recalc_rate, +}; + +static void mtk_mipi_tx_power_on_signal(struct phy *phy) +{ + struct mtk_mipi_tx *mipi_tx = phy_get_drvdata(phy); + void __iomem *base = mipi_tx->regs; + + /* BG_LPF_EN / BG_CORE_EN */ + writel(RG_DSI_PAD_TIEL_SEL | RG_DSI_BG_CORE_EN, base + MIPITX_LANE_CON); + /* Wait for MIPI core to enable */ + usleep_range(30, 100); + writel(RG_DSI_BG_CORE_EN | RG_DSI_BG_LPF_EN, base + MIPITX_LANE_CON); + + /* Switch OFF each Lane */ + mtk_phy_clear_bits(base + MIPITX_D0_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_clear_bits(base + MIPITX_D1_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_clear_bits(base + MIPITX_D2_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_clear_bits(base + MIPITX_D3_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_clear_bits(base + MIPITX_CK_SW_CTL_EN, DSI_SW_CTL_EN); + + /* + * The MIPI TX drive strength is in the range of 3000 ~ 6000 microamps: + * RG_DSI_HSTX_LDO_REF_SEL expresses an offset from the minimum drive + * strength (3000uA) and can add a maximum offset of 3000uA, reaching a + * maximum drive strength of 3000+3000=6000uA. + */ + mtk_phy_update_field(base + MIPITX_VOLTAGE_SEL, RG_DSI_HSTX_LDO_REF_SEL, + (mipi_tx->mipitx_drive - 3000) / 200); + + mtk_phy_set_bits(base + MIPITX_CK_CKMODE_EN, DSI_CK_CKMODE_EN); +} + +static void mtk_mipi_tx_power_off_signal(struct phy *phy) +{ + struct mtk_mipi_tx *mipi_tx = phy_get_drvdata(phy); + void __iomem *base = mipi_tx->regs; + + /* Switch ON each lane one by one */ + mtk_phy_set_bits(base + MIPITX_D0_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_set_bits(base + MIPITX_D1_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_set_bits(base + MIPITX_D2_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_set_bits(base + MIPITX_D3_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_set_bits(base + MIPITX_CK_SW_CTL_EN, DSI_SW_CTL_EN); + + writel(RG_DSI_PAD_TIEL_SEL | RG_DSI_BG_CORE_EN, base + MIPITX_LANE_CON); + writel(RG_DSI_PAD_TIEL_SEL, base + MIPITX_LANE_CON); +} + +const struct mtk_mipitx_data mt8196_mipitx_data = { + .mipi_tx_clk_ops = &mtk_mipi_tx_pll_ops, + .mipi_tx_enable_signal = mtk_mipi_tx_power_on_signal, + .mipi_tx_disable_signal = mtk_mipi_tx_power_off_signal, +}; diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c index 065ea626093a..46f0cb3ac096 100644 --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c @@ -183,6 +183,7 @@ static const struct of_device_id mtk_mipi_tx_match[] = { { .compatible = "mediatek,mt2701-mipi-tx", .data = &mt2701_mipitx_data }, { .compatible = "mediatek,mt8173-mipi-tx", .data = &mt8173_mipitx_data }, { .compatible = "mediatek,mt8183-mipi-tx", .data = &mt8183_mipitx_data }, + { .compatible = "mediatek,mt8196-mipi-tx", .data = &mt8196_mipitx_data }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, mtk_mipi_tx_match); diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.h b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h index 5d4876f1dc95..e6f967078e3b 100644 --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.h +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h @@ -42,5 +42,5 @@ unsigned long mtk_mipi_tx_pll_recalc_rate(struct clk_hw *hw, extern const struct mtk_mipitx_data mt2701_mipitx_data; extern const struct mtk_mipitx_data mt8173_mipitx_data; extern const struct mtk_mipitx_data mt8183_mipitx_data; - +extern const struct mtk_mipitx_data mt8196_mipitx_data; #endif -- 2.54.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY @ 2026-07-13 10:38 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-13 10:38 UTC (permalink / raw) To: chunfeng.yun Cc: vkoul, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, angelogioacchino.delregno, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel Add support for the MIPI DSI PHY found in the MediaTek MT8196 SoC and its variants. This PHY has a different register layout and provides support for more hardware features compared to the previous generation. This initial driver only adds support for basic functionality that is necessary to drive MIPI DSI displays as a D-PHY. Feature additions like lane-swap, DPHY/CPHY switching, dual-port, and others, may be done in the future. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/phy/mediatek/Makefile | 1 + .../phy/mediatek/phy-mtk-mipi-dsi-mt8196.c | 201 ++++++++++++++++++ drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 1 + drivers/phy/mediatek/phy-mtk-mipi-dsi.h | 2 +- 4 files changed, 204 insertions(+), 1 deletion(-) create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c diff --git a/drivers/phy/mediatek/Makefile b/drivers/phy/mediatek/Makefile index 1b8088df71e8..ed0da708759b 100644 --- a/drivers/phy/mediatek/Makefile +++ b/drivers/phy/mediatek/Makefile @@ -21,4 +21,5 @@ obj-$(CONFIG_PHY_MTK_MIPI_CSI_0_5) += phy-mtk-mipi-csi-0-5.o phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8196.o obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c new file mode 100644 index 000000000000..eac3db9922db --- /dev/null +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c @@ -0,0 +1,201 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2019 MediaTek Inc. + * Author: jitao.shi <jitao.shi@mediatek.com> + * + * Copyright (c) 2026 Collabora Ltd. + * AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> + */ + +#include "phy-mtk-io.h" +#include "phy-mtk-mipi-dsi.h" + +#define MIPITX_LANE_CON 0x0004 +#define RG_DSI_CPHY_T1DRV_EN BIT(0) +#define RG_DSI_ANA_CK_SEL BIT(1) +#define RG_DSI_PHY_CK_SEL BIT(2) +#define RG_DSI_CPHY_EN BIT(3) +#define RG_DSI_PHYCK_INV_EN BIT(4) +#define RG_DSI_PWR04_EN BIT(5) +#define RG_DSI_BG_LPF_EN BIT(6) +#define RG_DSI_BG_CORE_EN BIT(7) +#define RG_DSI_PAD_TIEL_SEL BIT(8) + +#define MIPITX_VOLTAGE_SEL 0x0008 +#define RG_DSI_HSTX_LDO_REF_SEL GENMASK(9, 6) +#define RG_DSI_PRD_REF_SEL GENMASK(5, 0) +#define RG_DSI_PRD_REF_MINI 0 +#define RG_DSI_PRD_REF_DEF 4 +#define RG_DSI_PRD_REF_MAX 7 + +#define MIPITX_PRESERVED 0x000c +#define MIPITX_PRESERVED_DEF 0xffff0040 +#define MIPITX_PRESERVED_MINI 0xffff00f0 + +#define MIPITX_PLL_PWR 0x0028 +#define AD_DSI_PLL_SDM_PWR_ON BIT(0) +#define AD_DSI_PLL_SDM_ISO_EN BIT(1) +#define MIPITX_PLL_CON0 0x002c +#define MIPITX_PLL_CON1 0x0030 +#define RG_DSI_PLL_EN BIT(0) +#define RG_DSI_PLL_POSDIV GENMASK(10, 8) +#define MIPITX_PLL_CON2 0x0034 +#define MIPITX_PLL_CON3 0x0038 +#define MIPITX_PLL_CON4 0x003c +#define RG_DSI_PLL_IBIAS GENMASK(11, 10) + +#define MIPITX_D2_SW_CTL_EN 0x015c +#define MIPITX_D0_SW_CTL_EN 0x025c +#define MIPITX_CK_CKMODE_EN 0x0320 +#define DSI_CK_CKMODE_EN BIT(0) +#define MIPITX_CK_SW_CTL_EN 0x035c +#define MIPITX_D1_SW_CTL_EN 0x045c +#define MIPITX_D3_SW_CTL_EN 0x055c +#define DSI_SW_CTL_EN BIT(0) + +#define DSI_PHY_XTAL_CLK_HZ 26000000 +#define DSI_PHY_PLL_MIN_RATE_HZ 125000000 +#define DSI_PHY_PLL_MAX_RATE_HZ 2000000000 + +static int mtk_mipi_tx_pll_enable(struct clk_hw *hw) +{ + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw); + void __iomem *base = mipi_tx->regs; + u32 voltage = RG_DSI_PRD_REF_MINI; + u32 pres = MIPITX_PRESERVED_MINI; + unsigned long long pcw_calc; + unsigned int txdiv, txdiv0; + u32 pcw; + + dev_dbg(mipi_tx->dev, "enable: %u bps\n", mipi_tx->data_rate); + + if (mipi_tx->data_rate >= DSI_PHY_PLL_MAX_RATE_HZ) { + /* Select higher signaling voltage for fast data rates */ + voltage = RG_DSI_PRD_REF_DEF; + pres = MIPITX_PRESERVED_DEF; + txdiv = 1; + txdiv0 = 0; + } else if (mipi_tx->data_rate >= 1000000000) { + txdiv = 2; + txdiv0 = 1; + } else if (mipi_tx->data_rate >= 500000000) { + txdiv = 4; + txdiv0 = 2; + } else if (mipi_tx->data_rate > 250000000) { + txdiv = 8; + txdiv0 = 3; + } else if (mipi_tx->data_rate >= 125000000) { + txdiv = 16; + txdiv0 = 4; + } else { + return -EINVAL; + } + + pcw_calc = ((u64)(mipi_tx->data_rate / 2) * txdiv) << 24; + pcw_calc = div_u64(pcw_calc, DSI_PHY_XTAL_CLK_HZ); + + if (pcw_calc > U32_MAX) { + dev_err(mipi_tx->dev, "Calculated PCW=%llu overflow!\n", pcw_calc); + return -EINVAL; + } + pcw = (u32)pcw_calc; + + mtk_phy_update_field(base + MIPITX_VOLTAGE_SEL, RG_DSI_PRD_REF_SEL, voltage); + writel(pres, base + MIPITX_PRESERVED); + + /* Enable the SDM and wait for power to stabilize */ + mtk_phy_set_bits(base + MIPITX_PLL_PWR, AD_DSI_PLL_SDM_PWR_ON); + mtk_phy_clear_bits(base + MIPITX_PLL_CON1, RG_DSI_PLL_EN); + udelay(30); + + /* Disable isolation and program PLL's PCW and dividers */ + mtk_phy_clear_bits(base + MIPITX_PLL_PWR, AD_DSI_PLL_SDM_ISO_EN); + writel(pcw, base + MIPITX_PLL_CON0); + mtk_phy_update_field(base + MIPITX_PLL_CON1, RG_DSI_PLL_POSDIV, txdiv0); + + /* Enable the PLL and wait for the clock output to stabilize */ + mtk_phy_set_bits(base + MIPITX_PLL_CON1, RG_DSI_PLL_EN); + udelay(30); + + return 0; +} + +static void mtk_mipi_tx_pll_disable(struct clk_hw *hw) +{ + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw); + void __iomem *base = mipi_tx->regs; + + mtk_phy_clear_bits(base + MIPITX_PLL_CON1, RG_DSI_PLL_EN); + + mtk_phy_set_bits(base + MIPITX_PLL_PWR, AD_DSI_PLL_SDM_ISO_EN); + mtk_phy_clear_bits(base + MIPITX_PLL_PWR, AD_DSI_PLL_SDM_PWR_ON); +} + +static int mtk_mipi_tx_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) +{ + req->rate = clamp_val(req->rate, + DSI_PHY_PLL_MIN_RATE_HZ, DSI_PHY_PLL_MAX_RATE_HZ); + + return 0; +} + +static const struct clk_ops mtk_mipi_tx_pll_ops = { + .enable = mtk_mipi_tx_pll_enable, + .disable = mtk_mipi_tx_pll_disable, + .determine_rate = mtk_mipi_tx_pll_determine_rate, + .set_rate = mtk_mipi_tx_pll_set_rate, + .recalc_rate = mtk_mipi_tx_pll_recalc_rate, +}; + +static void mtk_mipi_tx_power_on_signal(struct phy *phy) +{ + struct mtk_mipi_tx *mipi_tx = phy_get_drvdata(phy); + void __iomem *base = mipi_tx->regs; + + /* BG_LPF_EN / BG_CORE_EN */ + writel(RG_DSI_PAD_TIEL_SEL | RG_DSI_BG_CORE_EN, base + MIPITX_LANE_CON); + /* Wait for MIPI core to enable */ + usleep_range(30, 100); + writel(RG_DSI_BG_CORE_EN | RG_DSI_BG_LPF_EN, base + MIPITX_LANE_CON); + + /* Switch OFF each Lane */ + mtk_phy_clear_bits(base + MIPITX_D0_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_clear_bits(base + MIPITX_D1_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_clear_bits(base + MIPITX_D2_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_clear_bits(base + MIPITX_D3_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_clear_bits(base + MIPITX_CK_SW_CTL_EN, DSI_SW_CTL_EN); + + /* + * The MIPI TX drive strength is in the range of 3000 ~ 6000 microamps: + * RG_DSI_HSTX_LDO_REF_SEL expresses an offset from the minimum drive + * strength (3000uA) and can add a maximum offset of 3000uA, reaching a + * maximum drive strength of 3000+3000=6000uA. + */ + mtk_phy_update_field(base + MIPITX_VOLTAGE_SEL, RG_DSI_HSTX_LDO_REF_SEL, + (mipi_tx->mipitx_drive - 3000) / 200); + + mtk_phy_set_bits(base + MIPITX_CK_CKMODE_EN, DSI_CK_CKMODE_EN); +} + +static void mtk_mipi_tx_power_off_signal(struct phy *phy) +{ + struct mtk_mipi_tx *mipi_tx = phy_get_drvdata(phy); + void __iomem *base = mipi_tx->regs; + + /* Switch ON each lane one by one */ + mtk_phy_set_bits(base + MIPITX_D0_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_set_bits(base + MIPITX_D1_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_set_bits(base + MIPITX_D2_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_set_bits(base + MIPITX_D3_SW_CTL_EN, DSI_SW_CTL_EN); + mtk_phy_set_bits(base + MIPITX_CK_SW_CTL_EN, DSI_SW_CTL_EN); + + writel(RG_DSI_PAD_TIEL_SEL | RG_DSI_BG_CORE_EN, base + MIPITX_LANE_CON); + writel(RG_DSI_PAD_TIEL_SEL, base + MIPITX_LANE_CON); +} + +const struct mtk_mipitx_data mt8196_mipitx_data = { + .mipi_tx_clk_ops = &mtk_mipi_tx_pll_ops, + .mipi_tx_enable_signal = mtk_mipi_tx_power_on_signal, + .mipi_tx_disable_signal = mtk_mipi_tx_power_off_signal, +}; diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c index 065ea626093a..46f0cb3ac096 100644 --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c @@ -183,6 +183,7 @@ static const struct of_device_id mtk_mipi_tx_match[] = { { .compatible = "mediatek,mt2701-mipi-tx", .data = &mt2701_mipitx_data }, { .compatible = "mediatek,mt8173-mipi-tx", .data = &mt8173_mipitx_data }, { .compatible = "mediatek,mt8183-mipi-tx", .data = &mt8183_mipitx_data }, + { .compatible = "mediatek,mt8196-mipi-tx", .data = &mt8196_mipitx_data }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, mtk_mipi_tx_match); diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.h b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h index 5d4876f1dc95..e6f967078e3b 100644 --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.h +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h @@ -42,5 +42,5 @@ unsigned long mtk_mipi_tx_pll_recalc_rate(struct clk_hw *hw, extern const struct mtk_mipitx_data mt2701_mipitx_data; extern const struct mtk_mipitx_data mt8173_mipitx_data; extern const struct mtk_mipitx_data mt8183_mipitx_data; - +extern const struct mtk_mipitx_data mt8196_mipitx_data; #endif -- 2.54.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY 2026-07-13 10:38 ` AngeloGioacchino Del Regno @ 2026-07-13 10:48 ` sashiko-bot -1 siblings, 0 replies; 13+ messages in thread From: sashiko-bot @ 2026-07-13 10:48 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: conor+dt, dri-devel, devicetree, neil.armstrong, linux-phy, vkoul, robh, olteanv Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Signaling voltage boost is exclusively tied to the absolute maximum clamped frequency, preventing high data rates from receiving the boost. -- --- Patch [2]: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY --- commit a6b40caad1ac266a0481ef7b26baffceb672008c Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> phy: mediatek: Add support for MT8196 MIPI DSI PHY This commit adds support for the MIPI DSI PHY found in the MediaTek MT8196 SoC and its variants. It introduces a new register layout and basic D-PHY functionality needed to drive MIPI DSI displays. > diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c > new file mode 100644 > index 0000000000000..eac3db9922dba > --- /dev/null > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c [ ... ] > +static int mtk_mipi_tx_pll_enable(struct clk_hw *hw) > +{ > + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw); > + void __iomem *base = mipi_tx->regs; > + u32 voltage = RG_DSI_PRD_REF_MINI; > + u32 pres = MIPITX_PRESERVED_MINI; > + unsigned long long pcw_calc; > + unsigned int txdiv, txdiv0; > + u32 pcw; > + > + dev_dbg(mipi_tx->dev, "enable: %u bps\n", mipi_tx->data_rate); > + > + if (mipi_tx->data_rate >= DSI_PHY_PLL_MAX_RATE_HZ) { > + /* Select higher signaling voltage for fast data rates */ > + voltage = RG_DSI_PRD_REF_DEF; > + pres = MIPITX_PRESERVED_DEF; > + txdiv = 1; > + txdiv0 = 0; > + } else if (mipi_tx->data_rate >= 1000000000) { [Severity: Medium] Does this logic unintentionally restrict the higher signaling voltage to only exact matches of the maximum PLL rate? Since mtk_mipi_tx_pll_determine_rate() clamps the clock rate to DSI_PHY_PLL_MAX_RATE_HZ (2.0 GHz), mipi_tx->data_rate can never exceed this value. Consequently, panels requesting data rates slightly below 2.0 GHz (for example, 1.99 GHz) will fall through to the 1.0 GHz branch instead of receiving the voltage boost and correct PLL dividers intended for fast data rates. Could this conflation between the PLL octave band threshold and the maximum frequency clamp macro also break the PLL divider logic if the maximum supported rate limit is increased in the future? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260713103805.23030-1-angelogioacchino.delregno@collabora.com?part=2 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY @ 2026-07-13 10:48 ` sashiko-bot 0 siblings, 0 replies; 13+ messages in thread From: sashiko-bot @ 2026-07-13 10:48 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: conor+dt, dri-devel, devicetree, neil.armstrong, linux-phy, vkoul, robh, olteanv Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Signaling voltage boost is exclusively tied to the absolute maximum clamped frequency, preventing high data rates from receiving the boost. -- --- Patch [2]: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY --- commit a6b40caad1ac266a0481ef7b26baffceb672008c Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> phy: mediatek: Add support for MT8196 MIPI DSI PHY This commit adds support for the MIPI DSI PHY found in the MediaTek MT8196 SoC and its variants. It introduces a new register layout and basic D-PHY functionality needed to drive MIPI DSI displays. > diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c > new file mode 100644 > index 0000000000000..eac3db9922dba > --- /dev/null > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c [ ... ] > +static int mtk_mipi_tx_pll_enable(struct clk_hw *hw) > +{ > + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw); > + void __iomem *base = mipi_tx->regs; > + u32 voltage = RG_DSI_PRD_REF_MINI; > + u32 pres = MIPITX_PRESERVED_MINI; > + unsigned long long pcw_calc; > + unsigned int txdiv, txdiv0; > + u32 pcw; > + > + dev_dbg(mipi_tx->dev, "enable: %u bps\n", mipi_tx->data_rate); > + > + if (mipi_tx->data_rate >= DSI_PHY_PLL_MAX_RATE_HZ) { > + /* Select higher signaling voltage for fast data rates */ > + voltage = RG_DSI_PRD_REF_DEF; > + pres = MIPITX_PRESERVED_DEF; > + txdiv = 1; > + txdiv0 = 0; > + } else if (mipi_tx->data_rate >= 1000000000) { [Severity: Medium] Does this logic unintentionally restrict the higher signaling voltage to only exact matches of the maximum PLL rate? Since mtk_mipi_tx_pll_determine_rate() clamps the clock rate to DSI_PHY_PLL_MAX_RATE_HZ (2.0 GHz), mipi_tx->data_rate can never exceed this value. Consequently, panels requesting data rates slightly below 2.0 GHz (for example, 1.99 GHz) will fall through to the 1.0 GHz branch instead of receiving the voltage boost and correct PLL dividers intended for fast data rates. Could this conflation between the PLL octave band threshold and the maximum frequency clamp macro also break the PLL divider logic if the maximum supported rate limit is increased in the future? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260713103805.23030-1-angelogioacchino.delregno@collabora.com?part=2 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY 2026-07-13 10:48 ` sashiko-bot @ 2026-07-14 8:29 ` AngeloGioacchino Del Regno -1 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-14 8:29 UTC (permalink / raw) To: sashiko-reviews Cc: conor+dt, dri-devel, devicetree, neil.armstrong, linux-phy, vkoul, robh, olteanv On 7/13/26 12:48, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] Signaling voltage boost is exclusively tied to the absolute maximum clamped frequency, preventing high data rates from receiving the boost. > -- > > --- Patch [2]: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY --- > commit a6b40caad1ac266a0481ef7b26baffceb672008c > Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > phy: mediatek: Add support for MT8196 MIPI DSI PHY > > This commit adds support for the MIPI DSI PHY found in the MediaTek MT8196 > SoC and its variants. It introduces a new register layout and basic D-PHY > functionality needed to drive MIPI DSI displays. > >> diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c >> new file mode 100644 >> index 0000000000000..eac3db9922dba >> --- /dev/null >> +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c > > [ ... ] > >> +static int mtk_mipi_tx_pll_enable(struct clk_hw *hw) >> +{ >> + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw); >> + void __iomem *base = mipi_tx->regs; >> + u32 voltage = RG_DSI_PRD_REF_MINI; >> + u32 pres = MIPITX_PRESERVED_MINI; >> + unsigned long long pcw_calc; >> + unsigned int txdiv, txdiv0; >> + u32 pcw; >> + >> + dev_dbg(mipi_tx->dev, "enable: %u bps\n", mipi_tx->data_rate); >> + >> + if (mipi_tx->data_rate >= DSI_PHY_PLL_MAX_RATE_HZ) { >> + /* Select higher signaling voltage for fast data rates */ >> + voltage = RG_DSI_PRD_REF_DEF; >> + pres = MIPITX_PRESERVED_DEF; >> + txdiv = 1; >> + txdiv0 = 0; >> + } else if (mipi_tx->data_rate >= 1000000000) { > > [Severity: Medium] > Does this logic unintentionally restrict the higher signaling voltage to only > exact matches of the maximum PLL rate? > Yes, it does. It's fine. This is on purpose. There's a way to scale voltages a bit differently (for 4 different freq ranges) but it's a bit messy to implement, needs me to have different displays to test all different frequencies (which I don't have), and a bit more code. The only frequencies that really need the higher signaling voltage are the ones from 2GHz (which is currently the max frequency, but can be expanded later, as there will be new HW supporting higher freqs, with the same signaling voltage increase and the same code for it) onwards. > Since mtk_mipi_tx_pll_determine_rate() clamps the clock rate to > DSI_PHY_PLL_MAX_RATE_HZ (2.0 GHz), mipi_tx->data_rate can never exceed this > value. Consequently, panels requesting data rates slightly below 2.0 GHz > (for example, 1.99 GHz) will fall through to the 1.0 GHz branch instead of > receiving the voltage boost and correct PLL dividers intended for fast data > rates. > > Could this conflation between the PLL octave band threshold and the maximum > frequency clamp macro also break the PLL divider logic if the maximum > supported rate limit is increased in the future? > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY @ 2026-07-14 8:29 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2026-07-14 8:29 UTC (permalink / raw) To: sashiko-reviews Cc: conor+dt, dri-devel, devicetree, neil.armstrong, linux-phy, vkoul, robh, olteanv On 7/13/26 12:48, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] Signaling voltage boost is exclusively tied to the absolute maximum clamped frequency, preventing high data rates from receiving the boost. > -- > > --- Patch [2]: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY --- > commit a6b40caad1ac266a0481ef7b26baffceb672008c > Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > phy: mediatek: Add support for MT8196 MIPI DSI PHY > > This commit adds support for the MIPI DSI PHY found in the MediaTek MT8196 > SoC and its variants. It introduces a new register layout and basic D-PHY > functionality needed to drive MIPI DSI displays. > >> diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c >> new file mode 100644 >> index 0000000000000..eac3db9922dba >> --- /dev/null >> +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8196.c > > [ ... ] > >> +static int mtk_mipi_tx_pll_enable(struct clk_hw *hw) >> +{ >> + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw); >> + void __iomem *base = mipi_tx->regs; >> + u32 voltage = RG_DSI_PRD_REF_MINI; >> + u32 pres = MIPITX_PRESERVED_MINI; >> + unsigned long long pcw_calc; >> + unsigned int txdiv, txdiv0; >> + u32 pcw; >> + >> + dev_dbg(mipi_tx->dev, "enable: %u bps\n", mipi_tx->data_rate); >> + >> + if (mipi_tx->data_rate >= DSI_PHY_PLL_MAX_RATE_HZ) { >> + /* Select higher signaling voltage for fast data rates */ >> + voltage = RG_DSI_PRD_REF_DEF; >> + pres = MIPITX_PRESERVED_DEF; >> + txdiv = 1; >> + txdiv0 = 0; >> + } else if (mipi_tx->data_rate >= 1000000000) { > > [Severity: Medium] > Does this logic unintentionally restrict the higher signaling voltage to only > exact matches of the maximum PLL rate? > Yes, it does. It's fine. This is on purpose. There's a way to scale voltages a bit differently (for 4 different freq ranges) but it's a bit messy to implement, needs me to have different displays to test all different frequencies (which I don't have), and a bit more code. The only frequencies that really need the higher signaling voltage are the ones from 2GHz (which is currently the max frequency, but can be expanded later, as there will be new HW supporting higher freqs, with the same signaling voltage increase and the same code for it) onwards. > Since mtk_mipi_tx_pll_determine_rate() clamps the clock rate to > DSI_PHY_PLL_MAX_RATE_HZ (2.0 GHz), mipi_tx->data_rate can never exceed this > value. Consequently, panels requesting data rates slightly below 2.0 GHz > (for example, 1.99 GHz) will fall through to the 1.0 GHz branch instead of > receiving the voltage boost and correct PLL dividers intended for fast data > rates. > > Could this conflation between the PLL octave band threshold and the maximum > frequency clamp macro also break the PLL divider logic if the maximum > supported rate limit is increased in the future? > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY 2026-07-13 10:38 ` AngeloGioacchino Del Regno @ 2026-07-14 16:42 ` Vinod Koul -1 siblings, 0 replies; 13+ messages in thread From: Vinod Koul @ 2026-07-14 16:42 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: chunfeng.yun, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel On 13-07-26, 12:38, AngeloGioacchino Del Regno wrote: > Add support for the MIPI DSI PHY found in the MediaTek MT8196 SoC > and its variants. > This PHY has a different register layout and provides support for > more hardware features compared to the previous generation. > > This initial driver only adds support for basic functionality that > is necessary to drive MIPI DSI displays as a D-PHY. > > Feature additions like lane-swap, DPHY/CPHY switching, dual-port, > and others, may be done in the future. This seems to fail to build https://patchwork.kernel.org/project/linux-phy/patch/20260713103805.23030-2-angelogioacchino.delregno@collabora.com/ -- ~Vinod ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY @ 2026-07-14 16:42 ` Vinod Koul 0 siblings, 0 replies; 13+ messages in thread From: Vinod Koul @ 2026-07-14 16:42 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: chunfeng.yun, neil.armstrong, robh, krzk+dt, conor+dt, chunkuang.hu, p.zabel, matthias.bgg, justin.yeh, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, dri-devel, kernel On 13-07-26, 12:38, AngeloGioacchino Del Regno wrote: > Add support for the MIPI DSI PHY found in the MediaTek MT8196 SoC > and its variants. > This PHY has a different register layout and provides support for > more hardware features compared to the previous generation. > > This initial driver only adds support for basic functionality that > is necessary to drive MIPI DSI displays as a D-PHY. > > Feature additions like lane-swap, DPHY/CPHY switching, dual-port, > and others, may be done in the future. This seems to fail to build https://patchwork.kernel.org/project/linux-phy/patch/20260713103805.23030-2-angelogioacchino.delregno@collabora.com/ -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2026-07-14 16:42 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-07-13 10:38 [PATCH v3 0/2] PHY: Add support for MT8196 DSI PHY AngeloGioacchino Del Regno 2026-07-13 10:38 ` AngeloGioacchino Del Regno 2026-07-13 10:38 ` [PATCH v3 1/2] dt-bindings: phy: mediatek, dsi-phy: Add support for MT8196 AngeloGioacchino Del Regno 2026-07-13 10:38 ` [PATCH v3 1/2] dt-bindings: phy: mediatek,dsi-phy: " AngeloGioacchino Del Regno 2026-07-13 10:38 ` AngeloGioacchino Del Regno 2026-07-13 10:38 ` [PATCH v3 2/2] phy: mediatek: Add support for MT8196 MIPI DSI PHY AngeloGioacchino Del Regno 2026-07-13 10:38 ` AngeloGioacchino Del Regno 2026-07-13 10:48 ` sashiko-bot 2026-07-13 10:48 ` sashiko-bot 2026-07-14 8:29 ` AngeloGioacchino Del Regno 2026-07-14 8:29 ` AngeloGioacchino Del Regno 2026-07-14 16:42 ` Vinod Koul 2026-07-14 16:42 ` Vinod Koul
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.