All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Julia.Lawall@inria.fr, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	cocci@inria.fr, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: Re: [PATCH 28/36] regulator: wm831x-isink: remove conditional return with no effect
Date: Fri, 24 Jul 2026 09:24:55 +0100	[thread overview]
Message-ID: <amMhV5gRAeith0Cc@opensource.cirrus.com> (raw)
In-Reply-To: <20260723184538.3888637-29-ekffu200098@gmail.com>

On Fri, Jul 24, 2026 at 03:45:30AM +0900, Sang-Heon Jeon wrote:
> Both branches of the check return the same value, so the check has
> no effect. Remove it and return the value directly.
> 
> This is the result of running the Coccinelle script from
> scripts/coccinelle/misc/cond_return_no_effect.cocci.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Julia.Lawall@inria.fr, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	cocci@inria.fr, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: Re: [cocci] [PATCH 28/36] regulator: wm831x-isink: remove conditional return with no effect
Date: Fri, 24 Jul 2026 09:24:55 +0100	[thread overview]
Message-ID: <amMhV5gRAeith0Cc@opensource.cirrus.com> (raw)
In-Reply-To: <20260723184538.3888637-29-ekffu200098@gmail.com>

On Fri, Jul 24, 2026 at 03:45:30AM +0900, Sang-Heon Jeon wrote:
> Both branches of the check return the same value, so the check has
> no effect. Remove it and return the value directly.
> 
> This is the result of running the Coccinelle script from
> scripts/coccinelle/misc/cond_return_no_effect.cocci.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

  reply	other threads:[~2026-07-24  8:25 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 18:45 [PATCH 00/36] treewide: remove conditional returns with no effect Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [Intel-wired-lan] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 01/36] coccinelle: misc: add cond_return_no_effect.cocci Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-24 11:19   ` Markus Elfring
2026-07-24 11:38     ` Julia Lawall
2026-07-24 11:47       ` Markus Elfring
2026-07-24 14:42     ` Sang-Heon Jeon
2026-07-24 14:41   ` Sang-Heon Jeon
2026-07-24 14:55     ` Julia Lawall
2026-07-24 14:55       ` [cocci] " Julia Lawall
2026-07-23 18:45 ` [PATCH 02/36] drm/amd: remove conditional return with no effect Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 03/36] drm/radeon: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 04/36] dpll: zl3073x: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 05/36] drm/i915: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 06/36] drm: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 07/36] net: ethernet: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 20:24   ` Niklas Söderlund
2026-07-23 20:24     ` [cocci] " Niklas Söderlund
2026-07-23 20:35   ` Kiyanovski, Arthur
2026-07-23 20:35     ` [cocci] " Kiyanovski, Arthur
2026-07-23 18:45 ` [PATCH 08/36] net: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 19:04   ` Andrew Lunn
2026-07-23 19:04     ` [cocci] " Andrew Lunn
2026-07-23 18:45 ` [Intel-wired-lan] [PATCH 09/36] net: intel: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45   ` Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 10/36] wifi: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-24  0:37   ` Ping-Ke Shih
2026-07-24  0:37     ` [cocci] " Ping-Ke Shih
2026-07-23 18:45 ` [PATCH 11/36] ipvs: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 12/36] media: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 20:26   ` Niklas Söderlund
2026-07-23 20:26     ` [cocci] " Niklas Söderlund
2026-07-23 18:45 ` [PATCH 13/36] ALSA: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 14/36] ASoC: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-24  5:05   ` Mukunda,Vijendar
2026-07-24  5:05     ` [cocci] " Mukunda,Vijendar
2026-07-23 18:45 ` [PATCH 15/36] iio: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 21:46   ` Joshua Crofts
2026-07-23 21:46     ` [cocci] " Joshua Crofts
2026-07-24  0:38   ` Jonathan Cameron
2026-07-24  0:38     ` [cocci] " Jonathan Cameron
2026-07-23 18:45 ` [PATCH 16/36] Input: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 17/36] clk: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 18/36] crypto: drivers - " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 19/36] dmaengine: qcom_hidma: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 20/36] stm class: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 21/36] RDMA/ocrdma: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 22/36] iommu/s390: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 23/36] dm vdo: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 24/36] pinctrl: mediatek: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 25/36] platform/x86: toshiba_haps: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 26/36] power: supply: pm8916_lbc: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 27/36] RAS/AMD/ATL: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 19:44   ` Borislav Petkov
2026-07-23 19:44     ` [cocci] " Borislav Petkov
2026-07-23 18:45 ` [PATCH 28/36] regulator: wm831x-isink: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-24  8:24   ` Charles Keepax [this message]
2026-07-24  8:24     ` Charles Keepax
2026-07-23 18:45 ` [PATCH 29/36] rtc: pcf2127: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 30/36] scsi: mpt3sas: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 31/36] thermal/drivers/k3_bandgap: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 32/36] USB: serial: ch341: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 33/36] usb: typec: fusb302: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 34/36] smb: client: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 20:27   ` Steve French
2026-07-23 20:27     ` [cocci] " Steve French
2026-07-23 18:45 ` [PATCH 35/36] cpupower: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 36/36] memblock: " Sang-Heon Jeon
2026-07-23 18:45   ` [cocci] " Sang-Heon Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amMhV5gRAeith0Cc@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=broonie@kernel.org \
    --cc=cocci@inria.fr \
    --cc=ekffu200098@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.