All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
@ 2026-08-11 18:31 Stefan Hajnoczi
  2026-08-11 19:19 ` Peter Maydell
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2026-08-11 18:31 UTC (permalink / raw)
  To: qemu-devel
  Cc: Fabiano Rosas, Paolo Bonzini, Stefan Hajnoczi, Darren Kenny,
	Alexander Bulekov, Fam Zheng, Laurent Vivier,
	Philippe Mathieu-Daudé

As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.

Use the latest x86 q35 machine instead, otherwise we get:

  $ qemu-system-x86_64 -M pc-q35-5.2
  qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
  Use -machine help to list supported machines

See commit a35f8577a07 ("include/hw: add macros for deprecation
& removal of versioned machines") and f59ee044067 ("include/hw/boards:
cope with dev/rc versions in deprecation checks") for explanation
on automatically removed versioned machines.

This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
<philmd@linaro.org>.

Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/fuzz-virtio-scsi-test.c b/tests/qtest/fuzz-virtio-scsi-test.c
index e37b48b2cc1..102a5ccb67e 100644
--- a/tests/qtest/fuzz-virtio-scsi-test.c
+++ b/tests/qtest/fuzz-virtio-scsi-test.c
@@ -19,7 +19,7 @@ static void test_mmio_oob_from_memory_region_cache(void)
 {
     QTestState *s;
 
-    s = qtest_init("-M pc-q35-5.2 -m 512M "
+    s = qtest_init("-M q35 -m 512M "
                    "-device virtio-scsi,num_queues=8,addr=03.0 ");
 
     qtest_outl(s, 0xcf8, 0x80001811);
-- 
2.55.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
  2026-08-11 18:31 [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore Stefan Hajnoczi
@ 2026-08-11 19:19 ` Peter Maydell
  2026-08-11 19:20 ` Daniel P. Berrangé
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2026-08-11 19:19 UTC (permalink / raw)
  To: Stefan Hajnoczi
  Cc: qemu-devel, Fabiano Rosas, Paolo Bonzini, Darren Kenny,
	Alexander Bulekov, Fam Zheng, Laurent Vivier,
	Philippe Mathieu-Daudé

On Tue, 11 Aug 2026 at 19:32, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
>
> Use the latest x86 q35 machine instead, otherwise we get:
>
>   $ qemu-system-x86_64 -M pc-q35-5.2
>   qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>   Use -machine help to list supported machines
>
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
>
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
>
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
  2026-08-11 18:31 [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore Stefan Hajnoczi
  2026-08-11 19:19 ` Peter Maydell
@ 2026-08-11 19:20 ` Daniel P. Berrangé
  2026-08-11 20:13 ` Stefan Hajnoczi
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2026-08-11 19:20 UTC (permalink / raw)
  To: Stefan Hajnoczi
  Cc: qemu-devel, Fabiano Rosas, Paolo Bonzini, Darren Kenny,
	Alexander Bulekov, Fam Zheng, Laurent Vivier,
	Philippe Mathieu-Daudé

On Tue, Aug 11, 2026 at 02:31:44PM -0400, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>   $ qemu-system-x86_64 -M pc-q35-5.2
>   qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>   Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
  2026-08-11 18:31 [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore Stefan Hajnoczi
  2026-08-11 19:19 ` Peter Maydell
  2026-08-11 19:20 ` Daniel P. Berrangé
@ 2026-08-11 20:13 ` Stefan Hajnoczi
  2026-08-12  6:52 ` Philippe Mathieu-Daudé
  2026-08-12  8:33 ` Thomas Huth
  4 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2026-08-11 20:13 UTC (permalink / raw)
  To: qemu-devel
  Cc: Fabiano Rosas, Paolo Bonzini, Darren Kenny, Alexander Bulekov,
	Fam Zheng, Laurent Vivier, Philippe Mathieu-Daudé

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On Tue, Aug 11, 2026 at 02:31:44PM -0400, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>   $ qemu-system-x86_64 -M pc-q35-5.2
>   qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>   Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my staging tree:
https://gitlab.com/stefanha/qemu/commits/staging

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
  2026-08-11 18:31 [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore Stefan Hajnoczi
                   ` (2 preceding siblings ...)
  2026-08-11 20:13 ` Stefan Hajnoczi
@ 2026-08-12  6:52 ` Philippe Mathieu-Daudé
  2026-08-12  8:33 ` Thomas Huth
  4 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-08-12  6:52 UTC (permalink / raw)
  To: Stefan Hajnoczi, qemu-devel
  Cc: Fabiano Rosas, Paolo Bonzini, Darren Kenny, Alexander Bulekov,
	Fam Zheng, Laurent Vivier, Philippe Mathieu-Daudé

On 11/8/26 20:31, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>    $ qemu-system-x86_64 -M pc-q35-5.2
>    qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>    Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
  2026-08-11 18:31 [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore Stefan Hajnoczi
                   ` (3 preceding siblings ...)
  2026-08-12  6:52 ` Philippe Mathieu-Daudé
@ 2026-08-12  8:33 ` Thomas Huth
  4 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2026-08-12  8:33 UTC (permalink / raw)
  To: Stefan Hajnoczi, qemu-devel
  Cc: Fabiano Rosas, Paolo Bonzini, Darren Kenny, Alexander Bulekov,
	Fam Zheng, Laurent Vivier, Philippe Mathieu-Daudé

On 11/08/2026 20.31, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>    $ qemu-system-x86_64 -M pc-q35-5.2
>    qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>    Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/fuzz-virtio-scsi-test.c b/tests/qtest/fuzz-virtio-scsi-test.c
> index e37b48b2cc1..102a5ccb67e 100644
> --- a/tests/qtest/fuzz-virtio-scsi-test.c
> +++ b/tests/qtest/fuzz-virtio-scsi-test.c
> @@ -19,7 +19,7 @@ static void test_mmio_oob_from_memory_region_cache(void)
>   {
>       QTestState *s;
>   
> -    s = qtest_init("-M pc-q35-5.2 -m 512M "
> +    s = qtest_init("-M q35 -m 512M "
>                      "-device virtio-scsi,num_queues=8,addr=03.0 ");
>   
>       qtest_outl(s, 0xcf8, 0x80001811);

I wonder whether we should rather remove the test completely instead? Those 
tests based on the fuzzers rely on a certain way of doing their MMIO - if a 
newer machine type has a slightly different MMIO layout, the test basically 
does not test anything useful anymore. WDYT?

  Thomas



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-08-12  8:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-11 18:31 [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore Stefan Hajnoczi
2026-08-11 19:19 ` Peter Maydell
2026-08-11 19:20 ` Daniel P. Berrangé
2026-08-11 20:13 ` Stefan Hajnoczi
2026-08-12  6:52 ` Philippe Mathieu-Daudé
2026-08-12  8:33 ` Thomas Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.