All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, richard.henderson@linaro.org
Subject: Re: [PATCH] hw/misc: fix trace-events
Date: Tue, 25 Aug 2026 10:30:32 +0100	[thread overview]
Message-ID: <ao1guN9kDZVCje1Y@redhat.com> (raw)
In-Reply-To: <20260825074114.853069-1-marcandre.lureau@redhat.com>

On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> trace events.

More importantly CI failed to report that build failure. IIUC, this
is likely due to missing libigvm library. We have this available in
Fedora at least, not sure about other distros, but we can add igvm
to libvirt-ci and then to QEMU's deps list for CI.

> 
> Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/misc/trace-events | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index 16db4ba0cc17..0b8be3d0f226 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d"
>  # k230_decomp_gzip.c
>  k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64
>  k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64
> +
> +# vmlaunchupdate.c
> +launch_update_write(void) ""
> +vmlaunch_reset_enter(void) ""
> +vm_launchupdate_finalize(void) ""
> +restore_host_x86_igvm(void) ""
> -- 
> 2.55.0.543.g5ebe2ebe4ea8
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



  reply	other threads:[~2026-08-25  9:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  7:41 [PATCH] hw/misc: fix trace-events marcandre.lureau
2026-08-25  9:30 ` Daniel P. Berrangé [this message]
2026-08-25 11:28   ` Daniel P. Berrangé
2026-08-25 11:38     ` Marc-André Lureau
2026-08-25 11:10 ` Luigi Leonardi
2026-08-25 21:51 ` Philippe Mathieu-Daudé
2026-08-26  8:30 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao1guN9kDZVCje1Y@redhat.com \
    --to=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.