* Re: [PATCH] hw/misc: fix trace-events
2026-08-25 7:41 [PATCH] hw/misc: fix trace-events marcandre.lureau
@ 2026-08-25 9:30 ` Daniel P. Berrangé
2026-08-25 11:28 ` Daniel P. Berrangé
2026-08-25 11:10 ` Luigi Leonardi
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Daniel P. Berrangé @ 2026-08-25 9:30 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel, richard.henderson
On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> trace events.
More importantly CI failed to report that build failure. IIUC, this
is likely due to missing libigvm library. We have this available in
Fedora at least, not sure about other distros, but we can add igvm
to libvirt-ci and then to QEMU's deps list for CI.
>
> Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/misc/trace-events | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index 16db4ba0cc17..0b8be3d0f226 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d"
> # k230_decomp_gzip.c
> k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64
> k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64
> +
> +# vmlaunchupdate.c
> +launch_update_write(void) ""
> +vmlaunch_reset_enter(void) ""
> +vm_launchupdate_finalize(void) ""
> +restore_host_x86_igvm(void) ""
> --
> 2.55.0.543.g5ebe2ebe4ea8
>
>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] hw/misc: fix trace-events
2026-08-25 9:30 ` Daniel P. Berrangé
@ 2026-08-25 11:28 ` Daniel P. Berrangé
2026-08-25 11:38 ` Marc-André Lureau
0 siblings, 1 reply; 7+ messages in thread
From: Daniel P. Berrangé @ 2026-08-25 11:28 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel, richard.henderson
On Tue, Aug 25, 2026 at 10:30:32AM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> > trace events.
>
> More importantly CI failed to report that build failure. IIUC, this
> is likely due to missing libigvm library. We have this available in
> Fedora at least, not sure about other distros, but we can add igvm
> to libvirt-ci and then to QEMU's deps list for CI.
Proposed the mapping addition which will let us build-test it:
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/583
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/misc: fix trace-events
2026-08-25 11:28 ` Daniel P. Berrangé
@ 2026-08-25 11:38 ` Marc-André Lureau
0 siblings, 0 replies; 7+ messages in thread
From: Marc-André Lureau @ 2026-08-25 11:38 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel, richard.henderson
Hi
On Tue, Aug 25, 2026 at 3:29 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Tue, Aug 25, 2026 at 10:30:32AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
> > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > >
> > > The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> > > trace events.
> >
> > More importantly CI failed to report that build failure. IIUC, this
> > is likely due to missing libigvm library. We have this available in
> > Fedora at least, not sure about other distros, but we can add igvm
> > to libvirt-ci and then to QEMU's deps list for CI.
>
> Proposed the mapping addition which will let us build-test it:
>
> https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/583
thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/misc: fix trace-events
2026-08-25 7:41 [PATCH] hw/misc: fix trace-events marcandre.lureau
2026-08-25 9:30 ` Daniel P. Berrangé
@ 2026-08-25 11:10 ` Luigi Leonardi
2026-08-25 21:51 ` Philippe Mathieu-Daudé
2026-08-26 8:30 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 7+ messages in thread
From: Luigi Leonardi @ 2026-08-25 11:10 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel, richard.henderson
On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
>From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
>trace events.
>
>Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
>Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>---
> hw/misc/trace-events | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/hw/misc/trace-events b/hw/misc/trace-events
>index 16db4ba0cc17..0b8be3d0f226 100644
>--- a/hw/misc/trace-events
>+++ b/hw/misc/trace-events
>@@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d"
> # k230_decomp_gzip.c
> k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64
> k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64
>+
>+# vmlaunchupdate.c
>+launch_update_write(void) ""
>+vmlaunch_reset_enter(void) ""
>+vm_launchupdate_finalize(void) ""
>+restore_host_x86_igvm(void) ""
>--
>2.55.0.543.g5ebe2ebe4ea8
>
>
Thanks!
Reviewed-by: Luigi Leonardi <leonardi@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] hw/misc: fix trace-events
2026-08-25 7:41 [PATCH] hw/misc: fix trace-events marcandre.lureau
2026-08-25 9:30 ` Daniel P. Berrangé
2026-08-25 11:10 ` Luigi Leonardi
@ 2026-08-25 21:51 ` Philippe Mathieu-Daudé
2026-08-26 8:30 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-08-25 21:51 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: richard.henderson
On 25/8/26 09:41, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> trace events.
>
> Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/misc/trace-events | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] hw/misc: fix trace-events
2026-08-25 7:41 [PATCH] hw/misc: fix trace-events marcandre.lureau
` (2 preceding siblings ...)
2026-08-25 21:51 ` Philippe Mathieu-Daudé
@ 2026-08-26 8:30 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-08-26 8:30 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: richard.henderson
On 25/8/26 09:41, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> trace events.
>
> Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/misc/trace-events | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index 16db4ba0cc17..0b8be3d0f226 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d"
> # k230_decomp_gzip.c
> k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64
> k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64
> +
> +# vmlaunchupdate.c
> +launch_update_write(void) ""
> +vmlaunch_reset_enter(void) ""
> +vm_launchupdate_finalize(void) ""
> +restore_host_x86_igvm(void) ""
Applying: hw/misc: fix trace-events
Patch failed at 0001 hw/misc: fix trace-events
error: patch failed: hw/misc/trace-events:446
error: hw/misc/trace-events: patch does not apply
already committed as 8fda982a7c083251635a2ce41dcc068ed0e5c124.
^ permalink raw reply [flat|nested] 7+ messages in thread