All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/x264: disable asm on i386
@ 2026-07-11 11:17 Bernd Kuhls
  2026-07-11 11:17 ` [Buildroot] [PATCH 2/2] package/x264: bump version to git 0480cb05fa Bernd Kuhls
  2026-08-16 15:12 ` [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 4+ messages in thread
From: Bernd Kuhls @ 2026-07-11 11:17 UTC (permalink / raw)
  To: buildroot; +Cc: David du Colombier

Fixes build errors

In function 'x264_predictor_clip_mmx2',
    inlined from 'x264_8_me_search_ref' at encoder/me.c:231:30:
./common/osdep.h:455:13: error: 'asm' operand has impossible constraints
 or there are not enough registers
  455 | #define asm __asm__

Fixes:
https://autobuild.buildroot.net/results/3db/3dbc13972fe0c31584cbc9d9f928ea0d13a1ad4d/

The oldest build error of this kind dates back to 2022 with gcc 10:
https://autobuild.buildroot.net/results/080/08011e939f9d2ed949392656d744c53b1bb07117/
so a backport to LTS branches should be considered.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
Gitlab pipelines passed:
https://gitlab.com/bkuhls/buildroot/-/commits/d59ef84f5e18a4f05c04061dcbcea691479d3045

 package/x264/x264.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/x264/x264.mk b/package/x264/x264.mk
index e96d993017..858486af54 100644
--- a/package/x264/x264.mk
+++ b/package/x264/x264.mk
@@ -13,7 +13,7 @@ X264_LICENSE_FILES = COPYING
 X264_INSTALL_STAGING = YES
 X264_CONF_OPTS = --disable-avs --disable-lavf --disable-swscale
 
-ifeq ($(BR2_i386)$(BR2_x86_64),y)
+ifeq ($(BR2_x86_64),y)
 ifeq ($(BR2_TOOLCHAIN_USES_MUSL)$(BR2_PIC_PIE),yy)
 # libx264 uses large amounts of non-pic assembly code, resulting in text
 # section relocations, which are not supported on musl-libc's ld.so.
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-10 17:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-11 11:17 [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Bernd Kuhls
2026-07-11 11:17 ` [Buildroot] [PATCH 2/2] package/x264: bump version to git 0480cb05fa Bernd Kuhls
2026-08-16 15:12 ` [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Thomas Petazzoni via buildroot
2026-10-10 17:50   ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.