All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/x264: disable asm on i386
@ 2026-07-11 11:17 Bernd Kuhls
  2026-07-11 11:17 ` [Buildroot] [PATCH 2/2] package/x264: bump version to git 0480cb05fa Bernd Kuhls
  2026-08-16 15:12 ` [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 4+ messages in thread
From: Bernd Kuhls @ 2026-07-11 11:17 UTC (permalink / raw)
  To: buildroot; +Cc: David du Colombier

Fixes build errors

In function 'x264_predictor_clip_mmx2',
    inlined from 'x264_8_me_search_ref' at encoder/me.c:231:30:
./common/osdep.h:455:13: error: 'asm' operand has impossible constraints
 or there are not enough registers
  455 | #define asm __asm__

Fixes:
https://autobuild.buildroot.net/results/3db/3dbc13972fe0c31584cbc9d9f928ea0d13a1ad4d/

The oldest build error of this kind dates back to 2022 with gcc 10:
https://autobuild.buildroot.net/results/080/08011e939f9d2ed949392656d744c53b1bb07117/
so a backport to LTS branches should be considered.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
Gitlab pipelines passed:
https://gitlab.com/bkuhls/buildroot/-/commits/d59ef84f5e18a4f05c04061dcbcea691479d3045

 package/x264/x264.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/x264/x264.mk b/package/x264/x264.mk
index e96d993017..858486af54 100644
--- a/package/x264/x264.mk
+++ b/package/x264/x264.mk
@@ -13,7 +13,7 @@ X264_LICENSE_FILES = COPYING
 X264_INSTALL_STAGING = YES
 X264_CONF_OPTS = --disable-avs --disable-lavf --disable-swscale
 
-ifeq ($(BR2_i386)$(BR2_x86_64),y)
+ifeq ($(BR2_x86_64),y)
 ifeq ($(BR2_TOOLCHAIN_USES_MUSL)$(BR2_PIC_PIE),yy)
 # libx264 uses large amounts of non-pic assembly code, resulting in text
 # section relocations, which are not supported on musl-libc's ld.so.
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] package/x264: bump version to git 0480cb05fa
  2026-07-11 11:17 [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Bernd Kuhls
@ 2026-07-11 11:17 ` Bernd Kuhls
  2026-08-16 15:12 ` [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 4+ messages in thread
From: Bernd Kuhls @ 2026-07-11 11:17 UTC (permalink / raw)
  To: buildroot; +Cc: David du Colombier

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
Gitlab pipelines passed:
https://gitlab.com/bkuhls/buildroot/-/commits/e8272329a492289972dc19540ecd933fadfa22ec

 package/x264/x264.hash | 2 +-
 package/x264/x264.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/x264/x264.hash b/package/x264/x264.hash
index dc2d3d7b5b..31657d5ab3 100644
--- a/package/x264/x264.hash
+++ b/package/x264/x264.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  adb3f2f780607420134def42d0fac58be9c6de718a451f3f0ec56236a783f937  x264-baee400fa9ced6f5481a728138fed6e867b0ff7f-git4.tar.gz
+sha256  dbfac9615e62cc85a638643ae0ba8cdfecff645755fcded389b53507eebb23ec  x264-0480cb05fa188d37ae87e8f4fd8f1aea3711f7ee-git4.tar.gz
 sha256  32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670  COPYING
diff --git a/package/x264/x264.mk b/package/x264/x264.mk
index 858486af54..78b4dcf5e9 100644
--- a/package/x264/x264.mk
+++ b/package/x264/x264.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-X264_VERSION = baee400fa9ced6f5481a728138fed6e867b0ff7f
+X264_VERSION = 0480cb05fa188d37ae87e8f4fd8f1aea3711f7ee
 X264_SITE = https://code.videolan.org/videolan/x264.git
 X264_SITE_METHOD = git
 X264_LICENSE = GPL-2.0+
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/x264: disable asm on i386
  2026-07-11 11:17 [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Bernd Kuhls
  2026-07-11 11:17 ` [Buildroot] [PATCH 2/2] package/x264: bump version to git 0480cb05fa Bernd Kuhls
@ 2026-08-16 15:12 ` Thomas Petazzoni via buildroot
  2026-10-10 17:50   ` Thomas Petazzoni via buildroot
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-08-16 15:12 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, David du Colombier

On Sat, Jul 11, 2026 at 01:17:42PM +0200, Bernd Kuhls wrote:
> Fixes build errors
> 
> In function 'x264_predictor_clip_mmx2',
>     inlined from 'x264_8_me_search_ref' at encoder/me.c:231:30:
> ./common/osdep.h:455:13: error: 'asm' operand has impossible constraints
>  or there are not enough registers
>   455 | #define asm __asm__

Is this a gcc bug, or an x264 issue?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/x264: disable asm on i386
  2026-08-16 15:12 ` [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Thomas Petazzoni via buildroot
@ 2026-10-10 17:50   ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-10 17:50 UTC (permalink / raw)
  To: Bernd Kuhls, buildroot, David du Colombier

On Sun, Aug 16, 2026 at 05:12:55PM +0200, Thomas Petazzoni via buildroot wrote:
> On Sat, Jul 11, 2026 at 01:17:42PM +0200, Bernd Kuhls wrote:
> > Fixes build errors
> > 
> > In function 'x264_predictor_clip_mmx2',
> >     inlined from 'x264_8_me_search_ref' at encoder/me.c:231:30:
> > ./common/osdep.h:455:13: error: 'asm' operand has impossible constraints
> >  or there are not enough registers
> >   455 | #define asm __asm__
> 
> Is this a gcc bug, or an x264 issue?

Gentle ping.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-10 17:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-11 11:17 [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Bernd Kuhls
2026-07-11 11:17 ` [Buildroot] [PATCH 2/2] package/x264: bump version to git 0480cb05fa Bernd Kuhls
2026-08-16 15:12 ` [Buildroot] [PATCH 1/2] package/x264: disable asm on i386 Thomas Petazzoni via buildroot
2026-10-10 17:50   ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.