From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Yixun Lan" <dlan@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>, "Frank Li" <Frank.Li@nxp.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Sherry Sun" <sherry.sun@nxp.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Christian Bruel" <christian.bruel@foss.st.com>,
"Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
"Senchuan Zhang" <zhangsenchuan@eswincomputing.com>,
"Alex Elder" <elder@riscstar.com>,
"Xincheng Zhang" <zhangxincheng@ultrarisc.com>,
"Randolph Lin" <randolph@andestech.com>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Pengpeng Hou" <pengpeng@iscas.ac.cn>,
"Anirudh Srinivasan" <asrinivasan@oss.tenstorrent.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, "Yixun Lan" <dlan@gentoo.org>,
"Longbin Li" <looong.bin@gmail.com>
Subject: Re: [PATCH v5 1/6] PCI: spacemit-k1: Add device data support
Date: Tue, 8 Sep 2026 13:26:44 +0300 [thread overview]
Message-ID: <ap_i5Pw4nVB4LZ-7@ashevche-desk.local> (raw)
In-Reply-To: <20260907112606.465778-2-inochiama@gmail.com>
On Mon, Sep 07, 2026 at 07:26:00PM +0800, Inochi Amaoto wrote:
> To reuse the K1 PCIe driver logic for K3 PCIe controller, add device
> data to handle the K1 specific logic and make room for the incoming
> logic for K3.
...
> static int k1_pcie_probe(struct platform_device *pdev)
> {
> + const struct k1_pcie_device_data *data;
> struct device *dev = &pdev->dev;
> struct k1_pcie *k1;
> int ret;
>
> + data = device_get_match_data(dev);
> + if (!data)
> + return -ENODEV;
It's better to use -ENODATA which will help to distinguish from other ENODEV
cases (which are more often to happen).
> k1 = devm_kzalloc(dev, sizeof(*k1), GFP_KERNEL);
> if (!k1)
> return -ENOMEM;
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Yixun Lan" <dlan@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>, "Frank Li" <Frank.Li@nxp.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Sherry Sun" <sherry.sun@nxp.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Christian Bruel" <christian.bruel@foss.st.com>,
"Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
"Senchuan Zhang" <zhangsenchuan@eswincomputing.com>,
"Alex Elder" <elder@riscstar.com>,
"Xincheng Zhang" <zhangxincheng@ultrarisc.com>,
"Randolph Lin" <randolph@andestech.com>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Pengpeng Hou" <pengpeng@iscas.ac.cn>,
"Anirudh Srinivasan" <asrinivasan@oss.tenstorrent.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, "Yixun Lan" <dlan@gentoo.org>,
"Longbin Li" <looong.bin@gmail.com>
Subject: Re: [PATCH v5 1/6] PCI: spacemit-k1: Add device data support
Date: Tue, 8 Sep 2026 13:26:44 +0300 [thread overview]
Message-ID: <ap_i5Pw4nVB4LZ-7@ashevche-desk.local> (raw)
In-Reply-To: <20260907112606.465778-2-inochiama@gmail.com>
On Mon, Sep 07, 2026 at 07:26:00PM +0800, Inochi Amaoto wrote:
> To reuse the K1 PCIe driver logic for K3 PCIe controller, add device
> data to handle the K1 specific logic and make room for the incoming
> logic for K3.
...
> static int k1_pcie_probe(struct platform_device *pdev)
> {
> + const struct k1_pcie_device_data *data;
> struct device *dev = &pdev->dev;
> struct k1_pcie *k1;
> int ret;
>
> + data = device_get_match_data(dev);
> + if (!data)
> + return -ENODEV;
It's better to use -ENODATA which will help to distinguish from other ENODEV
cases (which are more often to happen).
> k1 = devm_kzalloc(dev, sizeof(*k1), GFP_KERNEL);
> if (!k1)
> return -ENOMEM;
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-09-08 10:26 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 11:25 [PATCH v5 0/6] riscv: spacemit: Add PCIe RC controller support for K3 Inochi Amaoto
2026-09-07 11:25 ` Inochi Amaoto
2026-09-07 11:26 ` [PATCH v5 1/6] PCI: spacemit-k1: Add device data support Inochi Amaoto
2026-09-07 11:26 ` Inochi Amaoto
2026-09-07 11:31 ` sashiko-bot
2026-09-08 10:26 ` Andy Shevchenko [this message]
2026-09-08 10:26 ` Andy Shevchenko
2026-09-09 8:00 ` Inochi Amaoto
2026-09-09 8:00 ` Inochi Amaoto
2026-09-10 5:44 ` Yao Zi
2026-09-10 5:44 ` Yao Zi
2026-09-10 6:42 ` Andy Shevchenko
2026-09-10 6:42 ` Andy Shevchenko
2026-09-10 12:15 ` Yao Zi
2026-09-10 12:15 ` Yao Zi
2026-09-07 11:26 ` [PATCH v5 2/6] PCI: spacemit-k1: Add multiple PHY handles support Inochi Amaoto
2026-09-07 11:26 ` Inochi Amaoto
2026-09-07 11:37 ` sashiko-bot
2026-09-08 10:29 ` Andy Shevchenko
2026-09-08 10:29 ` Andy Shevchenko
2026-09-09 8:00 ` Inochi Amaoto
2026-09-09 8:00 ` Inochi Amaoto
2026-09-09 14:27 ` Andy Shevchenko
2026-09-09 14:27 ` Andy Shevchenko
2026-09-07 11:26 ` [PATCH v5 3/6] PCI: spacemit-k1: Add device id update helper Inochi Amaoto
2026-09-07 11:26 ` Inochi Amaoto
2026-09-07 11:31 ` sashiko-bot
2026-09-07 11:26 ` [PATCH v5 4/6] dt-bindings: PCI: snps,dw-pcie: Add msi-parent for MSI handle check Inochi Amaoto
2026-09-07 11:26 ` Inochi Amaoto
2026-09-07 11:35 ` sashiko-bot
2026-09-07 11:26 ` [PATCH v5 5/6] dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller Inochi Amaoto
2026-09-07 11:26 ` Inochi Amaoto
2026-09-07 11:38 ` sashiko-bot
2026-09-07 13:08 ` Troy Mitchell
2026-09-07 13:08 ` Troy Mitchell
2026-09-09 8:01 ` Inochi Amaoto
2026-09-09 8:01 ` Inochi Amaoto
2026-09-07 11:26 ` [PATCH v5 6/6] PCI: spacemit-k1: Add Spacemit K3 PCIe host controller support Inochi Amaoto
2026-09-07 11:26 ` Inochi Amaoto
2026-09-07 11:42 ` sashiko-bot
2026-09-07 13:14 ` Troy Mitchell
2026-09-07 13:14 ` Troy Mitchell
2026-09-09 7:51 ` Inochi Amaoto
2026-09-09 7:51 ` Inochi Amaoto
2026-09-10 9:51 ` Troy Mitchell
2026-09-10 9:51 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap_i5Pw4nVB4LZ-7@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=asrinivasan@oss.tenstorrent.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=christian.bruel@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=dlan@kernel.org \
--cc=elder@riscstar.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=inochiama@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=palmer@dabbelt.com \
--cc=pengpeng@iscas.ac.cn \
--cc=pjw@kernel.org \
--cc=randolph@andestech.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=sherry.sun@nxp.com \
--cc=spacemit@lists.linux.dev \
--cc=u.kleine-koenig@baylibre.com \
--cc=vidyas@nvidia.com \
--cc=zhangsenchuan@eswincomputing.com \
--cc=zhangxincheng@ultrarisc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.