Re: [PATCH v2 1/3] staging: rtl8723bs: rename local vars in phy_tx_power_limit_to_index()

[Leonardo Martins Martins <dev.lmmrtns@gmail.com>]

On Fri, Oct 02, 2026 at 08:09:28AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 02, 2026 at 01:07:35AM -0300, Leonardo Martins Martins wrote:
> > In phy_tx_power_limit_to_index(), there are many mixed-case local
> > variables, rename them to adhere to the linux kernel coding style.
> > 
> > Signed-off-by: Leonardo Martins Martins <dev.lmmrtns@gmail.com>
> > ---
> > Renamed Variables:
> > 	pHalData -> hal_data
> > 	Adapter -> adapter
> > 	BW40PwrBasedBm2_4G -> pwr_base
> 
> "power_base"?

Yeah power_base does seem better.

> 
> > 	rateSection -> rs
> 
> What's wrong with "rate_selection"?  We have lots of characters you can
> use :)

Here I used rs instead of rate_section because I saw it being used
like that in rtw88, and I also saw the "Naming" section of
Documentation/process/coding-style.rst where it says local variable
names should be short and to the point.

Regardless, I don't have any strong opinions on these variable names,
rate_section is also fine, so I'll just use that in v3.

> 
> > 	tempValue -> tmp
> > 	tempPwrLmt -> tmp_pwr_lmt
> > 	rfPath -> path
> 
> Why isn't this in the changelog text?

Oh it really should be, my bad.

Best Regards,
Leonardo Martins