All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [PATCH v3 4/4] iotests/108: skip if fuse is unsuable
Date: Thu, 24 Sep 2026 15:00:38 +0200	[thread overview]
Message-ID: <arUe9s7ggIpAYiO9@redhat.com> (raw)
In-Reply-To: <20260813183740.3503107-5-farman@linux.ibm.com>

Am 13.08.2026 um 20:37 hat Eric Farman geschrieben:
> It is possible that the ability to fusermount is restricted
> to privileged users. Rather than waiting for this test to
> perform a mount and subsequently fail, perform a dummy mount
> early on and skip the tests if fuse is not usable.
> 
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

There is a typo in the subject line (s/unsuable/unusable/).

>  tests/qemu-iotests/108 | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108
> index bf808b3512..8dc725cf66 100755
> --- a/tests/qemu-iotests/108
> +++ b/tests/qemu-iotests/108
> @@ -73,6 +73,23 @@ else
>          _notrun 'Passwordless sudo for losetup or FUSE support required, but' \
>                  'neither is available'
>      fi
> +
> +    # Test to see if fuse is usable or not (permissions, etc.)
> +    export_mp="$TEST_DIR/fuse-export"
> +    touch "$export_mp"
> +
> +    response=$($QSD \
> +        --blockdev null-co,node-name=export-node \
> +        --export fuse,id=fuse-export,node-name=export-node,mountpoint="$export_mp",allow-other=off \
> +        --pidfile "$TEST_DIR/qsd.pid" 2>&1)

If FUSE is available, this hangs because QSD doesn't exit by itself, but
waits for clients to connect.

--daemonize might give you the right semantics (print errors while
setting up the export to stderr, exit after initialising everything)
when combined with your code below to kill QSD.

> +    if [[ $response = *"Failed to mount FUSE session to export"* ]]; then
> +        _notrun 'FUSE support is not usable (permission error?)'
> +    fi

Should this part use _notrun_on_fuse_error()?

Kevin



  reply	other threads:[~2026-09-24 13:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 18:37 [PATCH v3 0/4] iotests fixes Eric Farman
2026-08-13 18:37 ` [PATCH v3 1/4] iotests/nbd-in-qcow2-chain: use default machine Eric Farman
2026-09-24 13:04   ` Kevin Wolf
2026-09-25 21:01     ` Eric Blake
2026-08-13 18:37 ` [PATCH v3 2/4] iotests/nbd-tls-iothread: skip on non-x86 hardware Eric Farman
2026-08-13 18:37 ` [PATCH v3 3/4] iotests/fuse-truncate: skip if FUSE is not usable Eric Farman
2026-08-13 18:37 ` [PATCH v3 4/4] iotests/108: skip if fuse is unsuable Eric Farman
2026-09-24 13:00   ` Kevin Wolf [this message]
2026-09-24 14:55     ` Eric Farman
2026-09-23 15:51 ` [PATCH v3 0/4] iotests fixes Eric Farman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arUe9s7ggIpAYiO9@redhat.com \
    --to=kwolf@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=hreitz@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.