Re: [PATCH v3 1/4] iotests/nbd-in-qcow2-chain: use default machine

[Kevin Wolf <kwolf@redhat.com>]

Am 13.08.2026 um 20:37 hat Eric Farman geschrieben:
> Some of the NBD tests explicitly specify `-machine q35` which won't work
> when running against, say, qemu-system-s390x.
> 
> The nbd-in-qcow2-chain test runs fine with the default machine on a z16
> host, so allow it to run in other configurations.
> 
> Fixes: 24fd6d75b3 ("iotests: Add coverage of recent NBD qio deadlock fix")
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
>  tests/qemu-iotests/tests/nbd-in-qcow2-chain | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/tests/nbd-in-qcow2-chain b/tests/qemu-iotests/tests/nbd-in-qcow2-chain
> index 455ddfa86f..e35f072eba 100755
> --- a/tests/qemu-iotests/tests/nbd-in-qcow2-chain
> +++ b/tests/qemu-iotests/tests/nbd-in-qcow2-chain
> @@ -43,7 +43,7 @@ TEST_IMG="$TEST_IMG.base" _make_test_img $size
>  echo
>  echo "=== Starting QEMU and exposing base image ==="
>  
> -_launch_qemu -machine q35
> +_launch_qemu
>  h1=$QEMU_HANDLE
>  _send_qemu_cmd $QEMU_HANDLE '{"execute": "qmp_capabilities"}' 'return'
>  _send_qemu_cmd $QEMU_HANDLE '{"execute": "blockdev-add",

I don't see what the machine type is needed for, so this is probably
fine.

Eric (Blake), any specific reason you added the machine type in this
test case so that removing it might cause a regression?

Kevin