Re: [PATCH v3 1/4] iotests/nbd-in-qcow2-chain: use default machine

[Eric Blake <eblake@redhat.com>]

On Thu, Sep 24, 2026 at 03:04:46PM +0200, Kevin Wolf wrote:
> Am 13.08.2026 um 20:37 hat Eric Farman geschrieben:
> > Some of the NBD tests explicitly specify `-machine q35` which won't work
> > when running against, say, qemu-system-s390x.
> > 
> > The nbd-in-qcow2-chain test runs fine with the default machine on a z16
> > host, so allow it to run in other configurations.
> > 
> > Fixes: 24fd6d75b3 ("iotests: Add coverage of recent NBD qio deadlock fix")
> > Signed-off-by: Eric Farman <farman@linux.ibm.com>
> > ---

> >  
> > -_launch_qemu -machine q35
> > +_launch_qemu
> >  h1=$QEMU_HANDLE
> >  _send_qemu_cmd $QEMU_HANDLE '{"execute": "qmp_capabilities"}' 'return'
> >  _send_qemu_cmd $QEMU_HANDLE '{"execute": "blockdev-add",
> 
> I don't see what the machine type is needed for, so this is probably
> fine.
> 
> Eric (Blake), any specific reason you added the machine type in this
> test case so that removing it might cause a regression?

This would have been copy-and-paste from some other test, and not
something specific to this one.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org